fix: updated level page to always show import buttons

Author: simone-lungarella

ROADMAP.md

@@ -72,7 +72,8 @@ Secondary mechanics are:
 
 
 - [ ] Add hint when copied level code;
-- [ ] Disable save button when name or code is missing in import window;
-- [ ] Update level interface when importing a level;
+- [x] Disable save button when name or code is missing in import window;
+- [x] Update level interface when importing a level;
 - [x] Duplicate inspection panel for normal/custom levels;
+- [x] When custom levels page are full, add a placeholder plage;
 

assets/resources/levels/persistent_levels.tres

@@ -1,4 +1,4 @@
-[gd_resource type="Resource" script_class="LevelContainer" load_steps=33 format=3 uid="uid://cjy7x1yxt7fai"]
+[gd_resource type="Resource" script_class="LevelContainer" load_steps=39 format=3]
 
 [ext_resource type="Script" path="res://scripts/utility/cell_data.gd" id="1_6i8uv"]
 [ext_resource type="Script" path="res://scripts/utility/level_data.gd" id="2_0gd78"]
@@ -192,11 +192,52 @@ Vector2i(0, 1): SubResource("Resource_08a6n")
 }
 moves_left = 1
 
+[sub_resource type="Resource" id="Resource_d2d8n"]
+script = ExtResource("1_6i8uv")
+is_blocked = false
+value = 0
+
+[sub_resource type="Resource" id="Resource_iqndp"]
+script = ExtResource("1_6i8uv")
+is_blocked = false
+value = 0
+
+[sub_resource type="Resource" id="Resource_0bs3p"]
+script = ExtResource("1_6i8uv")
+is_blocked = false
+value = -1
+
+[sub_resource type="Resource" id="Resource_kwqon"]
+script = ExtResource("1_6i8uv")
+is_blocked = false
+value = -1
+
+[sub_resource type="Resource" id="Resource_ud33m"]
+script = ExtResource("3_xl0g1")
+area_effect = 0
+area_behavior = 0
+
+[sub_resource type="Resource" id="Resource_dt2ar"]
+script = ExtResource("2_0gd78")
+width = 3
+height = 3
+cells_list = {
+Vector2i(0, 0): SubResource("Resource_d2d8n"),
+Vector2i(0, 1): SubResource("Resource_iqndp"),
+Vector2i(1, 0): SubResource("Resource_0bs3p"),
+Vector2i(1, 1): SubResource("Resource_kwqon")
+}
+slider_list = {
+Vector2i(0, 1): SubResource("Resource_ud33m")
+}
+moves_left = 1
+
 [resource]
 script = ExtResource("4_v7vmu")
 levels = {
 "01": SubResource("Resource_8kl84"),
 "04": SubResource("Resource_duaxn"),
-"1": SubResource("Resource_iwiep")
+"1": SubResource("Resource_iwiep"),
+"test1": SubResource("Resource_dt2ar")
 }
-levels_order = Array[String](["1", "01", "04"])
+levels_order = Array[String](["1", "01", "04", "test1"])

assets/resources/themes/button_error.tres

@@ -0,0 +1,13 @@
+[gd_resource type="StyleBoxFlat" format=3 uid="uid://cd3jmdgaeav3d"]
+
+[resource]
+bg_color = Color(0.6, 0.6, 0.6, 0)
+border_width_left = 5
+border_width_top = 5
+border_width_right = 5
+border_width_bottom = 5
+border_color = Color(0.972549, 0.196078, 0.196078, 1)
+corner_radius_top_left = 20
+corner_radius_top_right = 20
+corner_radius_bottom_right = 20
+corner_radius_bottom_left = 20

assets/resources/themes/text_area.tres

@@ -2,10 +2,10 @@
 
 [resource]
 bg_color = Color(1, 0.972549, 0.937255, 1)
-border_width_left = 10
-border_width_top = 10
-border_width_right = 10
-border_width_bottom = 10
+border_width_left = 5
+border_width_top = 5
+border_width_right = 5
+border_width_bottom = 5
 border_color = Color(0.25098, 0.184314, 0.105882, 1)
 corner_radius_top_left = 20
 corner_radius_top_right = 20

packed_scene/user_interface/LevelImport.tscn

@@ -106,6 +106,7 @@ layout_mode = 2
 size_flags_horizontal = 5
 focus_mode = 0
 theme = ExtResource("3_18iy2")
+disabled = true
 icon = SubResource("CompressedTexture2D_ud3al")
 
 [connection signal="gui_input" from="Background" to="." method="_on_background_gui_input"]

scripts/user_interface/level_import.gd

@@ -1,9 +1,15 @@
 extends Control
 
+const BUTTON_ERROR = preload("res://assets/resources/themes/button_error.tres")
 var _inserted_code: String
 
 @onready var code: Button = %Code
 @onready var level_name: LineEdit = %LevelName
+@onready var save_btn: Button = %SaveBtn
+
+
+func _ready() -> void:
+	GameManager.on_state_change.connect(_on_state_change)
 
 
 func _on_background_gui_input(event: InputEvent) -> void:
@@ -12,17 +18,23 @@ func _on_background_gui_input(event: InputEvent) -> void:
 
 
 func _on_save_btn_pressed() -> void:
-	var level_data := Encoder.decode(_inserted_code)
+	var level_data: LevelData = Encoder.decode(_inserted_code)
 	if level_data == null:
-		pass
-	GameManager.save_custom_level(level_name.text, level_data)
+		_show_error()
+	else:
+		GameManager.save_custom_level(level_name.text, level_data)
+		GameManager.level_ui.add_imported_level(level_name.text)
+		code.text = ""
+		level_name.text = ""
+		self.hide()
 
 
 func _on_code_pressed() -> void:
 	var cb_content := DisplayServer.clipboard_get()
 	_inserted_code = cb_content.split("\n")[0]
 
 	code.text = " " + _inserted_code
+	_update_save_btn()
 
 
 func _on_level_name_text_changed(new_text: String) -> void:
@@ -35,3 +47,39 @@ func _on_level_name_text_changed(new_text: String) -> void:
 		level_name.caret_column = level_name.text.length()
 	else:
 		level_name.text = ""
+
+	_update_save_btn()
+
+
+func _update_save_btn() -> void:
+	if code.text == "" or level_name.text == "":
+		save_btn.disabled = true
+	else:
+		save_btn.disabled = false
+
+
+func _on_state_change(new_state: GlobalConst.GameState) -> void:
+	match new_state:
+		GlobalConst.GameState.LEVEL_IMPORT:
+			self.show()
+		GlobalConst.GameState.MAIN_MENU:
+			self.queue_free.call_deferred()
+		GlobalConst.GameState.BUILDER_IDLE:
+			self.queue_free.call_deferred()
+		GlobalConst.GameState.LEVEL_START:
+			self.queue_free.call_deferred()
+		_:
+			self.hide()
+
+
+func _show_error() -> void:
+	save_btn.disabled = true
+	code.add_theme_stylebox_override("normal", BUTTON_ERROR)
+	code.add_theme_color_override("icon_normal_color", Color.DARK_RED)
+	code.add_theme_color_override("font_color", Color.DARK_RED)
+
+	await get_tree().create_timer(1).timeout
+	code.remove_theme_stylebox_override("normal")
+	code.remove_theme_color_override("icon_normal_color")
+	code.remove_theme_color_override("font_color")
+	code.text = ""

scripts/user_interface/level_inspect.gd

@@ -14,7 +14,6 @@ var _level_name: String
 @onready var unlock_btn: Button = %UnlockBtn
 @onready var build_btn: Button = %BuildBtn
 @onready var play_btn: Button = %PlayBtn
-@onready var copy_btn: Button = %CopyBtn
 
 
 func _ready() -> void:
@@ -96,5 +95,6 @@ func _update_buttons(is_unlocked: bool) -> void:
 
 
 func _on_unlock_btn_pressed() -> void:
+	GameManager.unlock_level(GlobalConst.LevelGroup.MAIN, _level_name)
 	_update_buttons(true)
 	level_unlocked.emit()

scripts/user_interface/level_ui.gd

@@ -18,6 +18,26 @@ func _ready() -> void:
 	_update_content()
 
 
+func add_imported_level(level_name: String) -> void:
+	_placeholder_buttons[-1].queue_free()
+	_placeholder_buttons.remove_at(_placeholder_buttons.size() - 1)
+
+	var level_button := LevelButton.new()
+	level_button.on_delete_level_button.connect(_update_last_level)
+	_level_buttons.append(level_button)
+	level_grid.add_child(level_button)
+
+	var progress = LevelProgress.new()
+	progress.move_left = -1000
+	progress.is_unlocked = true
+	progress.is_completed = true
+
+	level_button.construct(level_name, progress, GlobalConst.LevelGroup.CUSTOM)
+	level_grid.move_child(level_button, _level_buttons.size() - 1)
+	# Show next page button if there are no placeholder buttons
+	_update_buttons(_placeholder_buttons.size() == 0)
+
+
 func _on_state_change(new_state: GlobalConst.GameState) -> void:
 	match new_state:
 		GlobalConst.GameState.MAIN_MENU:
@@ -46,7 +66,11 @@ func _update_content() -> void:
 	var levels_progress: Dictionary
 	# get extra level for test next page
 	levels_progress = GameManager.get_page_levels(_world, first_level, last_level + 1)
-	_update_buttons(levels_progress.size() > PAGE_SIZE)
+	match _world:
+		GlobalConst.LevelGroup.MAIN:
+			_update_buttons(levels_progress.size() > PAGE_SIZE)
+		GlobalConst.LevelGroup.CUSTOM:
+			_update_buttons(levels_progress.size() > PAGE_SIZE - 1)
 
 	var max_level_btn := mini(levels_progress.size(), PAGE_SIZE)
 	# remove excess level button
@@ -101,7 +125,12 @@ func _update_last_level(ref: LevelButton) -> void:
 	var levels_progress: Dictionary
 	# get extra level for test next page
 	levels_progress = GameManager.get_page_levels(_world, last_level, last_level + 1)
-	_update_buttons(levels_progress.size() > 1)
+
+	match _world:
+		GlobalConst.LevelGroup.MAIN:
+			_update_buttons(levels_progress.size() > 1)
+		GlobalConst.LevelGroup.CUSTOM:
+			_update_buttons(levels_progress.size() > 0)
 
 	if levels_progress.size() > 0:
 		# add level button
@@ -154,3 +183,7 @@ func _on_custom_btn_pressed() -> void:
 	_world = GlobalConst.LevelGroup.CUSTOM
 	_current_page = 1
 	_update_content()
+
+
+func _add_empty_page() -> void:
+	pass

scripts/user_interface/main_menu.gd

@@ -53,6 +53,7 @@ func _on_level_btn_pressed():
 	level_ui = LEVEL_UI.instantiate()
 	get_tree().root.add_child.call_deferred(level_ui)
 
+	GameManager.level_ui = level_ui
 	GameManager.change_state.call_deferred(GlobalConst.GameState.LEVEL_PICK)
 
 

scripts/utility/const.gd

@@ -13,6 +13,7 @@ enum GameState {
 	BUILDER_TEST,
 	BUILDER_RESIZE,
 	LEVEL_INSPECT,
+	LEVEL_IMPORT,
 	CUSTOM_LEVEL_INSPECT
 }
 enum LevelGroup { CUSTOM, MAIN }