Skip to content

Commit 9542e07

Browse files
lukaskollmerlukaskollmer
authored
in which we remove the Test build config from the TestApp (#25)
# in which we remove the Test build config from the TestApp ## ♻️ Current situation & Problem the TestApp, for some reason, has, alongside `Debug` and `Release`, a `Test` build config. this, afaict, isn't used for anything and is effectively identical to the Debug config, the only difference being that it sets a `TEST` flag which can be detected using `#if`. however, this `TEST` flag is a) never used, and b) completely useless bc it doesn't actually propagate into any SPM dependencies and only takes effect within the TestApp (which is only used for testing anyway...) also, afaict, none of our tests actually get run in this config; the TestApp scheme defaults its tests to the Debug build config... ## ⚙️ Release Notes - removed the `Test` build config ## 📚 Documentation n/a ## ✅ Testing n/a ### Code of Conduct & Contributing Guidelines By creating and submitting this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
1 parent d7ea0da commit 9542e07

File tree

1 file changed

+0
-178
lines changed

1 file changed

+0
-178
lines changed

‎Tests/UITests/UITests.xcodeproj/project.pbxproj‎

Lines changed: 0 additions & 178 deletions
Original file line numberDiff line numberDiff line change
@@ -662,37 +662,6 @@
662662
};
663663
name = Debug;
664664
};
665-
2F9CBECC2A76C412009818FF /* Test */ = {
666-
isa = XCBuildConfiguration;
667-
buildSettings = {
668-
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
669-
ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS = YES;
670-
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
671-
CODE_SIGN_STYLE = Automatic;
672-
CURRENT_PROJECT_VERSION = 1;
673-
DEVELOPMENT_TEAM = 637867499T;
674-
ENABLE_PREVIEWS = YES;
675-
ENABLE_USER_SCRIPT_SANDBOXING = YES;
676-
GCC_C_LANGUAGE_STANDARD = gnu17;
677-
GENERATE_INFOPLIST_FILE = YES;
678-
INFOPLIST_KEY_UISupportedInterfaceOrientations = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown";
679-
INFOPLIST_KEY_WKCompanionAppBundleIdentifier = edu.stanford.templatepackage.testapp;
680-
INFOPLIST_KEY_WKRunsIndependentlyOfCompanionApp = YES;
681-
LD_RUNPATH_SEARCH_PATHS = (
682-
"$(inherited)",
683-
"@executable_path/Frameworks",
684-
);
685-
LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
686-
MARKETING_VERSION = 1.0;
687-
PRODUCT_BUNDLE_IDENTIFIER = edu.stanford.templatepackage.testapp.watchkitapp;
688-
PRODUCT_NAME = "TestApp Watch App";
689-
SDKROOT = watchos;
690-
SKIP_INSTALL = YES;
691-
SWIFT_EMIT_LOC_STRINGS = YES;
692-
TARGETED_DEVICE_FAMILY = 4;
693-
};
694-
name = Test;
695-
};
696665
2F9CBECD2A76C412009818FF /* Release */ = {
697666
isa = XCBuildConfiguration;
698667
buildSettings = {
@@ -746,27 +715,6 @@
746715
};
747716
name = Debug;
748717
};
749-
2F9CBED52A76C412009818FF /* Test */ = {
750-
isa = XCBuildConfiguration;
751-
buildSettings = {
752-
ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS = YES;
753-
CODE_SIGN_STYLE = Automatic;
754-
CURRENT_PROJECT_VERSION = 1;
755-
DEVELOPMENT_TEAM = 637867499T;
756-
ENABLE_USER_SCRIPT_SANDBOXING = YES;
757-
GCC_C_LANGUAGE_STANDARD = gnu17;
758-
GENERATE_INFOPLIST_FILE = YES;
759-
LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
760-
MARKETING_VERSION = 1.0;
761-
PRODUCT_BUNDLE_IDENTIFIER = edu.stanford.templatepackage.testapp.watchkitapp.uitests;
762-
PRODUCT_NAME = "$(TARGET_NAME)";
763-
SDKROOT = watchos;
764-
SWIFT_EMIT_LOC_STRINGS = NO;
765-
TARGETED_DEVICE_FAMILY = 4;
766-
TEST_TARGET_NAME = TestAppWatchApp;
767-
};
768-
name = Test;
769-
};
770718
2F9CBED62A76C412009818FF /* Release */ = {
771719
isa = XCBuildConfiguration;
772720
buildSettings = {
@@ -788,135 +736,13 @@
788736
};
789737
name = Release;
790738
};
791-
2FB07587299DDB6000C0B37F /* Test */ = {
792-
isa = XCBuildConfiguration;
793-
buildSettings = {
794-
ALWAYS_SEARCH_USER_PATHS = NO;
795-
ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS = YES;
796-
CLANG_ANALYZER_NONNULL = YES;
797-
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
798-
CLANG_CXX_LANGUAGE_STANDARD = "gnu++20";
799-
CLANG_ENABLE_MODULES = YES;
800-
CLANG_ENABLE_OBJC_ARC = YES;
801-
CLANG_ENABLE_OBJC_WEAK = YES;
802-
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
803-
CLANG_WARN_BOOL_CONVERSION = YES;
804-
CLANG_WARN_COMMA = YES;
805-
CLANG_WARN_CONSTANT_CONVERSION = YES;
806-
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
807-
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
808-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
809-
CLANG_WARN_EMPTY_BODY = YES;
810-
CLANG_WARN_ENUM_CONVERSION = YES;
811-
CLANG_WARN_INFINITE_RECURSION = YES;
812-
CLANG_WARN_INT_CONVERSION = YES;
813-
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
814-
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
815-
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
816-
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
817-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
818-
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
819-
CLANG_WARN_STRICT_PROTOTYPES = YES;
820-
CLANG_WARN_SUSPICIOUS_MOVE = YES;
821-
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
822-
CLANG_WARN_UNREACHABLE_CODE = YES;
823-
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
824-
COPY_PHASE_STRIP = NO;
825-
DEBUG_INFORMATION_FORMAT = dwarf;
826-
ENABLE_STRICT_OBJC_MSGSEND = YES;
827-
ENABLE_TESTABILITY = YES;
828-
GCC_C_LANGUAGE_STANDARD = gnu11;
829-
GCC_DYNAMIC_NO_PIC = NO;
830-
GCC_NO_COMMON_BLOCKS = YES;
831-
GCC_OPTIMIZATION_LEVEL = 0;
832-
GCC_PREPROCESSOR_DEFINITIONS = (
833-
"DEBUG=1",
834-
"$(inherited)",
835-
);
836-
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
837-
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
838-
GCC_WARN_UNDECLARED_SELECTOR = YES;
839-
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
840-
GCC_WARN_UNUSED_FUNCTION = YES;
841-
GCC_WARN_UNUSED_VARIABLE = YES;
842-
IPHONEOS_DEPLOYMENT_TARGET = 17.0;
843-
MACOSX_DEPLOYMENT_TARGET = 14.0;
844-
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
845-
MTL_FAST_MATH = YES;
846-
ONLY_ACTIVE_ARCH = YES;
847-
SDKROOT = iphoneos;
848-
SWIFT_ACTIVE_COMPILATION_CONDITIONS = TEST;
849-
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
850-
SWIFT_VERSION = 6.0;
851-
TVOS_DEPLOYMENT_TARGET = 17.0;
852-
WATCHOS_DEPLOYMENT_TARGET = 10.0;
853-
XROS_DEPLOYMENT_TARGET = 1.0;
854-
};
855-
name = Test;
856-
};
857-
2FB07588299DDB6000C0B37F /* Test */ = {
858-
isa = XCBuildConfiguration;
859-
buildSettings = {
860-
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
861-
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
862-
CODE_SIGN_STYLE = Automatic;
863-
CURRENT_PROJECT_VERSION = 1;
864-
DEVELOPMENT_ASSET_PATHS = "";
865-
DEVELOPMENT_TEAM = 637867499T;
866-
ENABLE_PREVIEWS = YES;
867-
ENABLE_TESTING_SEARCH_PATHS = YES;
868-
GENERATE_INFOPLIST_FILE = YES;
869-
INFOPLIST_KEY_UIApplicationSceneManifest_Generation = YES;
870-
INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents = YES;
871-
INFOPLIST_KEY_UILaunchScreen_Generation = YES;
872-
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight";
873-
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone = "UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight";
874-
LD_RUNPATH_SEARCH_PATHS = (
875-
"$(inherited)",
876-
"@executable_path/Frameworks",
877-
);
878-
MARKETING_VERSION = 1.0;
879-
PRODUCT_BUNDLE_IDENTIFIER = edu.stanford.templatepackage.testapp;
880-
PRODUCT_NAME = "$(TARGET_NAME)";
881-
SUPPORTED_PLATFORMS = "appletvos appletvsimulator iphoneos iphonesimulator macosx xros xrsimulator";
882-
SUPPORTS_MACCATALYST = NO;
883-
SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD = NO;
884-
SUPPORTS_XR_DESIGNED_FOR_IPHONE_IPAD = NO;
885-
SWIFT_EMIT_LOC_STRINGS = YES;
886-
SWIFT_STRICT_CONCURRENCY = complete;
887-
TARGETED_DEVICE_FAMILY = "1,2,3,7";
888-
};
889-
name = Test;
890-
};
891-
2FB07589299DDB6000C0B37F /* Test */ = {
892-
isa = XCBuildConfiguration;
893-
buildSettings = {
894-
CODE_SIGN_STYLE = Automatic;
895-
CURRENT_PROJECT_VERSION = 1;
896-
DEVELOPMENT_TEAM = 637867499T;
897-
GENERATE_INFOPLIST_FILE = YES;
898-
MARKETING_VERSION = 1.0;
899-
PRODUCT_BUNDLE_IDENTIFIER = edu.stanford.templatepackage.testapp.uitests;
900-
PRODUCT_NAME = "$(TARGET_NAME)";
901-
PROVISIONING_PROFILE = "";
902-
SUPPORTED_PLATFORMS = "appletvos appletvsimulator iphoneos iphonesimulator macosx xros xrsimulator";
903-
SUPPORTS_MACCATALYST = NO;
904-
SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD = NO;
905-
SUPPORTS_XR_DESIGNED_FOR_IPHONE_IPAD = NO;
906-
SWIFT_EMIT_LOC_STRINGS = NO;
907-
TARGETED_DEVICE_FAMILY = "1,2,3,7";
908-
TEST_TARGET_NAME = TestApp;
909-
};
910-
name = Test;
911-
};
912739
/* End XCBuildConfiguration section */
913740

914741
/* Begin XCConfigurationList section */
915742
2F6D138D28F5F384007C25D6 /* Build configuration list for PBXProject "UITests" */ = {
916743
isa = XCConfigurationList;
917744
buildConfigurations = (
918745
2F6D13B428F5F386007C25D6 /* Debug */,
919-
2FB07587299DDB6000C0B37F /* Test */,
920746
2F6D13B528F5F386007C25D6 /* Release */,
921747
);
922748
defaultConfigurationIsVisible = 0;
@@ -926,7 +752,6 @@
926752
isa = XCConfigurationList;
927753
buildConfigurations = (
928754
2F6D13B728F5F386007C25D6 /* Debug */,
929-
2FB07588299DDB6000C0B37F /* Test */,
930755
2F6D13B828F5F386007C25D6 /* Release */,
931756
);
932757
defaultConfigurationIsVisible = 0;
@@ -936,7 +761,6 @@
936761
isa = XCConfigurationList;
937762
buildConfigurations = (
938763
2F6D13BD28F5F386007C25D6 /* Debug */,
939-
2FB07589299DDB6000C0B37F /* Test */,
940764
2F6D13BE28F5F386007C25D6 /* Release */,
941765
);
942766
defaultConfigurationIsVisible = 0;
@@ -946,7 +770,6 @@
946770
isa = XCConfigurationList;
947771
buildConfigurations = (
948772
2F9CBECB2A76C412009818FF /* Debug */,
949-
2F9CBECC2A76C412009818FF /* Test */,
950773
2F9CBECD2A76C412009818FF /* Release */,
951774
);
952775
defaultConfigurationIsVisible = 0;
@@ -956,7 +779,6 @@
956779
isa = XCConfigurationList;
957780
buildConfigurations = (
958781
2F9CBED42A76C412009818FF /* Debug */,
959-
2F9CBED52A76C412009818FF /* Test */,
960782
2F9CBED62A76C412009818FF /* Release */,
961783
);
962784
defaultConfigurationIsVisible = 0;

0 commit comments

Comments
 (0)