Skip to content

Commit 51d75f9

Browse files
Ace3 port (#87)
* Add Ace3 libs * Buggy, but initial functionality is present Stubbed in the rough outline for our graphical options. The settings still need to be fixed to work between clients, and only 1 panel is done so far. This is most a proof of concept. * Create chat panel * Add combat panel, add headers under the main descriptions * Create Nameplates panel * Add Floating Combat Text panel * Create cVar Panel * Add getCustomVar and setCustomVar back, not sure what they do * Adjust margins in cVar browser to match Ace3 styles * add horizontal separator after general panel desc to match other panels * Remove libs from repo and pull them in via pkgmeta instead * Update CI scripts * Don't scan libs folder in CI * Update .editorconfig * Delete unused tempfix file * Add Status Text panel, fix FCT panel deprecated functionality Add in a Status Text panel, however a few of the frames have been deprecated in wow Retail. I have hidden the affected options from the GUI for Retail. Likewise, I fixed the lost functionality in FCT earlier in the porting process. * no need for FCT_SetValue() to be on the addon namespace, make it local * No need for setStatusTextBars or setStatusText to be on the addon namespace * Return original reverse-loot and reverse-cleanup functionality * hack for SetInsertItemsRightToLeft() not being instant SetInsertItemsLeftToRight() and SetSortBagsRightToLeft() don't happen instantly, thus the UI will retain the old value since the refresh happens too clickly for the "Get" counterparts to reflect the new values. This is a hack wherein we set a 1/2 second timer to refresh the GUI to allow time for the setting to go through. * Use hidden instead of disabled for client-specific options * fix CI * rename CVar browser section --------- Co-authored-by: Benjamin Staneck <[email protected]>
1 parent c90c107 commit 51d75f9

19 files changed

+21188
-20721
lines changed

.editorconfig

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1-
root = true
2-
3-
[*]
4-
indent_style = space
5-
indent_size = 4
6-
end_of_line = lf
7-
charset = utf-8
8-
trim_trailing_whitespace = true
9-
insert_final_newline = true
1+
root = true
2+
3+
[*]
4+
indent_style = space
5+
indent_size = 4
6+
end_of_line = lf
7+
charset = utf-8
8+
trim_trailing_whitespace = true
9+
insert_final_newline = true
10+
11+
[*.yml]
12+
indent_size = 2

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ jobs:
77
runs-on: ubuntu-latest
88

99
steps:
10-
- uses: actions/checkout@v1
10+
- uses: actions/checkout@v4
1111
with:
12-
fetch-depth: 150
12+
fetch-depth: 0
1313

1414
- name: Install and run Luacheck
1515
uses: nebularg/actions-luacheck@v1

.github/workflows/pr.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ jobs:
77
runs-on: ubuntu-latest
88

99
steps:
10-
- uses: actions/checkout@v1
10+
- uses: actions/checkout@v4
1111
with:
12-
fetch-depth: 150
12+
fetch-depth: 0
1313

1414
- name: Install and run Luacheck
1515
uses: nebularg/actions-luacheck@v1
@@ -37,11 +37,6 @@ jobs:
3737
name: AIO-PR${{ github.event.number }}-classic
3838
path: .release/
3939

40-
- uses: actions/upload-artifact@v2
41-
with:
42-
name: AIO-PR${{ github.event.number }}-bcc
43-
path: .release/
44-
4540
- name: Create Cata Package
4641
uses: BigWigsMods/packager@master
4742
with:
@@ -51,4 +46,3 @@ jobs:
5146
with:
5247
name: AIO-PR${{ github.event.number }}-cata
5348
path: .release/
54-

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
cvars2.dump
2-
debug.lua
2+
debug.lua
3+
.vscode/
4+
.idea/
5+
libs/

0 commit comments

Comments
 (0)