[Core] Refactor to reduce GC pressure;

[Math] Add comparison operators to Rect/RectFloat;

Author: LittleCodingFox

Engine/Core/Audio/AudioSystem.cs

@@ -233,7 +233,7 @@ public void Update()
 
         Transform listenerTransform = null;
 
-        foreach((Entity _, Transform transform, AudioListener listener) in audioListeners)
+        foreach((Entity _, Transform transform, AudioListener listener) in audioListeners.Contents)
         {
             listenerTransform ??= transform;
 

Engine/Core/Entities/EntityQuery.cs

@@ -1,7 +1,5 @@
 using Staple.Internal;
 using System;
-using System.Collections;
-using System.Collections.Generic;
 
 namespace Staple;
 
@@ -33,7 +31,7 @@ public enum EntityQueryMode
 /// It automatically updates as the world changes.
 /// </summary>
 /// <typeparam name="T">A type of component to get</typeparam>
-public sealed class EntityQuery<T> : ISceneQuery, IEnumerable<T>
+public sealed class EntityQuery<T> : ISceneQuery
     where T : IComponent
 {
     private T[] contents = [];
@@ -52,11 +50,21 @@ public sealed class EntityQuery<T> : ISceneQuery, IEnumerable<T>
     /// </summary>
     public T Content => content;
 
+    /// <summary>
+    /// Contained content. Only valid if we have a single element.
+    /// </summary>
+    public T[] Contents => contents;
+
     /// <summary>
     /// The content with its entity, if available.
     /// </summary>
     public (Entity, T) ContentEntity => contentEntity;
 
+    /// <summary>
+    /// The content with its entity, if available.
+    /// </summary>
+    public (Entity, T)[] ContentEntities => contentEntities;
+
     public T this[int index] => contents[index];
 
     /// <summary>
@@ -168,20 +176,4 @@ public void WorldChanged()
             }
         }
     }
-
-    public IEnumerator<T> GetEnumerator()
-    {
-        foreach (var result in contents)
-        {
-            yield return result;
-        }
-    }
-
-    IEnumerator IEnumerable.GetEnumerator()
-    {
-        foreach (var result in contents)
-        {
-            yield return result;
-        }
-    }
 }

Engine/Core/Math/Rect.cs

@@ -1,4 +1,6 @@
 using MessagePack;
+using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Numerics;
 
 namespace Staple;
@@ -84,6 +86,32 @@ public readonly bool Contains(Vector2 v)
             v.Y >= top && v.Y <= bottom;
     }
 
+    public static bool operator==(Rect lhs, Rect rhs)
+    {
+        return lhs.left == rhs.left &&
+            lhs.right == rhs.right &&
+            lhs.top == rhs.top &&
+            lhs.bottom == rhs.bottom;
+    }
+
+    public static bool operator !=(Rect lhs, Rect rhs)
+    {
+        return lhs.left != rhs.left ||
+            lhs.right != rhs.right ||
+            lhs.top != rhs.top ||
+            lhs.bottom != rhs.bottom;
+    }
+
+    public override bool Equals([NotNullWhen(true)] object obj)
+    {
+        if(obj is Rect rhs)
+        {
+            return this == rhs;
+        }
+
+        return false;
+    }
+
     public readonly bool ShouldSerializeIsEmpty() => false;
 
     public readonly bool ShouldSerializeMin() => false;
@@ -93,4 +121,9 @@ public readonly bool Contains(Vector2 v)
     public readonly bool ShouldSerializeWidth() => false;
 
     public readonly bool ShouldSerializeHeight() => false;
+
+    public override readonly int GetHashCode()
+    {
+        return HashCode.Combine(left, right, top, bottom);
+    }
 }

Engine/Core/Math/RectFloat.cs

@@ -1,4 +1,6 @@
 using MessagePack;
+using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Numerics;
 
 namespace Staple;
@@ -69,11 +71,42 @@ public float Height
         }
     }
 
+    public static bool operator ==(RectFloat lhs, RectFloat rhs)
+    {
+        return lhs.left == rhs.left &&
+            lhs.right == rhs.right &&
+            lhs.top == rhs.top &&
+            lhs.bottom == rhs.bottom;
+    }
+
+    public static bool operator !=(RectFloat lhs, RectFloat rhs)
+    {
+        return lhs.left != rhs.left ||
+            lhs.right != rhs.right ||
+            lhs.top != rhs.top ||
+            lhs.bottom != rhs.bottom;
+    }
+
+    public override bool Equals([NotNullWhen(true)] object obj)
+    {
+        if (obj is RectFloat rhs)
+        {
+            return this == rhs;
+        }
+
+        return false;
+    }
+
     public readonly bool ShouldSerializeMin() => false;
 
     public readonly bool ShouldSerializeMax() => false;
 
     public readonly bool ShouldSerializeWidth() => false;
 
     public readonly bool ShouldSerializeHeight() => false;
+
+    public override readonly int GetHashCode()
+    {
+        return HashCode.Combine(left, right, top, bottom);
+    }
 }

Engine/Core/Performance/PerformanceProfiler.cs

@@ -4,7 +4,7 @@
 
 namespace Staple;
 
-public sealed class PerformanceProfiler(PerformanceProfilerType type) : IDisposable
+public struct PerformanceProfiler(PerformanceProfilerType type) : IDisposable
 {
     private readonly PerformanceProfilerType type = type;
     private readonly DateTime startTime = DateTime.UtcNow;

Engine/Core/Rendering/Animation/SkinnedMeshAnimatorSystem.cs

@@ -10,7 +10,7 @@ public sealed class SkinnedMeshAnimatorSystem : IRenderSystem
 {
     private static void ResetRenderers(SkinnedMeshAnimator animator)
     {
-        foreach(var renderer in animator.renderers)
+        foreach(var renderer in animator.renderers.Contents)
         {
             renderer.ResetAnimationState();
         }

Engine/Core/Rendering/Lighting/LightSystem.cs

@@ -141,10 +141,15 @@ public void ApplyLightProperties(Vector3 position, Matrix4x4 transform, Material
 
         if (targets.Length > MaxLights)
         {
-            targets = targets
-                .OrderBy(x => Vector3.DistanceSquared(x.Item2.Position, position))
-                .Take(MaxLights)
-                .ToArray();
+            static (Entity, Transform, Light)[] Trim((Entity, Transform, Light)[] targets, Vector3 position)
+            {
+                return targets
+                    .OrderBy(x => Vector3.DistanceSquared(x.Item2.Position, position))
+                    .Take(MaxLights)
+                    .ToArray();
+            }
+
+            targets = Trim(targets, position);
         }
 
         Matrix4x4.Invert(transform, out var invTransform);

Engine/Core/Rendering/Material.cs

@@ -633,11 +633,11 @@ internal void ApplyProperties(ApplyMode applyMode)
             return;
         }
 
-        if(hasMainTexture)
+        if(hasMainTexture && applyMode != ApplyMode.IgnoreTextures)
         {
             var t = mainTexture;
 
-            if (t.Disposed)
+            if (t?.Disposed ?? true)
             {
                 MainTexture = WhiteTexture;
             }

Engine/Core/Rendering/Mesh/MeshRenderSystem.cs

@@ -64,12 +64,7 @@ public static void RenderMesh(Mesh mesh, Vector3 position, Quaternion rotation,
             mesh.UploadMeshData();
         }
 
-        var matrix = new Transform()
-        {
-            Position = position,
-            LocalRotation = rotation,
-            LocalScale = scale,
-        }.Matrix;
+        var matrix = Math.TransformationMatrix(position, scale, rotation);
 
         bgfx.StateFlags state = bgfx.StateFlags.WriteRgb |
             bgfx.StateFlags.WriteA |

Engine/Core/Rendering/RenderSystem/RenderSystem+Internal.cs

@@ -212,7 +212,7 @@ public void WorldChanged()
                 {
                     var collected = new Dictionary<IRenderSystem, List<(Entity, Transform, IComponent)>>();
 
-                    foreach (var entityInfo in entityQuery)
+                    foreach (var entityInfo in entityQuery.Contents)
                     {
                         var layer = entityInfo.Item1.Layer;