[Rendering] Cleanup and fixes for ImGUI;

Author: LittleCodingFox

BuiltinResources/Hidden/Shaders/UI/imgui.shader

@@ -41,10 +41,10 @@ VertexOutput VertexMain(Input input)
     float3 position = input.position;
 
     output.color = float4(
-        (input.color & uint(0xFF000000)) / 255.0,
-        (input.color & uint(0x00FF0000)) / 255.0,
-        (input.color & uint(0x0000FF00)) / 255.0,
-        (input.color & uint(0x000000FF)) / 255.0,
+        (input.color & 0xFF) / 255.0,
+        (input.color >> 8 & 0xFF) / 255.0,
+        (input.color >> 16 & 0xFF) / 255.0,
+        (input.color >> 24 & 0xFF) / 255.0
     );
 
 	output.coord = input.coord;

Engine/Staple.Core/Rendering/RenderSystem/RenderSystem+Internal.cs

@@ -110,55 +110,6 @@ internal class RenderCommand
     #endregion
 
     #region Helpers
-    /// <summary>
-    /// Calculates the blending function for blending flags
-    /// </summary>
-    /// <param name="source">The blending source flag</param>
-    /// <param name="destination">The blending destination flag</param>
-    /// <returns>The combined function</returns>
-    /*
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    internal static ulong BlendFunction(bgfx.StateFlags source, bgfx.StateFlags destination)
-    {
-        return BlendFunction(source, destination, source, destination);
-    }
-    */
-
-    /// <summary>
-    /// Calculates the blending function for blending flags
-    /// </summary>
-    /// <param name="sourceColor">The source color flag</param>
-    /// <param name="destinationColor">The destination color flag</param>
-    /// <param name="sourceAlpha">The source alpha blending flag</param>
-    /// <param name="destinationAlpha">The destination alpha blending flag</param>
-    /// <returns>The combined function</returns>
-    /*
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    internal static ulong BlendFunction(bgfx.StateFlags sourceColor, bgfx.StateFlags destinationColor, bgfx.StateFlags sourceAlpha, bgfx.StateFlags destinationAlpha)
-    {
-        return (ulong)sourceColor | (ulong)destinationColor << 4 | ((ulong)sourceAlpha | (ulong)destinationAlpha << 4) << 8;
-    }
-    */
-
-    /// <summary>
-    /// Checks if we have an available transient buffer
-    /// </summary>
-    /// <param name="numVertices">The amount of vertices to check</param>
-    /// <param name="layout">The vertex layout to use</param>
-    /// <param name="numIndices">The amount of indices to check</param>
-    /// <returns></returns>
-    /*
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    internal static bool CheckAvailableTransientBuffers(uint numVertices, bgfx.VertexLayout layout, uint numIndices)
-    {
-        unsafe
-        {
-            return numVertices == bgfx.get_avail_transient_vertex_buffer(numVertices, &layout)
-                && (0 == numIndices || numIndices == bgfx.get_avail_transient_index_buffer(numIndices, false));
-        }
-    }
-    */
-
     /// <summary>
     /// Gets the reset flags for specific video flags
     /// </summary>

Engine/Staple.Editor/ImGuiProxy.cs

@@ -113,7 +113,7 @@ public bool Initialize()
             var setPtr = Marshal.GetFunctionPointerForDelegate(SetClipboardText);
             var getPtr = Marshal.GetFunctionPointerForDelegate(GetClipboardText);
 
-            platformIO.RendererTextureMaxWidth = platformIO.RendererTextureMaxHeight = 0;//(int)bgfx.get_caps()->limits.maxTextureSize;
+            platformIO.RendererTextureMaxWidth = platformIO.RendererTextureMaxHeight = 8192;
             platformIO.PlatformSetClipboardTextFn = (void*)setPtr;
             platformIO.PlatformGetClipboardTextFn = (void*)getPtr;
             platformIO.PlatformClipboardUserData = (void *)nint.Zero;
@@ -519,7 +519,7 @@ private void Render(ImDrawDataPtr drawData)
 
             var command = RenderSystem.Backend.BeginCommand();
 
-            var pass = command.BeginRenderPass(null, CameraClearMode.SolidColor, Color.LightBlue, new(0, 0, 1, 1), Matrix4x4.Identity, ortho);
+            var pass = command.BeginRenderPass(null, CameraClearMode.SolidColor, StapleEditor.ClearColor, new(0, 0, 1, 1), Matrix4x4.Identity, ortho);
 
             var clipPos = drawData.DisplayPos;
             var clipScale = drawData.FramebufferScale;

Engine/Staple.Editor/StapleEditor+Render.cs

@@ -15,11 +15,6 @@ internal partial class StapleEditor
     /// </summary>
     public void RenderScene()
     {
-        /*
-        bgfx.touch(SceneView);
-        bgfx.touch(WireframeView);
-        */
-
         ImGuizmo.SetDrawlist();
         ImGuizmo.SetOrthographic(false);
         ImGuizmo.SetRect(0, 0, window.width, window.height);

Engine/Staple.Editor/StapleEditor.cs

@@ -280,7 +280,7 @@ public void WorldChanged()
 
     private const int TargetFramerate = 30;
 
-    private Color32 clearColor = new("#7393B3");
+    public static readonly Color32 ClearColor = new("#7393B3");
 
     private ViewportType viewportType = ViewportType.Scene;
 
@@ -467,6 +467,7 @@ public void Run(string[] args)
         editorAppSettings.runInBackground = true;
         editorAppSettings.appName = "Staple Editor";
         editorAppSettings.companyName = "Staple Engine";
+        editorAppSettings.renderers[AppPlatform.Windows] = [ RendererType.Vulkan ];
 
         LayerMask.SetLayers(CollectionsMarshal.AsSpan(editorAppSettings.layers), CollectionsMarshal.AsSpan(editorAppSettings.sortingLayers));
 
@@ -764,17 +765,6 @@ private void NormalEditorLoop()
 
                 style.WindowPadding = Vector2.Zero;
 
-                /*
-                bgfx.set_view_rect_ratio(ClearView, 0, 0, bgfx.BackbufferRatio.Equal);
-                bgfx.set_view_clear(ClearView, (ushort)(bgfx.ClearFlags.Color | bgfx.ClearFlags.Depth), clearColor.UIntValue, 1, 0);
-
-                bgfx.set_view_rect_ratio(SceneView, 0, 0, bgfx.BackbufferRatio.Equal);
-                bgfx.set_view_clear(SceneView, (ushort)(bgfx.ClearFlags.Color | bgfx.ClearFlags.Depth), clearColor.UIntValue, 1, 0);
-
-                bgfx.set_view_rect_ratio(WireframeView, 0, 0, bgfx.BackbufferRatio.Equal);
-                bgfx.set_view_clear(WireframeView, (ushort)bgfx.ClearFlags.Depth, 0, 1, 0);
-                */
-
                 Physics3D.Instance = new Physics3D(new JoltPhysics3D());
 
                 Physics3D.Instance.Startup();
@@ -1282,19 +1272,6 @@ private void NormalEditorLoop()
 
             PlayerSettings.Save(playerSettings);
 
-            /*
-            bgfx.reset((uint)window.width, (uint)window.height, (uint)flags, bgfx.TextureFormat.RGBA8);
-
-            bgfx.set_view_rect_ratio(ClearView, 0, 0, bgfx.BackbufferRatio.Equal);
-            bgfx.set_view_clear(ClearView, (ushort)(bgfx.ClearFlags.Color | bgfx.ClearFlags.Depth), clearColor.UIntValue, 1, 0);
-
-            bgfx.set_view_rect_ratio(SceneView, 0, 0, bgfx.BackbufferRatio.Equal);
-            bgfx.set_view_clear(SceneView, (ushort)(bgfx.ClearFlags.Color | bgfx.ClearFlags.Depth), clearColor.UIntValue, 1, 0);
-
-            bgfx.set_view_rect_ratio(WireframeView, 0, 0, bgfx.BackbufferRatio.Equal);
-            bgfx.set_view_clear(WireframeView, (ushort)bgfx.ClearFlags.Depth, 0, 1, 0);
-            */
-
             if (hadFocus != hasFocus && hasFocus)
             {
                 if (RefreshingAssets == false && ProjectManager.Instance.NeedsGameRecompile())

Engine/Staple.Player.Android/StapleActivity.cs

@@ -316,7 +316,7 @@ private void InitIfNeeded()
     {
         if (AppPlayer.instance?.renderWindow == null)
         {
-            new AppPlayer(Array.Empty<string>(), false);
+            new AppPlayer(Array.Empty<string>(), false, false);
 
             Log.Instance.onLog += (type, message) =>
             {