[Entities] More improvements to ComponentVersionTracker;

Author: LittleCodingFox

Engine/Staple.Core/Entities/ComponentVersionTracker.cs

@@ -1,25 +1,34 @@
 using System;
+using System.Runtime.CompilerServices;
 
 namespace Staple;
 
 public class ComponentVersionTracker<T> where T: IComponent, IComponentVersion
 {
     private ulong[] versions = new ulong[1024];
 
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public bool ShouldUpdateComponent(Entity entity, in T component)
     {
         if (component == null)
         {
             throw new ArgumentNullException(nameof(component), "Component can't be null");
         }
 
-        if(versions.Length < entity.Identifier.ID)
+        var index = entity.Identifier.ID - 1;
+        var componentVersion = component.Version;
+
+        if (index >= versions.Length)
         {
-            Array.Resize(ref versions, versions.Length * 2);
-        }
+            var newSize = versions.Length * 2;
 
-        var componentVersion = component.Version;
-        var index = entity.Identifier.ID - 1;
+            while(newSize < entity.Identifier.ID)
+            {
+                newSize *= 2;
+            }
+
+            Array.Resize(ref versions, newSize);
+        }
 
         var version = versions[index];
 

Engine/Staple.Core/Entities/Transform.cs

@@ -20,22 +20,8 @@ public class Transform : IComponent, IComponentVersion
     /// </summary>
     public ulong Version
     {
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         get => version;
-
-        private set
-        {
-            var previous = version;
-
-            version = value;
-
-            if(previous != version)
-            {
-                for(var i = 0; i < Children.Length; i++)
-                {
-                    Children[i].Version++;
-                }
-            }
-        }
     }
 
     /// <summary>
@@ -126,7 +112,7 @@ public Vector3 Position
 
             if(target != position)
             {
-                Version++;
+                BumpVersion();
             }
 
             position = target;
@@ -144,7 +130,7 @@ public Vector3 LocalPosition
         {
             if(value != position)
             {
-                Version++;
+                BumpVersion();
             }
 
             position = value;
@@ -171,7 +157,7 @@ public Vector3 Scale
 
             if (target != scale)
             {
-                Version++;
+                BumpVersion();
             }
 
             scale = target;
@@ -189,7 +175,7 @@ public Vector3 LocalScale
         {
             if (value != scale)
             {
-                Version++;
+                BumpVersion();
             }
 
             scale = value;
@@ -216,7 +202,7 @@ public Quaternion Rotation
 
             if (target != rotation)
             {
-                Version++;
+                BumpVersion();
             }
 
             rotation = target;
@@ -234,7 +220,7 @@ public Quaternion LocalRotation
         {
             if (value != rotation)
             {
-                Version++;
+                BumpVersion();
             }
 
             rotation = value;
@@ -353,7 +339,7 @@ public void SetParent(Transform parent)
 
         parent?.AttachChild(this);
 
-        Version++;
+        BumpVersion();
 
         Scene.RequestWorldUpdate();
     }
@@ -465,6 +451,20 @@ private bool MoveChild(Transform child, int index)
         return true;
     }
 
+    /// <summary>
+    /// Increases the transform's version
+    /// </summary>
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    private void BumpVersion()
+    {
+        version++;
+
+        for (var i = 0; i < Children.Length; i++)
+        {
+            Children[i].BumpVersion();
+        }
+    }
+
     /// <summary>
     /// Rotates this transform
     /// </summary>