Merge pull request #43 from StarMapLoader/dev

KlaasWhite · web-flow · commit 822bb4948851 · 2025-12-06T08:22:46.000+01:00
Make the AssemblyLoadContexts not collectable (#42)
diff --git a/StarMap.Core/ModRepository/ModAssemblyLoadContext.cs b/StarMap.Core/ModRepository/ModAssemblyLoadContext.cs
@@ -10,7 +10,7 @@ internal class ModAssemblyLoadContext : AssemblyLoadContext
         private readonly AssemblyDependencyResolver _modDependencyResolver;
 
         public ModAssemblyLoadContext(string modId, string modDirectory, AssemblyLoadContext coreAssemblyContext)
-            : base(isCollectible: true)
+            : base()
         {
             _coreAssemblyLoadContext = coreAssemblyContext;
 
diff --git a/StarMap/GameAssemblyLoadContext.cs b/StarMap/GameAssemblyLoadContext.cs
@@ -14,7 +14,7 @@ internal class GameAssemblyLoadContext : AssemblyLoadContext
         private readonly AssemblyDependencyResolver _starMapDepdencyResolver;
 
         public GameAssemblyLoadContext(string gamePath)
-            : base(isCollectible: true)
+            : base()
         {
             _gameDependencyResolver = new AssemblyDependencyResolver(gamePath);
 

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ internal class ModAssemblyLoadContext : AssemblyLoadContext`
`10`	`10`	`private readonly AssemblyDependencyResolver _modDependencyResolver;`
`11`	`11`
`12`	`12`	`public ModAssemblyLoadContext(string modId, string modDirectory, AssemblyLoadContext coreAssemblyContext)`
`13`		`- : base(isCollectible: true)`
	`13`	`+ : base()`
`14`	`14`	`{`
`15`	`15`	`_coreAssemblyLoadContext = coreAssemblyContext;`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ internal class GameAssemblyLoadContext : AssemblyLoadContext`
`14`	`14`	`private readonly AssemblyDependencyResolver _starMapDepdencyResolver;`
`15`	`15`
`16`	`16`	`public GameAssemblyLoadContext(string gamePath)`
`17`		`- : base(isCollectible: true)`
	`17`	`+ : base()`
`18`	`18`	`{`
`19`	`19`	`_gameDependencyResolver = new AssemblyDependencyResolver(gamePath);`
`20`	`20`