fix(collector): handle large LBA values in SMART data parsing

Change LBA fields from int to uint64 to handle large unsigned 64-bit
values that exceed int64 max. This fixes JSON unmarshaling errors when
parsing SMART data from drives with large LBA addresses.

Fields changed:
- AtaSmartErrorLog.Summary.Table[].CompletionRegisters.Lba
- AtaSmartErrorLog.Summary.Table[].PreviousCommands[].Registers.Lba
- AtaSmartSelectiveSelfTestLog.Table[].LbaMin
- AtaSmartSelectiveSelfTestLog.Table[].LbaMax

Fixes #24
Upstream: AnalogJ#800

Author: Starosdev

webapp/backend/pkg/models/collector/smart.go

@@ -146,7 +146,7 @@ type SmartInfo struct {
 					Error  int `json:"error"`
 					Status int `json:"status"`
 					Count  int `json:"count"`
-					Lba    int `json:"lba"`
+					Lba    uint64 `json:"lba"`
 					Device int `json:"device"`
 				} `json:"completion_registers"`
 				ErrorDescription string `json:"error_description"`
@@ -155,7 +155,7 @@ type SmartInfo struct {
 						Command       int `json:"command"`
 						Features      int `json:"features"`
 						Count         int `json:"count"`
-						Lba           int `json:"lba"`
+						Lba           uint64 `json:"lba"`
 						Device        int `json:"device"`
 						DeviceControl int `json:"device_control"`
 					} `json:"registers"`
@@ -188,8 +188,8 @@ type SmartInfo struct {
 	AtaSmartSelectiveSelfTestLog struct {
 		Revision int `json:"revision"`
 		Table    []struct {
-			LbaMin int `json:"lba_min"`
-			LbaMax int `json:"lba_max"`
+			LbaMin uint64 `json:"lba_min"`
+			LbaMax uint64 `json:"lba_max"`
 			Status struct {
 				Value  int    `json:"value"`
 				String string `json:"string"`

webapp/backend/pkg/models/collector/smart_test.go

@@ -1,9 +1,11 @@
 package collector
 
 import (
+	"encoding/json"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestSmartInfo_Capacity(t *testing.T) {
@@ -31,3 +33,92 @@ func TestSmartInfo_Capacity(t *testing.T) {
 		assert.Zero(t, smartInfo.Capacity())
 	})
 }
+
+func TestSmartInfo_LargeLBAValues(t *testing.T) {
+	// Test for GitHub issue #24 / upstream issue #800
+	// LBA values can be large unsigned 64-bit integers that overflow signed int
+	t.Run("should parse large LBA values in selective self-test log", func(t *testing.T) {
+		// This JSON contains LBA values that exceed int64 max (9223372036854775807)
+		// Value 18446743534724713985 is a valid uint64 but overflows int64
+		jsonData := `{
+			"ata_smart_selective_self_test_log": {
+				"revision": 1,
+				"table": [
+					{
+						"lba_min": 18446743534724713985,
+						"lba_max": 7205816247684983039,
+						"status": {
+							"value": 0,
+							"string": "Not_testing"
+						}
+					}
+				],
+				"flags": {
+					"value": 0,
+					"remainder_scan_enabled": false
+				},
+				"power_up_scan_resume_minutes": 0
+			}
+		}`
+
+		var smartInfo SmartInfo
+		err := json.Unmarshal([]byte(jsonData), &smartInfo)
+		require.NoError(t, err, "should unmarshal large LBA values without error")
+
+		// Verify the values were parsed correctly
+		require.Len(t, smartInfo.AtaSmartSelectiveSelfTestLog.Table, 1)
+		assert.Equal(t, uint64(18446743534724713985), smartInfo.AtaSmartSelectiveSelfTestLog.Table[0].LbaMin)
+		assert.Equal(t, uint64(7205816247684983039), smartInfo.AtaSmartSelectiveSelfTestLog.Table[0].LbaMax)
+	})
+
+	t.Run("should parse large LBA values in error log", func(t *testing.T) {
+		// LBA values in error logs can also be large
+		jsonData := `{
+			"ata_smart_error_log": {
+				"summary": {
+					"revision": 1,
+					"count": 1,
+					"logged_count": 1,
+					"table": [
+						{
+							"error_number": 1,
+							"lifetime_hours": 1000,
+							"completion_registers": {
+								"error": 0,
+								"status": 0,
+								"count": 0,
+								"lba": 18446744073709551615,
+								"device": 0
+							},
+							"error_description": "test",
+							"previous_commands": [
+								{
+									"registers": {
+										"command": 0,
+										"features": 0,
+										"count": 0,
+										"lba": 18446744073709551615,
+										"device": 0,
+										"device_control": 0
+									},
+									"powerup_milliseconds": 0,
+									"command_name": "test"
+								}
+							]
+						}
+					]
+				}
+			}
+		}`
+
+		var smartInfo SmartInfo
+		err := json.Unmarshal([]byte(jsonData), &smartInfo)
+		require.NoError(t, err, "should unmarshal large LBA values in error log without error")
+
+		// Verify the values were parsed correctly
+		require.Len(t, smartInfo.AtaSmartErrorLog.Summary.Table, 1)
+		assert.Equal(t, uint64(18446744073709551615), smartInfo.AtaSmartErrorLog.Summary.Table[0].CompletionRegisters.Lba)
+		require.Len(t, smartInfo.AtaSmartErrorLog.Summary.Table[0].PreviousCommands, 1)
+		assert.Equal(t, uint64(18446744073709551615), smartInfo.AtaSmartErrorLog.Summary.Table[0].PreviousCommands[0].Registers.Lba)
+	})
+}