update QuickLRU option (2) (#21)

Co-authored-by: ke hu <[email protected]>
Co-authored-by: Dustin Deus <[email protected]>

Author: 3 people

package-lock.json

@@ -60,7 +60,10 @@
     "graphql": "^15.3.0 || ^16.0.0"
   },
   "devDependencies": {
+    "@sinonjs/fake-timers": "^8.1.0",
     "@tsconfig/node12": "^1.0.9",
+    "@types/node": "^14.17.3",
+    "@types/sinonjs__fake-timers": "^8.1.0",
     "@types/node": "^17.0.5",
     "abort-controller": "^3.0.0",
     "apollo-datasource-rest": "^3.4.0",

package.json

@@ -93,6 +93,7 @@ export abstract class HTTPDataSource<TContext = any> extends DataSource {
     super()
     this.memoizedResults = new QuickLRU({
       maxSize: this.options?.lru?.maxSize ? this.options.lru.maxSize : 100,
+      maxAge: this.options?.lru?.maxAge,
     })
     this.pool = options?.pool ?? new Pool(this.baseURL, options?.clientOptions)
     this.globalRequestOptions = options?.requestOptions
@@ -325,7 +326,6 @@ export abstract class HTTPDataSource<TContext = any> extends DataSource {
           })
           .catch((err) => this.logger?.error(err))
       }
-
       return response
     } catch (error: any) {
       this.onError?.(error, request)

src/http-data-source.ts

@@ -6,6 +6,7 @@ import querystring from 'querystring'
 import { HTTPDataSource, Request, Response, RequestError } from '../src'
 import { AddressInfo } from 'net'
 import { KeyValueCacheSetOptions } from 'apollo-server-caching'
+import FakeTimers from '@sinonjs/fake-timers'
 
 const agent = new Agent({
   keepAliveTimeout: 10, // milliseconds
@@ -1336,6 +1337,57 @@ test('Should only cache GET successful responses with the correct status code',
   t.is(cacheMap.size, 0)
 })
 
+test.serial('Global maxAge should be used when no maxAge was set or similar.', async (t) => {
+  const path = '/'
+
+  const clock = FakeTimers.install()
+  t.teardown(clock.uninstall.bind(clock))
+
+  const server = http.createServer((req, res) => {
+    t.is(req.method, 'GET')
+    res.writeHead(200)
+    res.end()
+    res.socket?.unref()
+  })
+
+  t.teardown(server.close.bind(server))
+
+  server.listen()
+
+  const baseURL = `http://localhost:${(server.address() as AddressInfo)?.port}`
+
+  let testResponse: Response<any> | {
+    memoized: boolean
+  } = {
+    memoized: false,
+  }
+  const maxAge = 10000
+  const dataSource = new (class extends HTTPDataSource {
+    constructor() {
+      super(baseURL, {
+        lru: {
+          maxAge: maxAge
+        }
+      })
+    }
+    getFoo() {
+      return this.get(path)
+    }
+    onResponse(_: Request, response: Response<any>) {
+      testResponse = response
+      return response
+    }
+  })()
+
+  await dataSource.getFoo()
+  t.is(testResponse.memoized, false)
+  await dataSource.getFoo()
+  t.is(testResponse.memoized, true)
+  clock.tick(maxAge)
+  await dataSource.getFoo()
+  t.is(testResponse.memoized, false)
+})
+
 test('Response is not cached due to origin error', async (t) => {
   const path = '/'