set maxTtl only on first request when ttl is enabled

Author: dustin deus

src/http-data-source.ts

@@ -270,6 +270,7 @@ export abstract class HTTPDataSource<TContext = any> extends DataSource {
 
       // let's see if we can fill the shared cache
       if (options.requestCache && this.isResponseCacheable<TResult>(options, response)) {
+        response.maxTtl = Math.max(options.requestCache.maxTtl, options.requestCache.maxTtlIfError)
         this.storageAdapter
           .set(cacheKey, response, options.requestCache?.maxTtl)
           .catch((err) => this.logger?.error(err))
@@ -288,7 +289,6 @@ export abstract class HTTPDataSource<TContext = any> extends DataSource {
         )
         if (hasFallback) {
           hasFallback.isFromCache = true
-          hasFallback.maxTtl = options.requestCache.maxTtlIfError
           return hasFallback
         }
       }
@@ -321,7 +321,6 @@ export abstract class HTTPDataSource<TContext = any> extends DataSource {
         if (cachedResponse) {
           cachedResponse.memoized = false
           cachedResponse.isFromCache = true
-          cachedResponse.maxTtl = request.requestCache.maxTtl
           return cachedResponse
         }
       }

test/http-data-source.test.ts

@@ -641,13 +641,13 @@ test('Response is cached', async (t) => {
   let response = await dataSource.getFoo()
   t.false(response.isFromCache)
   t.false(response.memoized)
-  t.falsy(response.maxTtl)
+  t.is(response.maxTtl, 200)
   t.deepEqual(response.body, { name: 'foo' })
 
   response = await dataSource.getFoo()
   t.false(response.isFromCache)
   t.true(response.memoized)
-  t.falsy(response.maxTtl)
+  t.is(response.maxTtl, 200)
   t.deepEqual(response.body, { name: 'foo' })
 
   dataSource = new (class extends HTTPDataSource {
@@ -669,7 +669,7 @@ test('Response is cached', async (t) => {
   response = await dataSource.getFoo()
   t.true(response.isFromCache)
   t.false(response.memoized)
-  t.is(response.maxTtl, 100)
+  t.is(response.maxTtl, 200)
   t.deepEqual(response.body, { name: 'foo' })
 
   const cached = JSON.parse(map.get('keyv:' + baseURL + path)!)
@@ -755,7 +755,7 @@ test('Fallback from cache on origin error', async (t) => {
   let response = await dataSource.getFoo()
   t.false(response.isFromCache)
   t.false(response.memoized)
-  t.falsy(response.maxTtl)
+  t.is(response.maxTtl, 200)
 
   t.deepEqual(response.body, { name: 'foo' })