[bug]: RPCAUTH Issues

[horologger]

Prerequisites

• I have searched for existing issues that already report this problem.

Device

Laptop/Desktop

Device OS

Linux

Device OS Version

0.3.6

Browser

Firefox

Browser Version

na

Current Behavior

1. The Generate RPC User Credentials action destroy's existing rpcauth entries in bitcoind.conf instead of appending them.
2. The user in the rpcauth is double-quoted where is should be unquoted rpcauth="bubba": vs. rpcauth=bubba:
3. The hash algorithm used is incorrect for bitcoind. Verify with this public tool (only for testing, don't leak access to your production servers) https://jlopp.github.io/bitcoin-core-rpc-auth-generator/
4. Unclear if the bitcoind service should restart or if it watches the conf file and acts appropriately.

Expected Behavior

Things should work.

Steps to Reproduce

See above

Anything else?

No response

[horologger]

Might also need a "Remove RPC if exists" action to be called upon dependent service Uninstall.

[Dominion5254]

1. Fixed appending rpcauth entries here
2. Fixed double quote issue and added necessary password regex limitations here - username already had the same regex limitations.
3. The python script used in bitcoind-startos is the same as the one Jameson is using, but I suspect you might not be accounting for salt, which can result in a different rpcauth entry even for and identical username/password. To illustrate, you can leave the same username/password in Jameson's tool but if you click "generate" multiple times it will result in a different salted hash each time.
4. Bitcoin calls const on the bitcoin.conf file in main.ts - const is cause the function in which const is called to re-run if the underlying file changes. Calling const in main will cause bitcoind to restart.

"Remove RPC if exists" might be a good idea to ensure cleanup of unused rpcauth entries. For now you should be able to request the existing deleteRpcAuth action passing the username of the dependent in setupUninstall. The only downside of this rather than a separate action is the fields aren't protected, so a user could select a different username to delete.