feat: output 404 error if file not found

KaneFreeman · KaneFreeman · commit 2a842aeb3154 · 2023-02-16T08:42:15.000-05:00
diff --git a/src/middlewares/localFs/index.ts b/src/middlewares/localFs/index.ts
@@ -137,8 +137,16 @@ export function localFsMiddleware({ repoPath, logger }: FsOptions) {
           break;
         }
       }
-    } catch (e: any) {
-      logger.error(`Error handling ${JSON.stringify(req.body)}: ${e.message}`);
+    } catch (e: unknown) {
+      if (e instanceof Error) {
+        logger.error(`Error handling ${JSON.stringify(req.body)}: ${e.message}`);
+
+        if (e.message.startsWith('ENOENT: no such file or directory')) {
+          res.status(404).json({ error: 'Not found' });
+          return;
+        }
+      }
+
       res.status(500).json({ error: 'Unknown error' });
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -137,8 +137,16 @@ export function localFsMiddleware({ repoPath, logger }: FsOptions) {`
`137`	`137`	`break;`
`138`	`138`	`}`
`139`	`139`	`}`
`140`		`- } catch (e: any) {`
`141`		- logger.error(`Error handling ${JSON.stringify(req.body)}: ${e.message}`);
	`140`	`+ } catch (e: unknown) {`
	`141`	`+ if (e instanceof Error) {`
	`142`	+ logger.error(`Error handling ${JSON.stringify(req.body)}: ${e.message}`);
	`143`	`+`
	`144`	`+ if (e.message.startsWith('ENOENT: no such file or directory')) {`
	`145`	`+ res.status(404).json({ error: 'Not found' });`
	`146`	`+ return;`
	`147`	`+ }`
	`148`	`+ }`
	`149`	`+`
`142`	`150`	`res.status(500).json({ error: 'Unknown error' });`
`143`	`151`	`}`
`144`	`152`	`};`