Fix comparison in Idler (#40)

StaticSweep · web-flow · commit b73b3e594a3b · 2025-09-16T03:38:38.000+01:00
Defensively compare strings using .equals() to ensure that string content is compared.
diff --git a/src/main/java/com/chromascape/utils/actions/Idler.java b/src/main/java/com/chromascape/utils/actions/Idler.java
@@ -44,7 +44,7 @@ public static void waitUntilIdle(BaseScript base, int timeoutSeconds) {
         Rectangle latestMessage = base.controller().zones().getChatTabs().get("Latest Message");
         ColourObj red = ColourInstances.getByName("ChatRed");
         String ocr = Ocr.extractText(latestMessage, "Plain 12", red, true);
-        if ((ocr.contains("moving") || ocr.contains("idle")) && ocr != lastMessage) {
+        if ((ocr.contains("moving") || ocr.contains("idle")) && !ocr.equals(lastMessage)) {
           lastMessage = ocr;
           return;
         }

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public static void waitUntilIdle(BaseScript base, int timeoutSeconds) {`
`44`	`44`	`Rectangle latestMessage = base.controller().zones().getChatTabs().get("Latest Message");`
`45`	`45`	`ColourObj red = ColourInstances.getByName("ChatRed");`
`46`	`46`	`String ocr = Ocr.extractText(latestMessage, "Plain 12", red, true);`
`47`		`- if ((ocr.contains("moving") \|\| ocr.contains("idle")) && ocr != lastMessage) {`
	`47`	`+ if ((ocr.contains("moving") \|\| ocr.contains("idle")) && !ocr.equals(lastMessage)) {`
`48`	`48`	`lastMessage = ocr;`
`49`	`49`	`return;`
`50`	`50`	`}`