Skip to content

Commit b1a2773

Browse files
committed
Fixing TSC and Quality issues for next release
Signed-off-by: NishkarshRaj <[email protected]>
1 parent 5c7131f commit b1a2773

File tree

19 files changed

+12354
-16944
lines changed

19 files changed

+12354
-16944
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,4 +106,4 @@ dist
106106
dist
107107
dist-types
108108

109-
.yarn
109+
.yarn

.pre-commit-config.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
repos:
2+
- repo: https://github.com/pre-commit/pre-commit-hooks
3+
rev: v4.3.0
4+
hooks:
5+
- id: check-merge-conflict
6+
- id: trailing-whitespace
7+
- id: end-of-file-fixer
8+
- id: check-docstring-first

README.md

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,27 @@
1-
# GitHub Homepage Cards for Backstage Enterprise
1+
## GitHub Homepage Cards for Backstage Enterprise
22

3-
This plugin is contributed by Statusneo. <br/>
43
<img src="https://raw.githubusercontent.com/StatusNeo/backstage-plugin-github/main/src/assets/statusneo.png"/> <br/>
5-
To read more about this plugin please read this [blog](https://statusneo.com/23468-2).
64

7-
# Setup
5+
To know more about the plugin, read this [blog](https://statusneo.com/23468-2).
6+
7+
### Setup
8+
89
Before you can start using the GitHub cards, you must set up a GitHub provider.
9-
You can follow this page which will guide you through the process of setting up the GitHub provider for your backstage instance.
10-
[Setup GitHub Provider](https://backstage.io/docs/auth/github/provider/)
10+
11+
You can follow this [documentation](https://backstage.io/docs/auth/github/provider/) which will guide you through the process of setting up the GitHub provider for your Backstage instance.
1112

1213
Now in the below steps, I will assume you are already done with the provider.
13-
## Integration Steps
14-
1. First Install the Github cards plugin by running this command from the root of the package.
14+
15+
### Integration Steps
16+
17+
1. First Install the GitHub cards plugin by running this command from the root of the package.
18+
1519
```shell
1620
yarn add –cwd packages/app @statusneo/backstage-plugin-github
1721
```
1822

19-
2. Import GithubPullRequestsCard, and GithubActionsCard from the installed package
23+
2. Import `GithubPullRequestsCard`, and `GithubActionsCard` from the installed package.
24+
2025
3. You can then use these components at the backstage frontend wherever you need.
2126

2227
```javascript
@@ -32,4 +37,4 @@ import { GithubPullRequestsCard, GithubActionsCard } from '@statusneo/backstage-
3237
// ...
3338
```
3439

35-
Now you are ready to use this backstage GitHub plugin to make your software management and development cycle a little more hassle-free.
40+
Now you are ready to use this Backstage GitHub plugin to make your software management and development cycle a little more hassle-free.

src/api/GithubClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export class GithubClient implements GithubApi {
8686
return this.get<UserRepositoryApiResponse>(
8787
`/user/repos`,
8888
params,
89-
);
89+
);
9090
}
9191

9292
}

src/assets/github.svg

Lines changed: 1 addition & 1 deletion
Loading

src/components/CustomTable/CustomTable.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ export function CustomTable<T extends object = {}>(props: CustomTableProps<T>) {
149149
/>
150150
);
151151
},
152+
// @ts-ignore
152153
Header: headerProps => <StyledMTableHeader {...headerProps} />,
153154
}}
154155
detailPanel={props.detailPanel}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export * from "./CustomTable"
1+
export * from "./CustomTable"

src/components/GithubActionsCard/ActionDetailPanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export function ActionDetailPanel({ rowData }: { rowData: WorkflowRun }) {
8888
<Tab label={job.name} id={job.id} value={job.id} />
8989
))}
9090
</Tabs>
91-
<Paper
91+
<Paper
9292
classes={{
9393
root: classes.timelineContainer
9494
}}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export * from './GithubActionsCard'
1+
export * from './GithubActionsCard'

src/components/SignInContent.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ type Props = {
2424

2525
export const SignInContent = ({ handleAuthClick }: Props) => {
2626
return (
27+
// @ts-ignore
2728
<Box position="relative" height="100%" width="100%" minHeight={100}>
29+
// @ts-ignore
2830
<Box
2931
height="100%"
3032
width="100%"
@@ -41,7 +43,7 @@ export const SignInContent = ({ handleAuthClick }: Props) => {
4143
onClick={handleAuthClick}
4244
size="large"
4345
>
44-
Sign in
46+
Sign In
4547
</Button>
4648
</Box>
4749
</Box>

0 commit comments

Comments
 (0)