Fix shadowed variables

Author: xPaw

eslint.config.mjs

@@ -89,7 +89,6 @@ export default[
 			"no-nested-ternary": "off",
 			"no-param-reassign": "off",
 			"no-plusplus": "off",
-			"no-shadow": "off",
 			"no-tabs": "off",
 			"no-ternary": "off",
 			"no-trailing-spaces": [ "error" ],

options/options.js

@@ -141,14 +141,14 @@
 
 		try
 		{
-			ExtensionApi.permissions.request( permissions ).catch( e =>
+			ExtensionApi.permissions.request( permissions ).catch( ex =>
 			{
-				alert( `Failed to request permissions: ${e.message}` );
+				alert( `Failed to request permissions: ${ex.message}` );
 			} );
 		}
-		catch( e )
+		catch( ex )
 		{
-			alert( `Failed to request permissions: ${e}` );
+			alert( `Failed to request permissions: ${ex}` );
 		}
 	} );
 

scripts/community/achievements.js

@@ -785,10 +785,10 @@ function InitAchievements( items, isPersonal )
 
 			if( isCompareView )
 			{
-				const image = document.createElement( 'img' );
-				image.src = `${applicationConfig.MEDIA_CDN_COMMUNITY_URL}images/apps/${appid}/${player.unlockCompare && achievement.icon_gray ? achievement.icon : achievement.icon_gray}`;
-				image.className = 'steamdb_achievement_image steamdb_achievement_image_compare';
-				element.append( image );
+				const imageCompare = document.createElement( 'img' );
+				imageCompare.src = `${applicationConfig.MEDIA_CDN_COMMUNITY_URL}images/apps/${appid}/${player.unlockCompare && achievement.icon_gray ? achievement.icon : achievement.icon_gray}`;
+				imageCompare.className = 'steamdb_achievement_image steamdb_achievement_image_compare';
+				element.append( imageCompare );
 			}
 
 			return element;
@@ -1180,10 +1180,10 @@ function InitAchievements( items, isPersonal )
 			{
 				dlcCapsulesPromise.then( ( images ) =>
 				{
-					for( const [ appid, url ] of images )
+					for( const [ dlcAppId, url ] of images )
 					{
 						/** @type {NodeListOf<HTMLImageElement>} */
-						const imageTags = document.querySelectorAll( `.steamdb_achievements_game_logo[data-appid="${appid}"]` );
+						const imageTags = document.querySelectorAll( `.steamdb_achievements_game_logo[data-appid="${dlcAppId}"]` );
 
 						for( const image of imageTags )
 						{
@@ -1590,10 +1590,10 @@ function HookSortButton( sortButton, achievementUpdates, oldAchievementRows, Cre
 
 				StartViewTransition( RedrawSortedAchievements );
 			} )
-			.catch( e =>
+			.catch( ex =>
 			{
-				WriteLog( e );
-				alert( `Failed to sort achievements: ${e.message}` );
+				WriteLog( ex );
+				alert( `Failed to sort achievements: ${ex.message}` );
 			} );
 	}, { once: true } );
 }

scripts/store/app.js

@@ -2,13 +2,12 @@
 
 'use strict';
 
-const container = document.getElementById( 'error_box' );
 const language = GetLanguage();
 const numberFormatter = new Intl.NumberFormat( language );
 
-if( container )
+if( document.getElementById( 'error_box' ) )
 {
-	AddLinksInErrorBox( container );
+	AddLinksInErrorBox( document.getElementById( 'error_box' ) );
 }
 else
 {
@@ -280,9 +279,9 @@ else
 			// Bundles
 			container = document.querySelectorAll( 'input[name="bundleid"]' );
 
-			for( const element of container )
+			for( const bundleElement of container )
 			{
-				InsertPurchaseBlockId( element.closest( '.game_area_purchase_game' ).querySelector( '.game_purchase_action' ), 'bundle', Number.parseInt( element.value, 10 ) );
+				InsertPurchaseBlockId( bundleElement.closest( '.game_area_purchase_game' ).querySelector( '.game_purchase_action' ), 'bundle', Number.parseInt( bundleElement.value, 10 ) );
 			}
 
 			// We have to inject our JS directly into the page to hook Steam's functionatily
@@ -1174,9 +1173,9 @@ function AddLinksToDevelopers()
 		rows.push( row );
 	}
 
-	for( const row of rows )
+	for( const innerRow of rows )
 	{
-		const container = row.querySelector( '.summary.column' );
+		const container = innerRow.querySelector( '.summary.column' );
 
 		if( !container )
 		{