Unlocked achievements with "invalid" unlock time will be shown under locked

[knoxed]

Describe the bug

Achievements that have a glitched unlock time like October 10, 2007 (most likely the date when they added achievements to Steam) will be shown under locked.

With extension enabled

With extension disabled (the time is not shown on the right but in the client it is Oct 10, 2007)

Achievements that have this date were most likely unlocked in offline mode.

Browser name and version

Firefox 133.0.3 (64-bit)

[nolddor]

Hi @knoxed can you please share the URL to your game achivements where the problem is reproducible and make your achivements public for a while? I would like to take a quick look.

Cheers

[nolddor]

Hi @knoxed thanks for sharing the details privately. Here is what I found:

<div data-panel="{&quot;autoFocus&quot;:true,&quot;focusable&quot;:true,&quot;clickOnActivate&quot;:true}" role="button"
	class="achieveRow">
	<div class="achieveImgHolder">
		<img
			src="https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/10180/5fb34d044db38c9e299c4b8f662f2babb29e9422.jpg">
	</div>
	<div class="achieveTxtHolder">
		<div class="achieveTxt">
			<h3 class="ellipsis">Three-some</h3>
			<h5>Kill at least 3 enemies with a single shot from a grenade launcher in Single Player or Special Ops.</h5>
		</div>
	</div>
</div>

---

As you said, in the website there is no .achieveUnlockTime element within the .achieveTxtHolder block as you see in the sample HTML, which is the one displaying the time at which you unlock that particular achievement. Saying that, under this particular escenario, achivement is still locked in the website as it has not unlock time, even a glitched one as in the Steam client.

@xPaw I do not see any elegant solution for this other than either compute the unlock by image-src or by row position vs the total earned achivements. This is an edge case, and problem is at valve side, I would say complement is working as expected here and I do no see why we need to modify most of the logic at this part to cover this Valve mess.

Here is how current comparison works:
https://github.com/SteamDatabase/BrowserExtension/blob/master/scripts/community/achievements.js#L435-L437

Let me know what do you think about this one.

[Hamuko]

Unlocked and locked achievements are separated by three <br> tags. Couldn't that be used to see what are unlocked and what are locked?

It also seems like the achieveTxt > h5 has the ellipsis on locked achievements only. Not sure how reliable that is but seems to be true in my testing.