-
Notifications
You must be signed in to change notification settings - Fork 96
Added rules for Dissonance Voice Chat #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fixed regex matching the file name at any path
Just a note about this, I don't know how many games use Dissonance (that's why I'm writing this filter!), but I do know we sell a reasonable number of copies of the asset and it's used in some fairly well known games. So hopefully this is big enough to be worthwile :) |
|
Unfortunately, we do not want to add plugins that are for a single engine so this won't be merged
|
Lifeismana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martindevans In the end, since it's a popular sdk, we'll still merge it
i've gone ahead and removed .bundle & .so since as far as i can tell, they aren't bringing any apps not detected by .dll
& i've switched the website to https://placeholder-software.co.uk/dissonance/ since that's the one mentioned on the tools' github
(i'll commit the changes myself)
SteamDB app page links to a few games using this
Brief explanation of the change
Added rules to detect Dissonance Voice Chat. Dissonance ships an audio plugin named
AudioPluginDissonanceon all platforms, there's no reason anyone else would ever call a file this so it should be a pretty good filter.