-
Notifications
You must be signed in to change notification settings - Fork 96
Yarn Spinner detection if IL2CPP is also used #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should detect games like The Berlin Apartment which are currently false negatives.
|
Can this be reduced to one file, surely there's some part that is always required? Also you forgot $ in the regex |
I’ve added the $. As far as the pattern goes, it depends on how permissive you would like to be:
I’m happy to change it to whichever you prefer :) |
|
I've pushed a version which instead uses |
|
|
Yes, that does seem to be the case. Until recently, we believed IL2CPP made it impossible to detect Yarn Spinner. We then noticed these three files (Buffers, Memory, Numerics.Vectors) in a few projects, but we are still not certain if all three are always emitted. I'll just pick one for now and if we notice anything weird in the future I'll PR again. Thanks so much! :) |
SteamDB app page links to a few games using this
Brief explanation of the change
If a game is made in Unity and IL2CPP is used, the usual YarnSpinner.dll will not be present. Instead, depending on what parts of Yarn Spinner have been used, new .dat files will be emitted with these patterns.
As Yarn Spinner is primarily an unpaid project, and we use no analytics, getting an accurate read on how many people use the tool is one of our primary ways of keeping track of the project. We are super, super grateful that a tool like SteamDB exists.