Skip to content

Commit 58d5ae6

Browse files
committed
Address PR review feedback
- Fix logging.level namespace to match actual package after build-time rewriting (io.steeltoe.docker instead of io.steeltoe.docker.ssl) - Correct AGENTS.md patch documentation for unified diff hunk headers
1 parent 5ce7172 commit 58d5ae6

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

AGENTS.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,9 @@ Before submitting patch changes:
2828
### Patch Format Rules
2929

3030
1. **Hunk headers must be accurate**: The format is `@@ -old_start,old_count +new_start,new_count @@`
31-
- `new_count` must equal the exact number of lines with `+` prefix in the hunk
32-
- For new file patches (`--- /dev/null`), `old_count` is 0
31+
- `old_count` is the number of lines in the hunk from the old file (context lines plus lines with `-` prefix)
32+
- `new_count` is the number of lines in the hunk in the new file (context lines plus lines with `+` prefix)
33+
- For new file patches (`--- /dev/null`), `old_count` is 0 and `new_count` is the total number of lines in the new-file hunk
3334
2. **Trailing newlines are required**: Patch files must end with a newline character. The `patch` utility will fail with "unexpected end of file" otherwise.
3435
3. **Preserve exact whitespace**: Context lines must match the target file exactly, including trailing spaces and tabs.
3536
4. **New file patches**: Use `/dev/null` as the old file:

config-server/patches/application.properties.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
+eureka.instance.hostname=host.docker.internal
1212
+eureka.instance.instanceId=host.docker.internal:configserver:8888
1313
+auth.enabled=false
14-
+logging.level.io.steeltoe.docker.ssl=INFO
14+
+logging.level.io.steeltoe.docker=INFO

eureka-server/patches/application.properties.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
+eureka.server.responseCacheUpdateIntervalMs = 1000
1515
+eureka.server.wait-time-in-ms-when-sync-empty = 0
1616
+logging.level.com.netflix.eureka = TRACE
17-
+logging.level.io.steeltoe.docker.ssl = INFO
17+
+logging.level.io.steeltoe.docker = INFO
1818
+spring.main.lazy-initialization = true

spring-boot-admin/patches/application.properties.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
@@ -0,0 +1,3 @@
44
+server.port=9099
55
+spring.thymeleaf.check-template-location=false
6-
+logging.level.io.steeltoe.docker.ssl=INFO
6+
+logging.level.io.steeltoe.docker=INFO

0 commit comments

Comments
 (0)