Skip to content

Commit 9c0bc28

Browse files
committed
Fix violations of S3717, turn off in tests
1 parent 1189dbd commit 9c0bc28

File tree

5 files changed

+5
-3
lines changed

5 files changed

+5
-3
lines changed

Steeltoe.Debug.ruleset

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@
7070
<Rule Id="S3459" Action="Info" />
7171
<Rule Id="S3597" Action="None" />
7272
<Rule Id="S3598" Action="None" />
73+
<Rule Id="S3717" Action="Info" />
7374
<Rule Id="S3776" Action="Info" />
7475
<Rule Id="S3872" Action="Warning" />
7576
<Rule Id="S3874" Action="Warning" />

Steeltoe.Release.ruleset

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
<Rule Id="S3433" Action="None" />
5959
<Rule Id="S3597" Action="None" />
6060
<Rule Id="S3598" Action="None" />
61+
<Rule Id="S3717" Action="Warning" />
6162
<Rule Id="S3872" Action="Warning" />
6263
<Rule Id="S3874" Action="Warning" />
6364
<Rule Id="S3878" Action="None" />

shared-test.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project>
22
<PropertyGroup>
3-
<NoWarn>$(NoWarn);S2094;SA1602;CA1062;CA1707;NU5104</NoWarn>
3+
<NoWarn>$(NoWarn);S2094;S3717;SA1602;CA1062;CA1707;NU5104</NoWarn>
44
</PropertyGroup>
55

66
<PropertyGroup>

src/Connectors/src/Connectors/MongoDb/MongoDbConnectionStringBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ private void FromConnectionString(string? connectionString, bool preserveUnknown
135135
if (connectionString.Contains(','))
136136
{
137137
// MongoDB allows multiple servers in the connection string, but we haven't found any service bindings that actually use that.
138-
throw new NotImplementedException("Support for multiple servers is not implemented. Please open a GitHub issue if you need this.");
138+
throw new NotSupportedException("Support for multiple servers is not implemented. Please open a GitHub issue if you need this.");
139139
}
140140

141141
// MongoDB allows semicolon as separator for query string parameters, to provide backwards compatibility.

src/Connectors/src/Connectors/Redis/RedisConnectionStringBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ private void FromConnectionString(string? connectionString)
103103
if (option.Contains(','))
104104
{
105105
// Redis allows multiple servers in the connection string, but we haven't found any service bindings that actually use that.
106-
throw new NotImplementedException("Support for multiple servers is not implemented. Please open a GitHub issue if you need this.");
106+
throw new NotSupportedException("Support for multiple servers is not implemented. Please open a GitHub issue if you need this.");
107107
}
108108

109109
string[] hostWithPort = option.Split(':', 2);

0 commit comments

Comments
 (0)