Suppress violations of S3717, turn off in tests (#1554)

* Fix violations of S3717, turn off in tests

* Switch back to original exception type

Author: bart-vmware

Steeltoe.Debug.ruleset

@@ -70,6 +70,7 @@
     <Rule Id="S3459" Action="Info" />
     <Rule Id="S3597" Action="None" />
     <Rule Id="S3598" Action="None" />
+    <Rule Id="S3717" Action="Info" />
     <Rule Id="S3776" Action="Info" />
     <Rule Id="S3872" Action="Warning" />
     <Rule Id="S3874" Action="Warning" />

Steeltoe.Release.ruleset

@@ -58,6 +58,7 @@
     <Rule Id="S3433" Action="None" />
     <Rule Id="S3597" Action="None" />
     <Rule Id="S3598" Action="None" />
+    <Rule Id="S3717" Action="Warning" />
     <Rule Id="S3872" Action="Warning" />
     <Rule Id="S3874" Action="Warning" />
     <Rule Id="S3878" Action="None" />

shared-test.props

@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <NoWarn>$(NoWarn);S2094;SA1602;CA1062;CA1707;NU5104</NoWarn>
+    <NoWarn>$(NoWarn);S2094;S3717;SA1602;CA1062;CA1707;NU5104</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup>

src/Connectors/src/Connectors/MongoDb/MongoDbConnectionStringBuilder.cs

@@ -135,7 +135,9 @@ private void FromConnectionString(string? connectionString, bool preserveUnknown
             if (connectionString.Contains(','))
             {
                 // MongoDB allows multiple servers in the connection string, but we haven't found any service bindings that actually use that.
+#pragma warning disable S3717 // Track use of "NotImplementedException"
                 throw new NotImplementedException("Support for multiple servers is not implemented. Please open a GitHub issue if you need this.");
+#pragma warning restore S3717 // Track use of "NotImplementedException"
             }
 
             // MongoDB allows semicolon as separator for query string parameters, to provide backwards compatibility.

src/Connectors/src/Connectors/Redis/RedisConnectionStringBuilder.cs

@@ -103,7 +103,9 @@ private void FromConnectionString(string? connectionString)
                     if (option.Contains(','))
                     {
                         // Redis allows multiple servers in the connection string, but we haven't found any service bindings that actually use that.
+#pragma warning disable S3717 // Track use of "NotImplementedException"
                         throw new NotImplementedException("Support for multiple servers is not implemented. Please open a GitHub issue if you need this.");
+#pragma warning restore S3717 // Track use of "NotImplementedException"
                     }
 
                     string[] hostWithPort = option.Split(':', 2);