Add a warning dialog if ASCOM version is outdated but telescope preconfigured.

Author: gzotti

plugins/TelescopeControl/src/common/ASCOMSupport.cpp

@@ -32,6 +32,29 @@ bool ASCOMSupport::isASCOMSupported()
 {
 	#ifdef Q_OS_WIN
 
+	int majorVersion = getASCOMMajorVersion();
+
+	// Check ASCOM Platform version to be 6 or greater. We apparently need 7 for Qt6!
+#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
+	if (majorVersion >= 7)
+#else
+	if (majorVersion >= 6)
+#endif
+	{
+		return true;
+	}
+
+	return false;
+
+	#else // Q_OS_WIN
+	return false;
+	#endif // Q_OS_WIN
+}
+
+int ASCOMSupport::getASCOMMajorVersion()
+{
+	#ifdef Q_OS_WIN
+
 	VARIANT v1;
 	HRESULT hResult;
 	BOOL initResult;
@@ -44,7 +67,7 @@ bool ASCOMSupport::isASCOMSupported()
 	if (FAILED(hResult) || !initResult) {
 		return false;
 	}
-	
+
 	hResult = OlePropertyGet(utilDispatch, &v1, const_cast<wchar_t*>(LPlatformVersion));
 	QString version = QString::fromStdWString(v1.bstrVal);
 	QString majorVersion = "";
@@ -54,22 +77,13 @@ bool ASCOMSupport::isASCOMSupported()
 	if (versionMatch.hasMatch())
 	{
 		majorVersion = versionMatch.captured(1).trimmed();
+		return majorVersion.toInt();
 	}
 
-	// Check ASCOM Platform version to be 6 or greater. We apparently need 7 for Qt6!
-#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
-	if (majorVersion.toInt() >= 7)
-#else
-	if (majorVersion.toInt() >= 6)
-#endif
-	{
-		return true;
-	}
-	
-	return false;
+	return 0;
 
 	#else // Q_OS_WIN
-	return false;
+	return 0;
 	#endif // Q_OS_WIN
 }
 

plugins/TelescopeControl/src/common/ASCOMSupport.hpp

@@ -31,6 +31,7 @@ class ASCOMSupport final : public QObject
 
 public:
 	static bool isASCOMSupported();
+	static int getASCOMMajorVersion();
 
 	ASCOMSupport(QObject* parent = nullptr);
 

plugins/TelescopeControl/src/gui/TelescopeDialog.cpp

@@ -39,6 +39,10 @@
 #include <QSettings>
 #include <QStandardItem>
 #include <QRegularExpression>
+#if defined(Q_OS_WIN)
+	#include "../common/ASCOMSupport.hpp"
+	#include <QMessageBox>
+#endif
 
 
 TelescopeDialog::TelescopeDialog(const QString &dialogName, QObject *parent)
@@ -108,6 +112,11 @@ void TelescopeDialog::createDialogContent()
 		connect(gui, SIGNAL(flagUseKineticScrollingChanged(bool)), this, SLOT(enableKineticScrolling(bool)));
 	}
 
+#ifdef Q_OS_WIN
+	if ((ASCOMSupport::getASCOMMajorVersion() > 0) && (ASCOMSupport::getASCOMMajorVersion() < 7))
+		QMessageBox::warning(nullptr, q_("Outdated ASCOM!"), q_("Your ASCOM is below version 7. Upgrade to avoid problems!") );
+#endif
+
 	//Inherited connect
 	connect(&StelApp::getInstance(), SIGNAL(languageChanged()), this, SLOT(retranslate()));
 	connect(ui->titleBar, &TitleBar::closeClicked, this, &StelDialog::close);