What are the graphical glitches caused by too large aberration?

[Atque]

I have an experimental branch where I allow the aberration factor to be raised to 1000. In master the value is 5.

I can't see the "graphical glitches" described in 37af746. What are these glitches? The only obvious thing, is that the Milky Way seems slightly out of sync with the aberration, but I think that's a very small problem. Having large aberration is, IMHO, needed for didactic purposes.

[alex-w]

Please try zoom to and check it again

[Atque]

Ouch! Yes, stars disappear! I guess that's not acceptable? It looks good in FOV > 15°.

[gzotti]

That was the point. If you find out the reason, we'd of course like to remove this limit. I did not follow much deeper in this, just kept the issue "for later" and configured the 5x clamp. Maybe it's enough to re-normalize star vectors, but it may cause again other issues. (Apart from more computations causing further slowdown. Maybe I even tried that back then.)

[Atque]

For someone to find the reason or even feel invited to experiment with this, we might need to let users discover aberration up to 1000. Otherwise, aberration is almost invisible from Earth (in fact, only visible from sungrazing comets), which misses the didactic goal of the exaggeration feature.

Please let me know if I should create a PR for this.

[gzotti]

If your PR provides a genuine solution to the problem, and not just replaces 5 by 1000 (which was the obvious previous aim) and then shows the problem for 50 people to report as new issue, please do so. Solving the problem requires study of and deep insight into the code to find why stars vanish, not just change of the GUI.

You can convert this discussion into an issue which whoever can then attempt to solve in a pull request. Until then, max should stay at 5 to prevent a problem becoming visible in the release.

[Atque]

Yes, my programming skills are severely limited, so indeed I only changed the 5 to 1000 in the appropriate places. I'll create an issue for this, in hopes that someone will try to solve it eventually.