#200 - rename

Author: Stepami

src/Application/HydraScript.Application.CodeGeneration/IValueFactory.cs

@@ -8,7 +8,7 @@ public interface IValueFactory
 {
     public IValue Create(ValueDto dto);
 
-    public Name CreateName(IdentifierReference id);
+    public Name Create(IdentifierReference id);
 
-    public Name CreateName(string id);
+    public Name Create(string id);
 }

src/Application/HydraScript.Application.CodeGeneration/Impl/ValueFactory.cs

@@ -21,7 +21,7 @@ public IValue Create(ValueDto dto) =>
             _ => throw new ArgumentOutOfRangeException(nameof(dto))
         };
 
-    public Name CreateName(IdentifierReference id)
+    public Name Create(IdentifierReference id)
     {
         var dto = id.ToValueDto();
         return dto switch
@@ -34,7 +34,7 @@ public Name CreateName(IdentifierReference id)
         };
     }
 
-    public Name CreateName(string id) => new(id, CurrentFrame);
+    public Name Create(string id) => new(id, CurrentFrame);
 
     private CurrentFrame CurrentFrame { get; } = new(frameContext);
 

src/Application/HydraScript.Application.CodeGeneration/Visitors/ExpressionInstructionProvider.cs

@@ -47,7 +47,7 @@ public AddressedInstructions Visit(ArrayLiteral visitable)
     {
         var arraySize = visitable.Expressions.Count;
 
-        var arrayName = _valueFactory.CreateName(visitable.Id);
+        var arrayName = _valueFactory.Create(visitable.Id);
         var createArray = new CreateArray(arrayName, arraySize);
 
         var result = new AddressedInstructions { createArray };
@@ -75,7 +75,7 @@ public AddressedInstructions Visit(ArrayLiteral visitable)
 
     public AddressedInstructions Visit(ObjectLiteral visitable)
     {
-        var objectId = _valueFactory.CreateName(visitable.Id);
+        var objectId = _valueFactory.Create(visitable.Id);
         var createObject = new CreateObject(objectId);
 
         var result = new AddressedInstructions { createObject };
@@ -90,7 +90,7 @@ public AddressedInstructions Visit(ObjectLiteral visitable)
 
     public AddressedInstructions Visit(Property visitable)
     {
-        var objectId = _valueFactory.CreateName(visitable.Object.Id);
+        var objectId = _valueFactory.Create(visitable.Object.Id);
 
         var (id, expression) = visitable;
         var propertyId = new Constant(id);
@@ -123,7 +123,7 @@ public AddressedInstructions Visit(UnaryExpression visitable)
     public AddressedInstructions Visit(BinaryExpression visitable)
     {
         if (visitable is { Left: IdentifierReference arr, Right: PrimaryExpression primary, Operator: "::" })
-            return [new RemoveFromArray(_valueFactory.CreateName(arr), index: _valueFactory.Create(primary.ToValueDto()))];
+            return [new RemoveFromArray(_valueFactory.Create(arr), index: _valueFactory.Create(primary.ToValueDto()))];
 
         var result = new AddressedInstructions();
         IValue left, right;
@@ -172,7 +172,7 @@ public AddressedInstructions Visit(CastAsExpression visitable)
 
     public AddressedInstructions Visit(WithExpression visitable)
     {
-        var objectId = _valueFactory.CreateName(visitable.ObjectLiteral.Id);
+        var objectId = _valueFactory.Create(visitable.ObjectLiteral.Id);
         var createObject = new CreateObject(objectId);
 
         var result = new AddressedInstructions { createObject };
@@ -197,15 +197,15 @@ public AddressedInstructions Visit(WithExpression visitable)
         result.AddRange(visitable.Expression is PrimaryExpression ? [] : visitable.Expression.Accept(This));
 
         var copyFrom = visitable.Expression is IdentifierReference objectIdent
-            ? _valueFactory.CreateName(objectIdent)
+            ? _valueFactory.Create(objectIdent)
             : result.OfType<Simple>().Last().Left!;
 
         for (var i = 0; i < visitable.ComputedCopiedProperties.Count; i++)
         {
             var property = new Constant(visitable.ComputedCopiedProperties[i]);
             result.Add(new DotRead(copyFrom, property));
             var read = result[result.End].Address.Name;
-            result.Add(new DotAssignment(objectId, property, _valueFactory.CreateName(read)));
+            result.Add(new DotAssignment(objectId, property, _valueFactory.Create(read)));
         }
 
         return result;
@@ -255,7 +255,7 @@ public AddressedInstructions Visit(AssignmentExpression visitable)
         }
 
         if (visitable.Destination.Empty())
-            result.OfType<Simple>().Last().Left = _valueFactory.CreateName(visitable.Destination.Id);
+            result.OfType<Simple>().Last().Left = _valueFactory.Create(visitable.Destination.Id);
         else
         {
             var last = result.OfType<Simple>().Last().Left!;
@@ -277,7 +277,7 @@ public AddressedInstructions Visit(DotAccess visitable)
         var right = new Constant(visitable.Property.Name);
 
         if (!visitable.HasPrev() && visitable.Parent is LeftHandSideExpression lhs)
-            return [new DotRead(_valueFactory.CreateName(lhs.Id), right)];
+            return [new DotRead(_valueFactory.Create(lhs.Id), right)];
 
         var result = visitable.Prev?.Accept(This) ?? [];
         var left = result.OfType<Simple>().Last().Left!;
@@ -301,7 +301,7 @@ public AddressedInstructions Visit(IndexAccess visitable)
         }
 
         if (!visitable.HasPrev() && visitable.Parent is LeftHandSideExpression lhs)
-            result.Add(new IndexRead(_valueFactory.CreateName(lhs.Id), right));
+            result.Add(new IndexRead(_valueFactory.Create(lhs.Id), right));
         else
         {
             result.AddRange(visitable.Prev?.Accept(This) ?? []);
@@ -332,7 +332,7 @@ public AddressedInstructions Visit(CallExpression visitable)
         {
             var caller = result.Count > 0
                 ? result.OfType<Simple>().Last().Left!
-                : _valueFactory.CreateName(visitable.Id);
+                : _valueFactory.Create(visitable.Id);
             result.Add(new PushParameter(caller));
         }
 

src/Application/HydraScript.Application.CodeGeneration/Visitors/InstructionProvider.cs

@@ -133,7 +133,7 @@ public AddressedInstructions Visit(FunctionDeclaration visitable)
         for (var i = 0; i < visitable.Arguments.Count; i++)
         {
             var arg = visitable.Arguments[i];
-            result.Add(new PopParameter(_valueFactory.CreateName(arg.Name), arg.Info.Value));
+            result.Add(new PopParameter(_valueFactory.Create(arg.Name), arg.Info.Value));
         }
 
         result.AddRange(visitable.Statements.Accept(This));
@@ -238,11 +238,11 @@ public AddressedInstructions Visit(OutputStatement visitable)
             var valueDto = prim.ToValueDto();
             var printedValue = _valueFactory.Create(valueDto);
             IExecutableInstruction instruction = valueDto is { Type: ValueDtoType.Env } or { Type: ValueDtoType.Constant, Value: string }
-                ? new Print(printedValue)
+                ? new Output(printedValue)
                 : new AsString(printedValue);
             AddressedInstructions shortResult = [instruction];
             if (instruction is AsString asString)
-                shortResult.Add(new Print(asString.Left!));
+                shortResult.Add(new Output(asString.Left!));
             return shortResult;
         }
 
@@ -252,7 +252,7 @@ public AddressedInstructions Visit(OutputStatement visitable)
         var name = result.OfType<Simple>().Last().Left!;
         var nameAsString = new AsString(name);
         result.Add(nameAsString);
-        result.Add(new Print(nameAsString.Left!));
+        result.Add(new Output(nameAsString.Left!));
 
         return result;
     }