compute children list once on object construction

Author: Stepami

benchmarks/Readme.md

@@ -11,5 +11,5 @@ Apple M1 Pro, 1 CPU, 10 logical and 10 physical cores
 ```
 | Method | Job           | Runtime       |     Mean |     Error |    StdDev |      Gen0 |     Gen1 | Allocated |
 |--------|---------------|---------------|---------:|----------:|----------:|----------:|---------:|----------:|
-| Invoke | .NET 9.0      | .NET 9.0      | 7.427 ms | 0.1477 ms | 0.1701 ms | 1593.7500 | 406.2500 |   9.57 MB |
-| Invoke | NativeAOT 9.0 | NativeAOT 9.0 | 7.215 ms | 0.0836 ms | 0.0699 ms | 1593.7500 | 453.1250 |   9.56 MB |
+| Invoke | .NET 9.0      | .NET 9.0      | 9.525 ms | 0.1615 ms | 0.1658 ms | 1562.5000 | 500.0000 |   9.37 MB |
+| Invoke | NativeAOT 9.0 | NativeAOT 9.0 | 7.321 ms | 0.0544 ms | 0.0509 ms | 1562.5000 | 468.7500 |   9.36 MB |

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Declarations/AfterTypesAreLoaded/FunctionDeclaration.cs

@@ -9,7 +9,7 @@ public partial class FunctionDeclaration : AfterTypesAreLoadedDeclaration
 {
     private readonly List<IFunctionArgument> _arguments;
 
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children => [Statements];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public IdentifierReference Name { get; }
     public TypeValue ReturnTypeValue { get; }
@@ -32,6 +32,7 @@ public FunctionDeclaration(
 
         Statements = blockStatement;
         Statements.Parent = this;
+        Children = [Statements];
 
         ReturnStatements = Statements
             .GetAllNodes()

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/AssignmentExpression.cs

@@ -5,8 +5,7 @@ namespace HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions;
 [AutoVisitable<IAbstractSyntaxTreeNode>]
 public partial class AssignmentExpression : Expression
 {
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children =>
-        [Destination, Source];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public LeftHandSideExpression Destination { get; }
     public Expression Source { get; }
@@ -24,6 +23,8 @@ public AssignmentExpression(
         source.Parent = this;
 
         DestinationType = destinationType;
+
+        Children = [Destination, Source];
     }
 
     /// <inheritdoc cref="AbstractSyntaxTreeNode.InitScope"/>

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/BinaryExpression.cs

@@ -3,8 +3,7 @@ namespace HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions;
 [AutoVisitable<IAbstractSyntaxTreeNode>]
 public partial class BinaryExpression : Expression
 {
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children =>
-        [Left, Right];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public Expression Left { get; }
     public string Operator { get; }
@@ -19,6 +18,8 @@ public BinaryExpression(Expression left, string @operator, Expression right)
 
         Right = right;
         Right.Parent = this;
+
+        Children = [Left, Right];
     }
 
     protected override string NodeRepresentation() => Operator;

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/CallExpression.cs

@@ -7,8 +7,7 @@ public partial class CallExpression : LeftHandSideExpression
 {
     private readonly List<Expression> _parameters;
 
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children =>
-        [Member, .._parameters];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public MemberExpression Member { get; }
     public IReadOnlyList<Expression> Parameters => _parameters;
@@ -25,6 +24,8 @@ public CallExpression(MemberExpression member, List<Expression> expressions)
 
         _parameters = expressions;
         _parameters.ForEach(expr => expr.Parent = this);
+
+        Children = [Member, .._parameters];
     }
 
     public override IdentifierReference Id => Member.Id;

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/CastAsExpression.cs

@@ -5,8 +5,7 @@ namespace HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions;
 [AutoVisitable<IAbstractSyntaxTreeNode>]
 public partial class CastAsExpression : Expression
 {
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children =>
-        [Expression];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public Expression Expression { get; }
     public TypeValue Cast { get; }
@@ -17,6 +16,8 @@ public CastAsExpression(Expression expression, TypeValue cast)
         Expression.Parent = this;
 
         Cast = cast;
+
+        Children = [Expression];
     }
 
     /// <inheritdoc cref="AbstractSyntaxTreeNode.InitScope"/>

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/ComplexLiterals/Property.cs

@@ -5,8 +5,7 @@ namespace HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions.ComplexL
 [AutoVisitable<IAbstractSyntaxTreeNode>]
 public partial class Property : Expression
 {
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children =>
-        [Id, Expression];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public IdentifierReference Id { get; }
     public Expression Expression { get; }
@@ -21,6 +20,8 @@ public Property(IdentifierReference id, Expression expression)
 
         Expression = expression;
         Expression.Parent = this;
+
+        Children = [Id, Expression];
     }
 
     public void Deconstruct(out string id, out Expression expr)

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/ConditionalExpression.cs

@@ -3,8 +3,7 @@ namespace HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions;
 [AutoVisitable<IAbstractSyntaxTreeNode>]
 public partial class ConditionalExpression : Expression
 {
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children =>
-        [Test, Consequent, Alternate];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public Expression Test { get; }
     public Expression Consequent { get; }
@@ -19,6 +18,8 @@ public ConditionalExpression(Expression test, Expression consequent, Expression
         Test.Parent = this;
         Consequent.Parent = this;
         Alternate.Parent = this;
+
+        Children = [Test, Consequent, Alternate];
     }
 
     protected override string NodeRepresentation() => "?:";

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/UnaryExpression.cs

@@ -3,8 +3,7 @@ namespace HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions;
 [AutoVisitable<IAbstractSyntaxTreeNode>]
 public partial class UnaryExpression : Expression
 {
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children =>
-        [Expression];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public string Operator { get; }
     public Expression Expression { get; }
@@ -15,6 +14,8 @@ public UnaryExpression(string @operator, Expression expression)
 
         Expression = expression;
         Expression.Parent = this;
+
+        Children = [Expression];
     }
 
     protected override string NodeRepresentation() => Operator;

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Statements/ExpressionStatement.cs

@@ -3,15 +3,16 @@ namespace HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Statements;
 [AutoVisitable<IAbstractSyntaxTreeNode>]
 public partial class ExpressionStatement : Statement
 {
-    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children =>
-        [Expression];
+    protected override IReadOnlyList<IAbstractSyntaxTreeNode> Children { get; }
 
     public Expression Expression { get; }
 
     public ExpressionStatement(Expression expression)
     {
         Expression = expression;
         Expression.Parent = this;
+
+        Children = [Expression];
     }
 
     protected override string NodeRepresentation() => nameof(ExpressionStatement);