#155 - specify overloads

Author: Stepami

src/Application/HydraScript.Application.StaticAnalysis/Impl/FunctionWithUndefinedReturnStorage.cs

@@ -16,7 +16,7 @@ public void Save(FunctionSymbol symbol, FunctionDeclaration declaration)
     public FunctionDeclaration Get(FunctionSymbol symbol)
     {
         if (!_declarations.Remove(symbol.Id, out var declaration))
-            throw new InvalidOperationException(message: "Cannot get function that has not been saved");
+            throw new InvalidOperationException(message: $"Cannot get {symbol} that has not been saved");
 
         return declaration;
     }

src/Application/HydraScript.Application.StaticAnalysis/Visitors/DeclarationVisitor.cs

@@ -74,7 +74,7 @@ public VisitUnit Visit(FunctionDeclaration visitable)
         var functionSymbolId = new FunctionSymbolId(visitable.Name, parameters.Select(x => x.Type));
         visitable.ComputedFunctionAddress = functionSymbolId.ToString();
         if (_symbolTables[visitable.Parent.Scope].ContainsSymbol(functionSymbolId))
-            throw new DeclarationAlreadyExists(visitable.Name);
+            throw new OverloadAlreadyExists(visitable.Name, functionSymbolId);
 
         for (var i = 0; i < parameters.Count; i++)
         {

src/Application/HydraScript.Application.StaticAnalysis/Visitors/SemanticChecker.cs

@@ -410,13 +410,17 @@ public Type Visit(CallExpression visitable)
         {
             var objectType = (ObjectType)visitable.Member.Accept(This);
             var availableMethods = _methodStorage.GetAvailableMethods(objectType);
-            functionSymbol = availableMethods[new FunctionSymbolId(objectType.LastAccessedMethodName, [objectType, ..parameters])];
+            var methodKey = new FunctionSymbolId(objectType.LastAccessedMethodName, [objectType, ..parameters]);
+            functionSymbol =
+                availableMethods.GetValueOrDefault(methodKey)
+                ?? throw new UnknownFunctionOverload(visitable.Id, methodKey);
         }
         else
         {
+            var functionKey = new FunctionSymbolId(visitable.Id, parameters);
             functionSymbol =
-                _symbolTables[visitable.Scope].FindSymbol(new FunctionSymbolId(visitable.Id, parameters))
-                ?? throw new UnknownIdentifierReference(visitable.Id);
+                _symbolTables[visitable.Scope].FindSymbol(functionKey)
+                ?? throw new UnknownFunctionOverload(visitable.Id, functionKey);
         }
 
         visitable.ComputedFunctionAddress = functionSymbol.Id.ToString();