#16 - refactor ComplexLiteral hierarchy: make Id property abstract and implement in derived classes

Author: Stepami

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/ComplexLiterals/ArrayLiteral.cs

@@ -10,6 +10,10 @@ public partial class ArrayLiteral : ComplexLiteral
 
     public IReadOnlyList<Expression> Expressions => _expressions;
 
+    public override string Id => Parent is AssignmentExpression assignment
+        ? assignment.Destination.Id
+        : NullId;
+
     public ArrayLiteral(List<Expression> expressions)
     {
         _expressions = expressions;

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/ComplexLiterals/ComplexLiteral.cs

@@ -2,7 +2,16 @@ namespace HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions.ComplexL
 
 public abstract class ComplexLiteral : Expression
 {
-    public string Id => Parent is AssignmentExpression assignment
-        ? assignment.Destination.Id
-        : $"_t{GetHashCode()}";
+    private string? _nullId;
+
+    protected string NullId
+    {
+        get
+        {
+            _nullId ??= $"{GetHashCode()}";
+            return _nullId;
+        }
+    }
+
+    public abstract string Id { get; }
 }

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/ComplexLiterals/ObjectLiteral.cs

@@ -10,6 +10,20 @@ public partial class ObjectLiteral : ComplexLiteral
 
     public IReadOnlyList<Property> Properties => _properties;
 
+    public override string Id
+    {
+        get
+        {
+            if (Parent is AssignmentExpression assignment) 
+                return assignment.Destination.Id;
+
+            if (Parent is WithExpression{Parent:AssignmentExpression withAssignment})
+                return withAssignment.Destination.Id;
+
+            return NullId;
+        }
+    }
+
     public ObjectLiteral(List<Property> properties)
     {
         _properties = properties;