#142 - параметры функций по умолчанию (#167) +semver:feature

* #142 - обновление грамматики

* #142 - новая модель аргумента функции

* #142 - новая модель 2

* #142 - новая грамматика скобочек

* #142 - реализация новой грамматики в парсере

* #142 - проверка порядка аргументов функции

* #142 - регистрация по заданному ключу в таблице символов

* #142 - регистрация перегрузок функции с параметрами по умолчанию

* #167 - добавлен тест

* #167 - удаление ненужной проверки

* #167 - доработка кодогенерации

* #167 - fix code cov

* #167 - fix

* #167 - fix cov 2

* #167 - доработка теста и статического анализа

* fix

* #167 - error test

* change event develop workflow

* fix

* fix docs

* #167 - after merge

* #167 - update nuget

* #167 - доработка статического анализа на проверку неоднозначных вызовов

* #167 - не зависим от порядка объявления функции

* #167 - ещё один фикс про порядок

Author: Stepami

CONTRIBUTING.md

@@ -8,17 +8,16 @@ Contributions are welcomed! Here's a few things to know:
       - [Do not point fingers](#do-not-point-fingers)
       - [Provide code feedback based on evidence](#provide-code-feedback-based-on-evidence)
       - [Ask questions do not give answers](#ask-questions-do-not-give-answers)
-  - [HydraScript Contributor License Agreement](#hydrascript-contributor-license-agreement)
 
 ## Steps to Contributing
 
 Here are the basic steps to get started with your first contribution. Please reach out with any questions.
 1. Use [open issues](https://github.com/stepami/hydrascript/issues) to discuss the proposed changes. Create an issue describing changes if necessary to collect feedback. Also, please use provided labels to tag issues so everyone can easily sort issues of interest.
-1. [Fork the repo](https://help.github.com/articles/fork-a-repo/) in order if you want to make and test local changes.
-1. Create a new branch **from master** for the issue. We suggest prefixing the branch with type of contribution (`bugfix`/`feature`), your username and then a descriptive title: (e.g. `bugfix/user1/object-comparision` or `feature/user2/variable-initialization-check`)
-1. Make code changes.
-1. Ensure unit tests pass and code coverage minimum is satisfied.
-1. Create a pull request against **master** branch.
+2. [Fork the repo](https://help.github.com/articles/fork-a-repo/) in order if you want to make and test local changes.
+3. Create a new branch **from master** for the issue. We suggest prefixing the branch with type of contribution (`bugfix`/`feature`), your username and then a descriptive title: (e.g. `bugfix/user1/object-comparision` or `feature/user2/variable-initialization-check`)
+4. Make code changes.
+5. Ensure unit tests pass and code coverage minimum is satisfied.
+6. Create a pull request against **master** branch.
 
 ## Code of conduct
 
@@ -54,10 +53,4 @@ Try to be empathic.
 * Would it make more sense if ...?
 * Have you considered this ... ?
 
-</details>
-
-## HydraScript Contributor License Agreement
-
-Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution.
-
-When you submit a pull request, a CLA-bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., label, comment). Simply follow the instructions provided by the bot. You will only need to do this once in this repo.
+</details>

Directory.Packages.props

@@ -5,13 +5,13 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageVersion>
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.13.0" />
-    <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.3" />
-    <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.3" />
-    <PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.3" />
-    <PackageVersion Include="Microsoft.Extensions.Options" Version="9.0.3" />
+    <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.4" />
+    <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.4" />
+    <PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.4" />
+    <PackageVersion Include="Microsoft.Extensions.Options" Version="9.0.4" />
     <PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.24126.1" />
-    <PackageVersion Include="System.IO.Abstractions" Version="22.0.12" />
-    <PackageVersion Include="Visitor.NET" Version="4.1.2" />
-    <PackageVersion Include="Visitor.NET.AutoVisitableGen" Version="1.3.0" />
+    <PackageVersion Include="System.IO.Abstractions" Version="22.0.14" />
+    <PackageVersion Include="Visitor.NET" Version="4.2.0" />
+    <PackageVersion Include="Visitor.NET.AutoVisitableGen" Version="1.5.2" />
   </ItemGroup>
 </Project>

SECURITY.md

@@ -3,7 +3,7 @@
 ## Supported Versions
 
 | Version | Supported          |
-| ------- | ------------------ |
+|---------|--------------------|
 | > 1.0   | :white_check_mark: |
 
 ## Reporting a Vulnerability
@@ -15,4 +15,4 @@ Security issues and bugs should be reported privately via email to stepami@mail.
 ## When Should I Report a Vulnerability?
 
 - You think you discovered a potential security vulnerability
-- You are unsure how a vulnerability affects YTsaurus
+- You are unsure how a vulnerability affects HydraScript

src/Application/HydraScript.Application.CodeGeneration/Visitors/InstructionProvider.cs

@@ -38,6 +38,8 @@ public InstructionProvider(
         _expressionVisitor = expressionVisitor;
     }
 
+    public override AddressedInstructions Visit(IAbstractSyntaxTreeNode visitable) => [];
+
     public AddressedInstructions Visit(ScriptBody visitable)
     {
         var result = new AddressedInstructions();
@@ -52,8 +54,6 @@ public AddressedInstructions Visit(ScriptBody visitable)
         return result;
     }
 
-    public override AddressedInstructions DefaultVisit { get; } = [];
-
     public AddressedInstructions Visit(LexicalDeclaration visitable)
     {
         var result = new AddressedInstructions();
@@ -129,8 +129,14 @@ public AddressedInstructions Visit(FunctionDeclaration visitable)
             }
         };
 
-        foreach (var (id, _) in visitable.Arguments)
-            result.Add(new PopParameter(id));
+        for (var i = 0; i < visitable.Arguments.Count; i++)
+        {
+            var arg = visitable.Arguments[i];
+            if (arg is DefaultValueArgument @default)
+                result.Add(new PopParameter(arg.Name, @default.Info.Value));
+            else
+                result.Add(new PopParameter(arg.Name));
+        }
 
         result.AddRange(visitable.Statements.Accept(This));
         if (!visitable.HasReturnStatement())

src/Application/HydraScript.Application.StaticAnalysis/Exceptions/AmbiguousInvocation.cs

@@ -0,0 +1,12 @@
+using System.Diagnostics.CodeAnalysis;
+using HydraScript.Domain.IR.Impl.Symbols.Ids;
+
+namespace HydraScript.Application.StaticAnalysis.Exceptions;
+
+[ExcludeFromCodeCoverage]
+public class AmbiguousInvocation(
+    string segment,
+    IReadOnlyCollection<FunctionSymbolId> candidates) :
+    SemanticException(
+        segment,
+        $"Ambiguous Invocation - Candidates are:\n{string.Join('\n', candidates)}");

src/Application/HydraScript.Application.StaticAnalysis/Exceptions/NamedArgumentAfterDefaultValueArgument.cs

@@ -0,0 +1,8 @@
+using System.Diagnostics.CodeAnalysis;
+using HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Declarations.AfterTypesAreLoaded;
+
+namespace HydraScript.Application.StaticAnalysis.Exceptions;
+
+[ExcludeFromCodeCoverage]
+public class NamedArgumentAfterDefaultValueArgument(string segment, string function, IFunctionArgument argument) :
+    SemanticException(segment, $"The argument {argument} of function {function} is placed after default value argument");

src/Application/HydraScript.Application.StaticAnalysis/Exceptions/WrongNumberOfArguments.cs

@@ -0,0 +1,12 @@
+using HydraScript.Domain.IR.Impl.Symbols.Ids;
+
+namespace HydraScript.Application.StaticAnalysis;
+
+public interface IAmbiguousInvocationStorage
+{
+    void WriteCandidate(FunctionSymbolId invocation, FunctionSymbolId candidate);
+
+    void CheckCandidatesAndThrow(string segment, FunctionSymbolId invocation);
+
+    void Clear(FunctionSymbolId invocation);
+}

src/Application/HydraScript.Application.StaticAnalysis/IAmbiguousInvocationStorage.cs

@@ -0,0 +1,25 @@
+using HydraScript.Application.StaticAnalysis.Exceptions;
+using HydraScript.Domain.IR.Impl.Symbols.Ids;
+
+namespace HydraScript.Application.StaticAnalysis.Impl;
+
+internal class AmbiguousInvocationStorage : IAmbiguousInvocationStorage
+{
+    private readonly Dictionary<FunctionSymbolId, HashSet<FunctionSymbolId>> _invocations = [];
+
+    public void WriteCandidate(FunctionSymbolId invocation, FunctionSymbolId candidate)
+    {
+        if (!_invocations.ContainsKey(invocation))
+            _invocations[invocation] = [];
+        _invocations[invocation].Add(candidate);
+    }
+
+    public void CheckCandidatesAndThrow(string segment, FunctionSymbolId invocation)
+    {
+        var candidates = _invocations.GetValueOrDefault(invocation, []);
+        if (candidates.Count > 0)
+            throw new AmbiguousInvocation(segment, candidates);
+    }
+
+    public void Clear(FunctionSymbolId invocation) => _invocations.Remove(invocation);
+}

src/Application/HydraScript.Application.StaticAnalysis/Impl/AmbiguousInvocationStorage.cs

@@ -12,6 +12,8 @@ internal class DefaultValueForTypeCalculator : IDefaultValueForTypeCalculator
 
     public object? GetDefaultValueForType(Type type)
     {
+        if (type is NullableType)
+            return null;
         if (type.Equals(_boolean))
             return false;
         if (type.Equals(_number))