#202 - refactoring AsString.cs

Author: Stepami

src/Application/HydraScript.Application.CodeGeneration/Visitors/ExpressionInstructionProvider.cs

@@ -5,6 +5,7 @@
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ComplexData.Create;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ComplexData.Read;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ComplexData.Write;
+using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ExplicitCast;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithJump;
 using HydraScript.Domain.BackEnd.Impl.Values;
 using HydraScript.Domain.FrontEnd.Parser;

src/Application/HydraScript.Application.CodeGeneration/Visitors/InstructionProvider.cs

@@ -2,6 +2,7 @@
 using HydraScript.Domain.BackEnd.Impl.Addresses;
 using HydraScript.Domain.BackEnd.Impl.Instructions;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment;
+using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ExplicitCast;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithJump;
 using HydraScript.Domain.Constants;
 using HydraScript.Domain.FrontEnd.Parser;

src/Domain/HydraScript.Domain.BackEnd/Impl/Instructions/WithAssignment/ExplicitCast/AsInstruction.cs

@@ -0,0 +1,16 @@
+namespace HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ExplicitCast;
+
+public abstract class AsInstruction<T>(IValue value) : Simple(value)
+{
+    protected override void Assign()
+    {
+        var value = Right.right!.Get();
+        var valueAsType = value is T ? value : Convert(value);
+        Left?.Set(valueAsType);
+    }
+
+    protected abstract T Convert(object? value);
+
+    protected override string ToStringInternal() =>
+        $"{Left} = {Right.right} as {typeof(T).Name})";
+}

…/Instructions/WithAssignment/AsString.cs …/WithAssignment/ExplicitCast/AsString.cssrc/Domain/HydraScript.Domain.BackEnd/Impl/Instructions/WithAssignment/AsString.cs renamed to src/Domain/HydraScript.Domain.BackEnd/Impl/Instructions/WithAssignment/ExplicitCast/AsString.cs src/Domain/HydraScript.Domain.BackEnd/Impl/Instructions/WithAssignment/AsString.cs renamed to src/Domain/HydraScript.Domain.BackEnd/Impl/Instructions/WithAssignment/ExplicitCast/AsString.cs

@@ -2,23 +2,12 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment;
+namespace HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ExplicitCast;
 
-public partial class AsString(IValue value) : Simple(value)
+public partial class AsString(IValue value) : AsInstruction<string>(value)
 {
-    protected override void Assign()
-    {
-        var value = Right.right!.Get();
-        var valueAsString = value is string
-            ? value
-            : JsonSerializer.Serialize(
-                value: Right.right!.Get()!,
-                AsStringSerializationContext.Default.Object);
-        Left?.Set(valueAsString);
-    }
-
-    protected override string ToStringInternal() =>
-        $"{Left} = {Right.right} as string";
+    protected override string Convert(object? value) =>
+        JsonSerializer.Serialize(value, AsStringSerializationContext.Default.Object);
 
     [JsonSourceGenerationOptions(
         GenerationMode = JsonSourceGenerationMode.Serialization,

tests/HydraScript.UnitTests/Domain/BackEnd/AddressedInstructionsTests.cs

@@ -2,6 +2,7 @@
 using HydraScript.Domain.BackEnd.Impl.Addresses;
 using HydraScript.Domain.BackEnd.Impl.Instructions;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment;
+using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ExplicitCast;
 using HydraScript.Domain.BackEnd.Impl.Values;
 
 namespace HydraScript.UnitTests.Domain.BackEnd;

tests/HydraScript.UnitTests/Domain/BackEnd/AsStringTests.cs

@@ -1,6 +1,6 @@
 using HydraScript.Domain.BackEnd;
-using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment;
 using HydraScript.Domain.BackEnd.Impl.Values;
+using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ExplicitCast;
 
 namespace HydraScript.UnitTests.Domain.BackEnd;
 

tests/HydraScript.UnitTests/Domain/BackEnd/InstructionsData.cs

@@ -4,6 +4,7 @@
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ComplexData.Create;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ComplexData.Write;
+using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ExplicitCast;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithJump;
 using HydraScript.Domain.BackEnd.Impl.Values;
 

tests/HydraScript.UnitTests/Domain/BackEnd/VirtualMachineTests.cs

@@ -5,6 +5,7 @@
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ComplexData.Create;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ComplexData.Write;
+using HydraScript.Domain.BackEnd.Impl.Instructions.WithAssignment.ExplicitCast;
 using HydraScript.Domain.BackEnd.Impl.Instructions.WithJump;
 using HydraScript.Domain.BackEnd.Impl.Values;