reduce allocations (#186) +semver:skip

* reduce allocations

* fix tests

* compute children list once on object construction

* nrt refac iaddress

Author: Stepami

benchmarks/Readme.md

@@ -11,5 +11,5 @@ Apple M1 Pro, 1 CPU, 10 logical and 10 physical cores
 ```
 | Method | Job           | Runtime       |     Mean |     Error |    StdDev |      Gen0 |     Gen1 | Allocated |
 |--------|---------------|---------------|---------:|----------:|----------:|----------:|---------:|----------:|
-| Invoke | .NET 9.0      | .NET 9.0      | 9.496 ms | 0.1434 ms | 0.1341 ms | 1625.0000 | 546.8750 |   9.79 MB |
-| Invoke | NativeAOT 9.0 | NativeAOT 9.0 | 7.418 ms | 0.0217 ms | 0.0203 ms | 1632.8125 | 453.1250 |   9.78 MB |
+| Invoke | .NET 9.0      | .NET 9.0      | 9.525 ms | 0.1615 ms | 0.1658 ms | 1562.5000 | 500.0000 |   9.37 MB |
+| Invoke | NativeAOT 9.0 | NativeAOT 9.0 | 7.321 ms | 0.0544 ms | 0.0509 ms | 1562.5000 | 468.7500 |   9.36 MB |

src/Application/HydraScript.Application.CodeGeneration/Visitors/InstructionProvider.cs

@@ -11,7 +11,6 @@
 using HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions.PrimaryExpressions;
 using HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Statements;
 using Microsoft.Extensions.DependencyInjection;
-using ZLinq;
 
 namespace HydraScript.Application.CodeGeneration.Visitors;
 
@@ -169,9 +168,9 @@ public AddressedInstructions Visit(WhileStatement visitable)
         }
 
         result.AddRange(visitable.Statement.Accept(This));
-        result.AsValueEnumerable()
-            .OfType<Goto>().Where(g => g.JumpType is not null)
-            .ToList().ForEach(g =>
+        for (var address = result.Start; address != null; address = address.Next)
+        {
+            if (result[address] is Goto { JumpType: not null } g)
             {
                 // ReSharper disable once SwitchStatementHandlesSomeKnownEnumValuesWithDefault
                 switch (g.JumpType)
@@ -183,7 +182,8 @@ public AddressedInstructions Visit(WhileStatement visitable)
                         g.SetJump(startBlockLabel);
                         break;
                 }
-            });
+            }
+        }
         result.Add(new Goto(startBlockLabel));
 
         result.Add(new EndBlock(BlockType.Loop, blockId), endBlockLabel.Name);
@@ -222,9 +222,11 @@ public AddressedInstructions Visit(IfStatement visitable)
         if (visitable.HasElseBlock())
             result.AddRange(visitable.Else?.Accept(This) ?? []);
 
-        result.AsValueEnumerable()
-            .OfType<Goto>().Where(g => g.JumpType is InsideStatementJumpType.Break)
-            .ToList().ForEach(g => g.SetJump(endBlockLabel));
+        for (var address = result.Start; address != null; address = address.Next)
+        {
+            if (result[address] is Goto { JumpType: InsideStatementJumpType.Break } g)
+                g.SetJump(endBlockLabel);
+        }
 
         result.Add(new EndBlock(BlockType.Condition, blockId), endBlockLabel.Name);
 

src/Application/HydraScript.Application.StaticAnalysis/Impl/FunctionWithUndefinedReturnStorage.cs

@@ -21,11 +21,13 @@ public FunctionDeclaration Get(FunctionSymbol symbol)
 
     public void RemoveIfPresent(FunctionSymbol symbol) => _declarations.Remove(symbol.Id);
 
-    public IEnumerable<FunctionDeclaration> Flush() => _declarations.Keys.ToList()
-        .Select(x =>
+    public IEnumerable<FunctionDeclaration> Flush()
+    {
+        IReadOnlyList<FunctionSymbolId> keys = _declarations.Keys;
+        while (keys.Count > 0)
         {
-            var decl = _declarations[x];
-            _declarations.Remove(x);
-            return decl;
-        });
+            yield return _declarations[keys[0]];
+            _declarations.Remove(keys[0]);
+        }
+    }
 }

src/Application/HydraScript.Application.StaticAnalysis/Visitors/SemanticChecker.cs

@@ -256,7 +256,7 @@ public Type Visit(BinaryExpression visitable)
             "++" when lType is ArrayType { Type: Any } && rType is ArrayType { Type: Any } =>
                 throw new CannotDefineType(visitable.Segment),
             "++" => lType is ArrayType lArrType && rType is ArrayType rArrType
-                ? new List<ArrayType> { lArrType, rArrType }.First(x => x.Type is not Any)
+                ? lArrType.Type is not Any ? lArrType : rArrType.Type is not Any ? rArrType : throw new CannotDefineType(visitable.Segment)
                 : throw new UnsupportedOperation(visitable.Segment, lType, visitable.Operator),
             "::" when lType is not ArrayType =>
                 throw new UnsupportedOperation(visitable.Segment, lType, visitable.Operator),
@@ -464,7 +464,7 @@ public Type Visit(CallExpression visitable)
 
     public Type Visit(FunctionDeclaration visitable)
     {
-        var parameters = visitable.Arguments.Select(x => x.TypeValue.Accept(_typeBuilder)).ToList();
+        var parameters = visitable.Arguments.Select(x => x.TypeValue.Accept(_typeBuilder));
         var symbol = _symbolTables[visitable.Scope].FindSymbol(new FunctionSymbolId(visitable.Name, parameters))!;
         _functionStorage.RemoveIfPresent(symbol);
         visitable.Statements.Accept(This);

src/Domain/HydraScript.Domain.BackEnd/AddressedInstructions.cs

@@ -54,8 +54,7 @@ private void AddWithAddress(IExecutableInstruction instruction, IAddress newAddr
 
     public void AddRange(AddressedInstructions instructions)
     {
-        // ReSharper disable once ConstantConditionalAccessQualifier
-        for (var address = instructions.Start; address != null; address = address?.Next)
+        for (var address = instructions.Start; address != null; address = address.Next)
         {
             AddWithAddress(instructions[address], address);
         }

src/Domain/HydraScript.Domain.BackEnd/IAddress.cs

@@ -2,7 +2,7 @@ namespace HydraScript.Domain.BackEnd;
 
 public interface IAddress : IEquatable<IAddress>
 {
-    public IAddress Next { get; set; }
+    public IAddress? Next { get; set; }
 
     public string Name { get; }
 }

src/Domain/HydraScript.Domain.BackEnd/IExecutableInstruction.cs

@@ -3,6 +3,5 @@ namespace HydraScript.Domain.BackEnd;
 public interface IExecutableInstruction
 {
     public IAddress Address { get; set; }
-    public IAddress Execute(IExecuteParams executeParams);
-    public bool End { get; }
+    public IAddress? Execute(IExecuteParams executeParams);
 }

src/Domain/HydraScript.Domain.BackEnd/Impl/Addresses/HashAddress.cs

@@ -9,7 +9,7 @@ public class HashAddress(int seed) : IAddress
 
     private readonly Guid _id = Guid.NewGuid();
 
-    public IAddress Next { get; set; } = default!;
+    public IAddress? Next { get; set; }
 
     public string Name
     {

src/Domain/HydraScript.Domain.BackEnd/Impl/Addresses/Label.cs

@@ -4,7 +4,7 @@ public class Label(string name) : IAddress
 {
     public string Name { get; } = name;
 
-    public IAddress Next { get; set; } = default!;
+    public IAddress? Next { get; set; }
 
     public bool Equals(IAddress? other) =>
         other is Label label &&

src/Domain/HydraScript.Domain.BackEnd/Impl/Instructions/BlockLabel.cs

@@ -1,23 +1,14 @@
 namespace HydraScript.Domain.BackEnd.Impl.Instructions;
 
-public abstract class BlockLabel : Instruction
+public abstract class BlockLabel(
+    BlockLabel.BlockPosition blockPosition,
+    BlockType blockType,
+    string blockId) : Instruction
 {
-    private readonly BlockPosition _blockPosition;
-    private readonly BlockType _blockType;
-    private readonly string _blockId;
-
-    protected BlockLabel(BlockPosition blockPosition, BlockType blockType, string blockId)
-    {
-        _blockPosition = blockPosition;
-        _blockType = blockType;
-        _blockId = blockId;
-    }
-
-    public override IAddress Execute(IExecuteParams executeParams) =>
-        Address.Next;
+    public override IAddress? Execute(IExecuteParams executeParams) => Address.Next;
 
     protected override string ToStringInternal() =>
-        $"{_blockPosition}{_blockType} {_blockId}";
+        $"{blockPosition}{blockType} {blockId}";
 
     protected enum BlockPosition
     {
@@ -33,14 +24,8 @@ public enum BlockType
     Condition
 }
 
-public class BeginBlock : BlockLabel
-{
-    public BeginBlock(BlockType blockType, string blockId) :
-        base(BlockPosition.Begin, blockType, blockId) { }
-}
+public class BeginBlock(BlockType blockType, string blockId) :
+    BlockLabel(BlockPosition.Begin, blockType, blockId);
 
-public class EndBlock : BlockLabel
-{
-    public EndBlock(BlockType blockType, string blockId) :
-        base(BlockPosition.End, blockType, blockId) { }
-}
+public class EndBlock(BlockType blockType, string blockId) :
+    BlockLabel(BlockPosition.End, blockType, blockId);