#191 - csharp-14 null prop assignment

Author: Stepami

src/Domain/HydraScript.Domain.BackEnd/AddressedInstructions.cs

@@ -43,8 +43,7 @@ public void Replace(IExecutableInstruction old, IExecutableInstruction @new)
     private void AddWithAddress(IExecutableInstruction instruction, IAddress newAddress)
     {
         var last = _addresses.Last;
-        if (last is not null)
-            last.Value.Next = newAddress;
+        last?.Value.Next = newAddress;
 
         var newNode = _addresses.AddLast(newAddress);
 
@@ -66,10 +65,7 @@ public void Remove(IExecutableInstruction instruction)
         var nodeToRemove = _addressToNode[address];
 
         var prev = nodeToRemove.Previous;
-        if (prev is not null)
-        {
-            prev.Value.Next = nodeToRemove.Next?.Value!;
-        }
+        prev?.Value.Next = nodeToRemove.Next?.Value!;
 
         _addressToNode.Remove(address);
         _instructions.Remove(nodeToRemove);

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/AssignmentExpression.cs

@@ -31,8 +31,7 @@ public AssignmentExpression(
     public override void InitScope(Scope? scope = null)
     {
         base.InitScope(scope);
-        if (DestinationType is not null)
-            DestinationType.Scope = Scope;
+        DestinationType?.Scope = Scope;
     }
 
     protected override string NodeRepresentation() => "=";

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/MemberExpression.cs

@@ -28,10 +28,7 @@ public MemberExpression(
         AccessExpression? tail) : this(identifierReference)
     {
         AccessChain = accessChain;
-        if (AccessChain is not null)
-        {
-            AccessChain.Parent = this;
-        }
+        AccessChain?.Parent = this;
 
         Tail = tail;
     }

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Statements/IfStatement.cs

@@ -17,11 +17,8 @@ public IfStatement(Expression test, Statement then, Statement? @else = null)
         Then = then;
         Then.Parent = this;
 
-        if (@else is not null)
-        {
-            Else = @else;
-            Else.Parent = this;
-        }
+        Else = @else;
+        Else?.Parent = this;
 
         Children = Else is not null ? [Test, Then, Else] : [Test, Then];
     }

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Statements/ReturnStatement.cs

@@ -10,10 +10,7 @@ public partial class ReturnStatement : Statement
     public ReturnStatement(Expression? expression = null)
     {
         Expression = expression;
-        if (Expression is not null)
-        {
-            Expression.Parent = this;
-        }
+        Expression?.Parent = this;
 
         Children = Expression is not null ? [Expression] : [];
     }