reduce allocations

Author: Stepami

benchmarks/Readme.md

@@ -11,5 +11,5 @@ Apple M1 Pro, 1 CPU, 10 logical and 10 physical cores
 ```
 | Method | Job           | Runtime       |     Mean |     Error |    StdDev |      Gen0 |     Gen1 | Allocated |
 |--------|---------------|---------------|---------:|----------:|----------:|----------:|---------:|----------:|
-| Invoke | .NET 9.0      | .NET 9.0      | 9.496 ms | 0.1434 ms | 0.1341 ms | 1625.0000 | 546.8750 |   9.79 MB |
-| Invoke | NativeAOT 9.0 | NativeAOT 9.0 | 7.418 ms | 0.0217 ms | 0.0203 ms | 1632.8125 | 453.1250 |   9.78 MB |
+| Invoke | .NET 9.0      | .NET 9.0      | 7.427 ms | 0.1477 ms | 0.1701 ms | 1593.7500 | 406.2500 |   9.57 MB |
+| Invoke | NativeAOT 9.0 | NativeAOT 9.0 | 7.215 ms | 0.0836 ms | 0.0699 ms | 1593.7500 | 453.1250 |   9.56 MB |

src/Application/HydraScript.Application.CodeGeneration/Visitors/InstructionProvider.cs

@@ -11,7 +11,6 @@
 using HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Expressions.PrimaryExpressions;
 using HydraScript.Domain.FrontEnd.Parser.Impl.Ast.Nodes.Statements;
 using Microsoft.Extensions.DependencyInjection;
-using ZLinq;
 
 namespace HydraScript.Application.CodeGeneration.Visitors;
 
@@ -169,9 +168,9 @@ public AddressedInstructions Visit(WhileStatement visitable)
         }
 
         result.AddRange(visitable.Statement.Accept(This));
-        result.AsValueEnumerable()
-            .OfType<Goto>().Where(g => g.JumpType is not null)
-            .ToList().ForEach(g =>
+        for (var address = result.Start; address != null; address = address?.Next)
+        {
+            if (result[address] is Goto { JumpType: not null } g)
             {
                 // ReSharper disable once SwitchStatementHandlesSomeKnownEnumValuesWithDefault
                 switch (g.JumpType)
@@ -183,7 +182,8 @@ public AddressedInstructions Visit(WhileStatement visitable)
                         g.SetJump(startBlockLabel);
                         break;
                 }
-            });
+            }
+        }
         result.Add(new Goto(startBlockLabel));
 
         result.Add(new EndBlock(BlockType.Loop, blockId), endBlockLabel.Name);
@@ -222,9 +222,11 @@ public AddressedInstructions Visit(IfStatement visitable)
         if (visitable.HasElseBlock())
             result.AddRange(visitable.Else?.Accept(This) ?? []);
 
-        result.AsValueEnumerable()
-            .OfType<Goto>().Where(g => g.JumpType is InsideStatementJumpType.Break)
-            .ToList().ForEach(g => g.SetJump(endBlockLabel));
+        for (var address = result.Start; address != null; address = address?.Next)
+        {
+            if (result[address] is Goto { JumpType: InsideStatementJumpType.Break } g)
+                g.SetJump(endBlockLabel);
+        }
 
         result.Add(new EndBlock(BlockType.Condition, blockId), endBlockLabel.Name);
 

src/Application/HydraScript.Application.StaticAnalysis/Impl/FunctionWithUndefinedReturnStorage.cs

@@ -21,11 +21,13 @@ public FunctionDeclaration Get(FunctionSymbol symbol)
 
     public void RemoveIfPresent(FunctionSymbol symbol) => _declarations.Remove(symbol.Id);
 
-    public IEnumerable<FunctionDeclaration> Flush() => _declarations.Keys.ToList()
-        .Select(x =>
+    public IEnumerable<FunctionDeclaration> Flush()
+    {
+        IReadOnlyList<FunctionSymbolId> keys = _declarations.Keys;
+        while (keys.Count > 0)
         {
-            var decl = _declarations[x];
-            _declarations.Remove(x);
-            return decl;
-        });
+            yield return _declarations[keys[0]];
+            _declarations.Remove(keys[0]);
+        }
+    }
 }

src/Application/HydraScript.Application.StaticAnalysis/Visitors/SemanticChecker.cs

@@ -256,7 +256,7 @@ public Type Visit(BinaryExpression visitable)
             "++" when lType is ArrayType { Type: Any } && rType is ArrayType { Type: Any } =>
                 throw new CannotDefineType(visitable.Segment),
             "++" => lType is ArrayType lArrType && rType is ArrayType rArrType
-                ? new List<ArrayType> { lArrType, rArrType }.First(x => x.Type is not Any)
+                ? lArrType.Type is Any ? rArrType.Type : lArrType.Type
                 : throw new UnsupportedOperation(visitable.Segment, lType, visitable.Operator),
             "::" when lType is not ArrayType =>
                 throw new UnsupportedOperation(visitable.Segment, lType, visitable.Operator),
@@ -464,7 +464,7 @@ public Type Visit(CallExpression visitable)
 
     public Type Visit(FunctionDeclaration visitable)
     {
-        var parameters = visitable.Arguments.Select(x => x.TypeValue.Accept(_typeBuilder)).ToList();
+        var parameters = visitable.Arguments.Select(x => x.TypeValue.Accept(_typeBuilder));
         var symbol = _symbolTables[visitable.Scope].FindSymbol(new FunctionSymbolId(visitable.Name, parameters))!;
         _functionStorage.RemoveIfPresent(symbol);
         visitable.Statements.Accept(This);

src/Domain/HydraScript.Domain.BackEnd/AddressedInstructions.cs

@@ -54,7 +54,6 @@ private void AddWithAddress(IExecutableInstruction instruction, IAddress newAddr
 
     public void AddRange(AddressedInstructions instructions)
     {
-        // ReSharper disable once ConstantConditionalAccessQualifier
         for (var address = instructions.Start; address != null; address = address?.Next)
         {
             AddWithAddress(instructions[address], address);

src/Domain/HydraScript.Domain.BackEnd/Impl/Instructions/WithAssignment/ComplexData/Create/CreateArray.cs

@@ -7,7 +7,10 @@ public class CreateArray(string id, int size) : Simple(id)
     public override IAddress Execute(IExecuteParams executeParams)
     {
         var frame = executeParams.Frames.Peek();
-        frame[_id] = new object[size].ToList();
+        var list = new List<object>(size * 2);
+        for (var i = 0; i < size; i++)
+            list.Add(null!);
+        frame[_id] = list;
         return Address.Next;
     }
 

src/Domain/HydraScript.Domain.FrontEnd/Lexer/Impl/TextCoordinateSystemComputer.cs

@@ -27,7 +27,7 @@ public IReadOnlyList<int> GetLines(string text)
             indices.Add(start + index);
         }
 
-        return indices.ToList();
+        return indices;
     }
 
     /// <inheritdoc/>

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Declarations/TypeValue.cs

@@ -36,8 +36,7 @@ public override string ToString() =>
 }
 
 [AutoVisitable<TypeValue>]
-public partial record ObjectTypeValue(
-    IEnumerable<PropertyTypeValue> Properties) : TypeValue
+public partial record ObjectTypeValue(List<PropertyTypeValue> Properties) : TypeValue
 {
     public override string ToString() =>
         $"{{{ZString.Join(';', Properties)}}}";

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/CallExpression.cs

@@ -18,12 +18,12 @@ public partial class CallExpression : LeftHandSideExpression
 
     public string ComputedFunctionAddress { get; set; } = default!;
 
-    public CallExpression(MemberExpression member, IEnumerable<Expression> expressions)
+    public CallExpression(MemberExpression member, List<Expression> expressions)
     {
         Member = member;
         Member.Parent = this;
 
-        _parameters = new List<Expression>(expressions);
+        _parameters = expressions;
         _parameters.ForEach(expr => expr.Parent = this);
     }
 

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Expressions/ComplexLiterals/ArrayLiteral.cs

@@ -10,9 +10,9 @@ public partial class ArrayLiteral : ComplexLiteral
 
     public IReadOnlyList<Expression> Expressions => _expressions;
 
-    public ArrayLiteral(IEnumerable<Expression> expressions)
+    public ArrayLiteral(List<Expression> expressions)
     {
-        _expressions = new List<Expression>(expressions);
+        _expressions = expressions;
         _expressions.ForEach(expr => expr.Parent = this);
     }