#54 - move AllCodePathsEndedWithReturn from FunctionSymbol to FunctionDeclaration

Author: Stepami

src/Application/HydraScript.Application.StaticAnalysis/Visitors/DeclarationVisitor.cs

@@ -76,6 +76,7 @@ public VisitUnit Visit(FunctionDeclaration visitable)
     {
         var returnAnalyzerResult = visitable.Accept(_returnAnalyzer);
         visitable.ReturnStatements = returnAnalyzerResult.ReturnStatements;
+        visitable.AllCodePathsEndedWithReturn = returnAnalyzerResult.CodePathEndedWithReturn;
 
         var parentTable = _symbolTables[visitable.Parent.Scope];
         var indexOfFirstDefaultArgument = visitable.Arguments.AsValueEnumerable()
@@ -94,8 +95,7 @@ public VisitUnit Visit(FunctionDeclaration visitable)
             visitable.Name,
             parameters,
             visitable.ReturnTypeValue.Accept(_typeBuilder),
-            visitable.IsEmpty,
-            returnAnalyzerResult.CodePathEndedWithReturn);
+            visitable.IsEmpty);
         if (functionSymbolId.Equals(parentTable.FindSymbol(functionSymbolId)?.Id))
             throw new OverloadAlreadyExists(visitable.Name, functionSymbolId);
 

src/Application/HydraScript.Application.StaticAnalysis/Visitors/SemanticChecker.cs

@@ -510,7 +510,7 @@ public Type Visit(FunctionDeclaration visitable)
             symbol.DefineReturnType(returnTypes.Single());
 
         Type @void = "void";
-        if (!symbol.Type.Equals(@void) && !symbol.AllCodePathsEndedWithReturn)
+        if (!symbol.Type.Equals(@void) && !visitable.AllCodePathsEndedWithReturn)
             throw new FunctionWithoutReturnStatement(visitable.Segment);
 
         if (symbol.Type is NullType)

src/Domain/HydraScript.Domain.FrontEnd/Parser/Impl/Ast/Nodes/Declarations/AfterTypesAreLoaded/FunctionDeclaration.cs

@@ -20,6 +20,7 @@ public partial class FunctionDeclaration : AfterTypesAreLoadedDeclaration
 
     public IReadOnlyList<ReturnStatement> ReturnStatements { get; set; } = [];
     public bool HasReturnStatement => ReturnStatements.Count > 0;
+    public bool AllCodePathsEndedWithReturn { get; set; }
 
     public string ComputedFunctionAddress { get; set; } = string.Empty;
 

src/Domain/HydraScript.Domain.IR/Impl/Symbols/FunctionSymbol.cs

@@ -8,8 +8,7 @@ public class FunctionSymbol(
     string name,
     IReadOnlyList<ISymbol> parameters,
     Type type,
-    bool isEmpty,
-    bool allCodePathsEndedWithReturn) : Symbol(name, type)
+    bool isEmpty) : Symbol(name, type)
 {
     private Type _returnType = type;
     /// <summary>Тип возврата функции</summary>
@@ -22,7 +21,6 @@ public class FunctionSymbol(
 
     public IReadOnlyList<ISymbol> Parameters { get; } = parameters;
     public bool IsEmpty { get; } = isEmpty;
-    public bool AllCodePathsEndedWithReturn { get; } = allCodePathsEndedWithReturn;
 
     public void DefineReturnType(Type returnType) =>
         _returnType = returnType;

tests/HydraScript.UnitTests/Application/FunctionWithUndefinedReturnStorageTests.cs

@@ -21,8 +21,7 @@ public void StorageIsEmptyAfterFlushTest()
             name: FunctionName,
             parameters: [],
             "undefined",
-            isEmpty: false,
-            allCodePathsEndedWithReturn: false);
+            isEmpty: false);
 
         var decl = new FunctionDeclaration(
             name: new IdentifierReference(FunctionName),
@@ -71,31 +70,27 @@ public void StorageIsCorrectOrderTest()
             name: "key2",
             parameters: [],
             "undefined",
-            isEmpty: false,
-            allCodePathsEndedWithReturn: false);
+            isEmpty: false);
 
         storage.Save(new FunctionSymbol(
             name: "key1",
             parameters: [],
             "undefined",
-            isEmpty: false,
-            allCodePathsEndedWithReturn: false), declaration: declarations[0]);
+            isEmpty: false), declaration: declarations[0]);
 
         storage.Save(removable, declaration: declarations[1]);
 
         storage.Save(new FunctionSymbol(
             name: "key3",
             parameters: [],
             "undefined",
-            isEmpty: false,
-            allCodePathsEndedWithReturn: false), declaration: declarations[2]);
+            isEmpty: false), declaration: declarations[2]);
 
         storage.Save(new FunctionSymbol(
             name: "key4",
             parameters: [],
             "undefined",
-            isEmpty: false,
-            allCodePathsEndedWithReturn: false), declaration: declarations[3]);
+            isEmpty: false), declaration: declarations[3]);
 
         storage.RemoveIfPresent(removable);