#61 - Symbol ctor param id -> name

Author: Stepami

src/Application/HydraScript.Application.StaticAnalysis/Visitors/DeclarationVisitor.cs

@@ -72,7 +72,7 @@ public VisitUnit Visit(FunctionDeclaration visitable)
         var parameters = visitable.Arguments.Select(x =>
         {
             var arg = new VariableSymbol(
-                id: x.Key,
+                name: x.Key,
                 x.TypeValue.Accept(_typeBuilder));
             arg.Initialize();
             _symbolTables[visitable.Scope].AddSymbol(arg);

src/Domain/HydraScript.Domain.IR/Impl/Symbols/FunctionSymbol.cs

@@ -3,10 +3,10 @@
 namespace HydraScript.Domain.IR.Impl.Symbols;
 
 public class FunctionSymbol(
-    string id,
+    string name,
     IEnumerable<ISymbol> parameters,
     Type type,
-    bool isEmpty) : Symbol(id, type)
+    bool isEmpty) : Symbol(name, type)
 {
     private Type _returnType = type;
     /// <summary>Тип возврата функции</summary>

src/Domain/HydraScript.Domain.IR/Impl/Symbols/ObjectSymbol.cs

@@ -3,9 +3,9 @@
 namespace HydraScript.Domain.IR.Impl.Symbols;
 
 public class ObjectSymbol(
-    string id,
+    string name,
     ObjectType objectType,
-    bool readOnly = false) : VariableSymbol(id, objectType, readOnly)
+    bool readOnly = false) : VariableSymbol(name, objectType, readOnly)
 {
     public override ObjectType Type { get; } = objectType;
 }

src/Domain/HydraScript.Domain.IR/Impl/Symbols/Symbol.cs

@@ -1,7 +1,7 @@
 namespace HydraScript.Domain.IR.Impl.Symbols;
 
-public abstract class Symbol(string id, Type type) : ISymbol
+public abstract class Symbol(string name, Type type) : ISymbol
 {
-    public virtual string Id { get; } = id;
+    public virtual string Id { get; } = name;
     public virtual Type Type { get; } = type;
 }

src/Domain/HydraScript.Domain.IR/Impl/Symbols/VariableSymbol.cs

@@ -1,9 +1,9 @@
 namespace HydraScript.Domain.IR.Impl.Symbols;
 
 public class VariableSymbol(
-    string id,
+    string name,
     Type type,
-    bool readOnly = false) : Symbol(id, type)
+    bool readOnly = false) : Symbol(name, type)
 {
     public bool ReadOnly { get; } = readOnly;
     public bool Initialized { get; private set; } = readOnly;

tests/HydraScript.UnitTests/Application/FunctionWithUndefinedReturnStorageTests.cs

@@ -18,7 +18,7 @@ public void StorageIsEmptyAfterFlushTest()
         IFunctionWithUndefinedReturnStorage storage = new FunctionWithUndefinedReturnStorage();
 
         var symbol = new FunctionSymbol(
-            id: FunctionName,
+            name: FunctionName,
             parameters: [],
             "undefined",
             isEmpty: false);
@@ -68,27 +68,27 @@ public void StorageIsCorrectOrderTest()
         IFunctionWithUndefinedReturnStorage storage = new FunctionWithUndefinedReturnStorage();
 
         var removable = new FunctionSymbol(
-            id: "key2",
+            name: "key2",
             parameters: [],
             "undefined",
             isEmpty: false);
 
         storage.Save(new FunctionSymbol(
-            id: "key1",
+            name: "key1",
             parameters: [],
             "undefined",
             isEmpty: false), declaration: declarations[0]);
 
         storage.Save(removable, declaration: declarations[1]);
 
         storage.Save(new FunctionSymbol(
-            id: "key3",
+            name: "key3",
             parameters: [],
             "undefined",
             isEmpty: false), declaration: declarations[2]);
 
         storage.Save(new FunctionSymbol(
-            id: "key4",
+            name: "key4",
             parameters: [],
             "undefined",
             isEmpty: false), declaration: declarations[3]);