type decl fix

Author: Stepami

src/Application/HydraScript.Application.StaticAnalysis/Impl/DefaultValueForTypeCalculator.cs

@@ -4,25 +4,19 @@ namespace HydraScript.Application.StaticAnalysis.Impl;
 
 internal class DefaultValueForTypeCalculator : IDefaultValueForTypeCalculator
 {
-    private readonly Type _boolean = "boolean";
-    private readonly Type _number = "number";
-    private readonly Type _string = "string";
-    private readonly Type _void = "void";
-    private readonly Type _null = new NullType();
-
     public object? GetDefaultValueForType(Type type)
     {
         if (type is NullableType)
             return null;
-        if (type.Equals(_boolean))
+        if (type.Equals("boolean"))
             return false;
-        if (type.Equals(_number))
+        if (type.Equals("number"))
             return 0;
-        if (type.Equals(_string))
+        if (type.Equals("string"))
             return string.Empty;
-        if (type.Equals(_void))
+        if (type.Equals("void"))
             return new object();
-        if (type.Equals(_null))
+        if (type.Equals(new NullType()))
             return null;
         if (type is ArrayType)
             return new List<object>();

src/Application/HydraScript.Application.StaticAnalysis/Visitors/DeclarationVisitor.cs

@@ -101,8 +101,7 @@ public VisitUnit Visit(FunctionDeclaration visitable)
         if (parameters is [ObjectType methodOwner, ..] && visitable.Arguments is [{ TypeValue: TypeIdentValue }, ..])
             _methodStorage.BindMethod(methodOwner, functionSymbol, functionSymbolId);
 
-        Type undefined = "undefined";
-        if (functionSymbol.Type.Equals(undefined))
+        if (functionSymbol.Type.Equals("undefined"))
         {
             if (visitable.HasReturnStatement)
                 _functionStorage.Save(functionSymbol, visitable);

src/Application/HydraScript.Application.StaticAnalysis/Visitors/SemanticChecker.cs

@@ -95,8 +95,7 @@ public Type Visit(ScriptBody visitable)
     public Type Visit(WhileStatement visitable)
     {
         var condType = visitable.Condition.Accept(This);
-        Type boolean = "boolean";
-        if (!condType.Equals(boolean))
+        if (!condType.Equals("boolean"))
             throw new NotBooleanTestExpression(visitable.Segment, condType);
 
         visitable.Statement.Accept(This);
@@ -107,8 +106,7 @@ public Type Visit(WhileStatement visitable)
     public Type Visit(IfStatement visitable)
     {
         var testType = visitable.Test.Accept(This);
-        Type boolean = "boolean";
-        if (!testType.Equals(boolean))
+        if (!testType.Equals("boolean"))
             throw new NotBooleanTestExpression(visitable.Segment, testType);
 
         visitable.Then.Accept(This);
@@ -219,8 +217,7 @@ public ObjectType Visit(ObjectLiteral visitable)
     public Type Visit(ConditionalExpression visitable)
     {
         var tType = visitable.Test.Accept(This);
-        Type boolean = "boolean";
-        if (!tType.Equals(boolean))
+        if (!tType.Equals("boolean"))
             throw new NotBooleanTestExpression(visitable.Test.Segment, tType);
 
         var cType = visitable.Consequent.Accept(This);
@@ -296,7 +293,7 @@ public Type Visit(UnaryExpression visitable)
 
     public Type Visit(LexicalDeclaration visitable)
     {
-        Type undefined = "undefined", @void = "void";
+        Type undefined = "undefined";
 
         for (var i = 0; i < visitable.Assignments.Count; i++)
         {
@@ -306,7 +303,7 @@ public Type Visit(LexicalDeclaration visitable)
 
             if (sourceType.Equals(undefined))
                 throw new CannotDefineType(assignment.Source.Segment);
-            if (sourceType.Equals(@void))
+            if (sourceType.Equals("void"))
                 throw new CannotAssignVoid(assignment.Source.Segment);
             if (!registeredSymbol.Type.Equals(undefined) && !registeredSymbol.Type.Equals(sourceType))
                 throw new IncompatibleTypesOfOperands(
@@ -384,9 +381,8 @@ public Type Visit(IndexAccess visitable)
         if (prevType is not ArrayType arrayType)
             throw new NonAccessibleType(prevType);
 
-        Type number = "number";
         var indexType = visitable.Index.Accept(This);
-        if (!indexType.Equals(number))
+        if (!indexType.Equals("number"))
             throw new ArrayAccessException(visitable.Segment, indexType);
 
         var elemType = arrayType.Type;
@@ -437,10 +433,9 @@ public ObjectType Visit(WithExpression visitable)
 
     public Type Visit(CastAsExpression visitable)
     {
-        Type undefined = "undefined";
         var from = visitable.Expression.Accept(This);
 
-        if (from.Equals(undefined))
+        if (from.Equals("undefined"))
             throw new CannotDefineType(visitable.Expression.Segment);
 
         var to = visitable.Cast.Accept(_typeBuilder);
@@ -495,8 +490,7 @@ public Type Visit(CallExpression visitable)
                     throw new WrongTypeOfArgument(expr.Segment, expectedType, actualType);
             });
 
-        Type undefined = "undefined";
-        if (functionSymbol.Type.Equals(undefined))
+        if (functionSymbol.Type.Equals("undefined"))
         {
             var declaration = _functionStorage.Get(functionSymbol);
             functionReturnType = declaration.Accept(This);