implement getNominalsOfContinuousStates

Author: StephenSmith25

README.md

@@ -19,13 +19,6 @@ We currently support both the Model exchange and Cosimulation Interfaces.
 
 For both interfaces event mode is not supported.
 
-We currently do not support the following methods (beyond a default, trivial implementation)
-
-- fmi3UpdateDiscreteStates
-- fmi3GetNumberOfEventindicators
-- fmi3GetNominalsOfContinuousStates
-- fmi3EvaluateDiscreteStates
-
 ### How do I build an FMU from python code?
 
 1. Install `pythonfmu3` package:

examples/counter.py

@@ -29,4 +29,6 @@ def get_continuous_state_derivatives(self) -> List[float]:
         self.derx0 = self.x1
         self.derx1 = self.mu * ((1 - self.x0**2) * self.x1) - self.x0
         return [self.derx0, self.derx1]
-       
+       
+    def get_nominals_of_continuous_states(self, nStates: int) -> List[float]:
+        return [1.0, 1.0]

examples/runner.py

@@ -45,4 +45,8 @@ def get_event_indicators(self):
 
     def update_discrete_states(self):
         """Update the discrete states of the model."""
-        return Fmi3UpdateDiscreteStatesResult()
+        return Fmi3UpdateDiscreteStatesResult()
+
+    def get_nominals_of_continuous_states(self, size: int) -> list[float]:
+        """Return the nominal values of the continuous states."""
+        return [1.0] * size

examples/vanderpol_me.py

@@ -567,9 +567,20 @@ void PySlaveInstance::GetContinuousStateDerivatives(cppfmu::FMIFloat64* continuo
 
 void PySlaveInstance::GetNominalsOfContinuousStates(cppfmu::FMIFloat64* nominalsOfContinuousStates, std::size_t nStates) const
 {
-    for (size_t i = 0u; i < nStates; i++) {
-        nominalsOfContinuousStates[i] = 1.0;
-    }
+    py_safe_run([this, &nominalsOfContinuousStates, nStates](PyGILState_STATE gilState) {
+        auto f = PyObject_CallMethod(pInstance_, "get_nominals_of_continuous_states", "(i)", static_cast<int>(nStates));
+         // Check if f is a valid object
+         if (f == nullptr) {
+            handle_py_exception("[getNominalContinuousStates] PyObject_CallMethod", gilState);
+        }
+        // Assuming f is a list of floats
+        for (std::size_t i = 0; i < nStates; i++) {
+            PyObject* item = PyList_GetItem(f, i);
+            nominalsOfContinuousStates[i] = static_cast<cppfmu::FMIFloat64>(PyFloat_AsDouble(item));
+        }
+        Py_DECREF(f);
+        clearLogBuffer();
+    });
 }
 
 void PySlaveInstance::SetContinuousStates(const cppfmu::FMIFloat64* continuousStates, std::size_t nStates)