Address yet more review comments

Author: SteveGilham

.github/workflows/main.yml

@@ -14,12 +14,12 @@ jobs:
   windows:
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v5.0.0
       with:
         fetch-depth: 2
     - uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: '9.0.304'
+        global-json-file: global.json
     - name: Tools
       run: dotnet tool restore
     - name: Setup
@@ -36,10 +36,12 @@ jobs:
   linux:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/[email protected]
+      with:
+        fetch-depth: 2
     - uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: '9.0.304'
+        global-json-file: global.json
     - name: Tools
       run: dotnet tool restore
     - name: Setup

Build/targets.fs

@@ -426,7 +426,7 @@ module Targets =
                 test
             with x ->
               printfn "%A" x
-            // reraise()) // while fixing
+              reraise () // argue either way
 
             altReport :: l)
           []

FakeForAltCodeTestBuild.slnx

@@ -7,6 +7,7 @@
     <File Path="Directory.Build.props" />
     <File Path="Directory.Build.targets" />
     <File Path="Directory.Packages.props" />
+    <File Path="fullbuild.ps1" />
     <File Path="global.json" />
     <File Path="OutputBuildProps.props" />
     <File Path="OutputBuildTargets.props" />

altcode.test/altcode.test.nunit/NUnit.fs

@@ -38,7 +38,7 @@ type AltAssert =
     Assert.That(
       x.Actual,
       Is.EqualTo(x.Expected).Within(delta),
-      String.Format(message, args)
+      AltAssertBase.ConvertMessageWithArgs(message, args)
     )
 
   static member AreEqual(x: AssertionMatch<double>, delta) =

altcode.test/altcode.test.slnx

@@ -9,6 +9,7 @@
     <File Path="../Build/targets.fs" />
     <File Path="../Directory.Packages.props" />
     <File Path="../fsharplint.json" />
+    <File Path="../fullbuild.ps1" />
     <File Path="../global.json" />
     <File Path="../README.md" />
     <File Path="../ReleaseNotes.md" />

altcode.test/altcode.test.xunit/XUnit.fs

@@ -92,12 +92,20 @@ type AltAssert =
   static member NotEqual
     (x: AssertionMatch<#IEnumerable<'a>>, comparer: Func<'a, 'a, bool>)
     =
-    Assert.NotEqual<'a>(x.Expected :> IEnumerable<'a>, x.Actual :> IEnumerable<'a>, comparer)
+    Assert.NotEqual<'a>(
+      x.Expected :> IEnumerable<'a>,
+      x.Actual :> IEnumerable<'a>,
+      comparer
+    )
 
   static member NotEqual
     (x: AssertionMatch<#IEnumerable<'a>>, comparer: IEqualityComparer<'a>)
     =
-    Assert.NotEqual<'a>(x.Expected :> IEnumerable<'a>, x.Actual :> IEnumerable<'a>, comparer)
+    Assert.NotEqual<'a>(
+      x.Expected :> IEnumerable<'a>,
+      x.Actual :> IEnumerable<'a>,
+      comparer
+    )
 
   static member NotEqual<'a>(x: AssertionMatch<'a>) =
     Assert.NotEqual<'a>(x.Expected, x.Actual)

fullbuild.ps1

@@ -1,3 +1,7 @@
+Set-StrictMode -Version Latest
+$ErrorActionPreference = 'Stop'
+Set-Location -Path $PSScriptRoot
+
 dotnet tool restore
-dotnet run --project .\Build\Setup.fsproj
-dotnet run --project .\Build\Build.fsproj
+dotnet run --project (Join-Path $PSScriptRoot 'Build/Setup.fsproj')
+dotnet run --project (Join-Path $PSScriptRoot 'Build/Build.fsproj')