Skip to content

Commit 9ba928b

Browse files
Go back to temurin-24
Also add flag to disable --add-module-path for the temurin jlink capability
1 parent a1aaeee commit 9ba928b

File tree

6 files changed

+25
-18
lines changed

6 files changed

+25
-18
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM azul/zulu-openjdk-alpine:24 AS builder
1+
FROM eclipse-temurin:24-alpine AS builder
22

33
# bump: libwebp /LIBWEBP_VERSION=([\d.]+)/ git:https://chromium.googlesource.com/webm/libwebp.git|^1
44
# bump: libwebp after ./hashupdate Dockerfile LIBWEBP $LATEST

build.gradle

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,18 @@ description = 'Telegram bot to convert medias in the format required to be used
4848

4949
java.toolchain {
5050
languageVersion = JavaLanguageVersion.of(24)
51-
vendor = JvmVendorSpec.AZUL
51+
vendor = JvmVendorSpec.ADOPTIUM
5252
}
5353

5454
updateDaemonJvm {
5555
languageVersion = JavaLanguageVersion.of(24)
56-
vendor = JvmVendorSpec.AZUL
56+
vendor = JvmVendorSpec.ADOPTIUM
5757
}
5858

5959
def jlink = tasks.register('jlink', JlinkTask) {
6060
options = ['--strip-debug', '--no-header-files', '--no-man-pages']
6161
modules = ['java.desktop', 'java.instrument', 'java.naming', 'java.sql', 'jdk.crypto.ec', 'jdk.unsupported']
62+
includeModulePath = false
6263

6364
group = 'build'
6465
description = 'Generates a minimal JRE for the project.'
@@ -72,7 +73,7 @@ test {
7273
finalizedBy(jacocoTestReport)
7374

7475
testLogging {
75-
events "passed"
76+
events 'passed'
7677
}
7778
}
7879

buildSrc/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ repositories {
88

99
java.toolchain {
1010
languageVersion = JavaLanguageVersion.of(24)
11-
vendor = JvmVendorSpec.AZUL
11+
vendor = JvmVendorSpec.ADOPTIUM
1212
}

buildSrc/src/main/java/com/github/stickerifier/stickerify/JlinkTask.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ public abstract class JlinkTask extends DefaultTask {
3030
@Input
3131
public abstract ListProperty<@NotNull String> getModules();
3232

33+
@Input
34+
public abstract Property<@NotNull Boolean> getIncludeModulePath();
35+
3336
@OutputDirectory
3437
public abstract DirectoryProperty getOutputDirectory();
3538

@@ -46,6 +49,7 @@ public abstract class JlinkTask extends DefaultTask {
4649
public JlinkTask(ProjectLayout layout, JavaToolchainService javaToolchain) {
4750
getOptions().convention(List.of());
4851
getModules().convention(List.of("ALL-MODULE-PATH"));
52+
getIncludeModulePath().convention(true);
4953
getOutputDirectory().convention(layout.getBuildDirectory().dir("jlink"));
5054

5155
var toolchain = getProject().getExtensions().getByType(JavaPluginExtension.class).getToolchain();
@@ -71,8 +75,10 @@ public void createJre() {
7175
var commandLine = new ArrayList<String>();
7276
commandLine.add(jlink.toString());
7377
commandLine.addAll(getOptions().get());
74-
commandLine.add("--module-path");
75-
commandLine.add(jmods.toString());
78+
if (getIncludeModulePath().get()) {
79+
commandLine.add("--module-path");
80+
commandLine.add(jmods.toString());
81+
}
7682
commandLine.add("--add-modules");
7783
commandLine.add(String.join(",", getModules().get()));
7884
commandLine.add("--output");
Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
#This file is generated by updateDaemonJvm
2-
toolchainUrl.FREE_BSD.AARCH64=https\://api.foojay.io/disco/v3.0/ids/d898567da69cac7b9b75d8d74e577e7a/redirect
3-
toolchainUrl.FREE_BSD.X86_64=https\://api.foojay.io/disco/v3.0/ids/902ef81bafffcd1670604d74b6c7a6b0/redirect
4-
toolchainUrl.LINUX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/d898567da69cac7b9b75d8d74e577e7a/redirect
5-
toolchainUrl.LINUX.X86_64=https\://api.foojay.io/disco/v3.0/ids/902ef81bafffcd1670604d74b6c7a6b0/redirect
6-
toolchainUrl.MAC_OS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/4175090548a4792cf1cef411becfba0f/redirect
7-
toolchainUrl.MAC_OS.X86_64=https\://api.foojay.io/disco/v3.0/ids/50df1a9c218487a6519e22a0d29e6215/redirect
8-
toolchainUrl.UNIX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/d898567da69cac7b9b75d8d74e577e7a/redirect
9-
toolchainUrl.UNIX.X86_64=https\://api.foojay.io/disco/v3.0/ids/902ef81bafffcd1670604d74b6c7a6b0/redirect
10-
toolchainUrl.WINDOWS.X86_64=https\://api.foojay.io/disco/v3.0/ids/f55af862790b0c395d3f70e23016df3d/redirect
11-
toolchainVendor=AZUL
2+
toolchainUrl.FREE_BSD.AARCH64=https\://api.foojay.io/disco/v3.0/ids/6d0adbce30460017fe61d2993dfa663e/redirect
3+
toolchainUrl.FREE_BSD.X86_64=https\://api.foojay.io/disco/v3.0/ids/50f16d2dc2bb80a421afc1af38fc92e3/redirect
4+
toolchainUrl.LINUX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/6d0adbce30460017fe61d2993dfa663e/redirect
5+
toolchainUrl.LINUX.X86_64=https\://api.foojay.io/disco/v3.0/ids/50f16d2dc2bb80a421afc1af38fc92e3/redirect
6+
toolchainUrl.MAC_OS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/4f4ebe4f162f6deb29540c4ebe629d79/redirect
7+
toolchainUrl.MAC_OS.X86_64=https\://api.foojay.io/disco/v3.0/ids/79d5995ef1c3e4df39a3b2f545cada5e/redirect
8+
toolchainUrl.UNIX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/6d0adbce30460017fe61d2993dfa663e/redirect
9+
toolchainUrl.UNIX.X86_64=https\://api.foojay.io/disco/v3.0/ids/50f16d2dc2bb80a421afc1af38fc92e3/redirect
10+
toolchainUrl.WINDOWS.X86_64=https\://api.foojay.io/disco/v3.0/ids/61fdd87038cf8b094dadad8566609a29/redirect
11+
toolchainVendor=ADOPTIUM
1212
toolchainVersion=24

qodana.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ include:
55
- name: VulnerableLibrariesGlobal
66
# bump: qodana /qodana-jvm:([\d.]+)/ docker:jetbrains/qodana-jvm|/^[\d]{4}\.\d+$/|sort
77
linter: jetbrains/qodana-jvm:2025.1
8-
projectJDK: zulu-24
8+
projectJDK: temurin-24

0 commit comments

Comments
 (0)