Fix concurrency error

Author: MartelliEnrico

src/main/java/com/github/stickerifier/stickerify/media/MediaHelper.java

@@ -39,9 +39,7 @@
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.nio.file.Files;
-import java.util.Arrays;
 import java.util.List;
-import java.util.stream.Stream;
 import java.util.zip.GZIPInputStream;
 
 public final class MediaHelper {
@@ -390,8 +388,9 @@ private static MultimediaInfo retrieveMultimediaInfo(File file) throws Corrupted
 	 * @throws MediaException if file conversion is not successful
 	 */
 	private static File convertWithFfmpeg(File file) throws MediaException {
-		var logPrefix = new File(System.getProperty("java.io.tmpdir"), "passlog-" + file.getName()).getAbsolutePath();
-		var baseFfmpegCommand = new String[] {
+		var webmVideo = createTempFile("webm");
+		var logPrefix = webmVideo.getAbsolutePath() + "-passlog";
+		var baseCommand = new String[] {
 				"ffmpeg",
 				"-y",
 				"-v", "error",
@@ -405,27 +404,9 @@ private static File convertWithFfmpeg(File file) throws MediaException {
 				"-passlogfile", logPrefix
 		};
 
-		var pass1Options = new String[] {
-				"-pass", "1",
-				"-f", "webm",
-				IS_WINDOWS ? "NUL" : "/dev/null"
-		};
-
-		try {
-			ProcessHelper.executeCommand(buildFfmpegCommand(baseFfmpegCommand, pass1Options));
-		} catch (ProcessException e) {
-			deleteLogFile(logPrefix);
-			throw new MediaException(e.getMessage());
-		}
-
-		var webmVideo = createTempFile("webm");
-		var pass2Options = new String[] {
-				"-pass", "2",
-				webmVideo.getAbsolutePath()
-		};
-
 		try {
-			ProcessHelper.executeCommand(buildFfmpegCommand(baseFfmpegCommand, pass2Options));
+			ProcessHelper.executeCommand(buildFfmpegCommand(baseCommand, "-pass", "1", "-f", "webm", IS_WINDOWS ? "NUL" : "/dev/null"));
+			ProcessHelper.executeCommand(buildFfmpegCommand(baseCommand, "-pass", "2", webmVideo.getAbsolutePath()));
 		} catch (ProcessException e) {
 			deleteFile(webmVideo);
 			throw new MediaException(e.getMessage());
@@ -443,8 +424,11 @@ private static File convertWithFfmpeg(File file) throws MediaException {
 	 * @param additionalOptions command specific options
 	 * @return the complete ffmpeg invocation command
 	 */
-	private static String[] buildFfmpegCommand(String[] baseCommand, String[] additionalOptions) {
-		return Stream.concat(Arrays.stream(baseCommand), Arrays.stream(additionalOptions)).toArray(String[]::new);
+	private static String[] buildFfmpegCommand(String[] baseCommand, String... additionalOptions) {
+		var commands = new String[baseCommand.length + additionalOptions.length];
+		System.arraycopy(baseCommand, 0, commands, 0, baseCommand.length);
+		System.arraycopy(additionalOptions, 0, commands, baseCommand.length, additionalOptions.length);
+		return commands;
 	}
 
 	/**