Commit 2081985
authored
Remove the Editor deployment admin page at /processor/editor (#7859)
## Description of Changes
Removes the `/processor/editor` **Editor deployment** admin page and the
one button that navigated to it.
The page (`EditorAdmin`) covered deployment targets, instance pairing,
instance health, service-token rotation and offline activation. It was
mock-only — there is no backend behind `GET /v1/editor/deployment`; it
is served solely by MSW. It was reachable from exactly one place: a
**Manage Editor deployment** button in the Infrastructure page header.
It was never in the sidebar, search, or onboarding.
### Removed
- `portal/views/EditorAdmin.tsx` + `EditorAdmin.css`
- All of `portal/components/editor-admin/` — 6 components and their 6
co-located stories
- The route in `portal/ViewRouter.tsx`, and the `"editor"` member of
`ViewId` / `VIEW_PATHS` in `portal/contexts/ViewContext.tsx`
- The **Manage Editor deployment** button in
`portal/views/Infrastructure.tsx`, plus its now-unused `Button` /
`useView` imports
- The 15 `[portal.editorAdmin.*]` tables and
`portal.infrastructure.manageEditorDeployment` from **en-US only** (the
other 41 locales are rebuilt from the reference by the sync workflow)
- The presentation-only constants in `portal/api/editorDeploy.ts`
(`TARGET_META`, `INSTANCE_STATUS_TONE`, `INSTANCE_STATUS_LABEL`,
`TargetMeta`) that had no consumer left and pointed at the deleted i18n
keys, and the matching `ignoredKeyPatterns` entry in
`core/i18n/translationAudit.ts`
With the route gone, `/processor/editor` falls through the portal's
existing catch-all to Home.
### Deliberately kept
`portal/api/editorDeploy.ts`, `useEditorDeployment`, and the MSW mocks
stay. `portal/components/EditorStatusCard.tsx` — the **PDF Editor**
deployment rail on the portal Home hero — still reads them. An in-code
comment claiming onboarding was a third consumer was wrong and has been
corrected.
The mock-only `targets` / `pairings` fields of
`EditorDeploymentResponse` also have no reader now, but reshaping a
documented endpoint contract is a separate decision from removing a
page, so they are left alone here.
## Verification
Ran the app against a live backend and drove the portal with Playwright:
- `/processor/editor` lands on the portal Home with none of the old copy
- Infrastructure renders with no **Manage Editor deployment** button
- The Home hero **PDF Editor** rail still renders — the shared data
layer survived
`task fix` and `task check` both pass: backend spotless + tests,
frontend typecheck (proprietary/saas/portal/storybook/core), oxlint at
`--max-warnings=0`, theme-lint, stylelint, oxfmt, 350 frontend test
files, engine pyright + ruff + 430 tests. Both translation gates are
green, which confirms the en-US key removal was exactly complete — no
orphans, nothing still referenced.
## Checklist
- [x] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md)
- [x] My changes generate no new warnings1 parent 07b9708 commit 2081985
23 files changed
Lines changed: 6 additions & 1293 deletions
File tree
- frontend/editor
- public/locales/en-US
- src
- core/i18n
- portal-saas/views
- portal
- api
- components/editor-admin
- contexts
- queries
- views
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8032 | 8032 | | |
8033 | 8033 | | |
8034 | 8034 | | |
8035 | | - | |
8036 | | - | |
8037 | | - | |
8038 | | - | |
8039 | | - | |
8040 | | - | |
8041 | | - | |
8042 | | - | |
8043 | | - | |
8044 | | - | |
8045 | | - | |
8046 | | - | |
8047 | | - | |
8048 | | - | |
8049 | | - | |
8050 | | - | |
8051 | | - | |
8052 | | - | |
8053 | | - | |
8054 | | - | |
8055 | | - | |
8056 | | - | |
8057 | | - | |
8058 | | - | |
8059 | | - | |
8060 | | - | |
8061 | | - | |
8062 | | - | |
8063 | | - | |
8064 | | - | |
8065 | | - | |
8066 | | - | |
8067 | | - | |
8068 | | - | |
8069 | | - | |
8070 | | - | |
8071 | | - | |
8072 | | - | |
8073 | | - | |
8074 | | - | |
8075 | | - | |
8076 | | - | |
8077 | | - | |
8078 | | - | |
8079 | | - | |
8080 | | - | |
8081 | | - | |
8082 | | - | |
8083 | | - | |
8084 | | - | |
8085 | | - | |
8086 | | - | |
8087 | | - | |
8088 | | - | |
8089 | | - | |
8090 | | - | |
8091 | | - | |
8092 | | - | |
8093 | | - | |
8094 | | - | |
8095 | | - | |
8096 | | - | |
8097 | | - | |
8098 | | - | |
8099 | | - | |
8100 | | - | |
8101 | | - | |
8102 | | - | |
8103 | | - | |
8104 | | - | |
8105 | | - | |
8106 | | - | |
8107 | | - | |
8108 | | - | |
8109 | | - | |
8110 | | - | |
8111 | | - | |
8112 | | - | |
8113 | | - | |
8114 | | - | |
8115 | 8035 | | |
8116 | 8036 | | |
8117 | 8037 | | |
| |||
8249 | 8169 | | |
8250 | 8170 | | |
8251 | 8171 | | |
8252 | | - | |
8253 | 8172 | | |
8254 | 8173 | | |
8255 | 8174 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
102 | 101 | | |
103 | 102 | | |
104 | 103 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 35 | | |
39 | 36 | | |
40 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
79 | 78 | | |
80 | 79 | | |
81 | 80 | | |
82 | | - | |
83 | 81 | | |
84 | 82 | | |
85 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | 117 | | |
150 | 118 | | |
151 | 119 | | |
| |||
Lines changed: 0 additions & 37 deletions
This file was deleted.
Lines changed: 0 additions & 77 deletions
This file was deleted.
Lines changed: 0 additions & 24 deletions
This file was deleted.
Lines changed: 0 additions & 36 deletions
This file was deleted.
0 commit comments