Merge branch 'master' into greenkeeper/react-native-0.52.0

* master: (130 commits)
  fix onChangeOrder/onSaveOrder typo
  shuffle around the types
  prettierify
  fix schema (add button enabled key)
  comment out the facilities form idea
  allow passing a custom message to explain why the tool is disabled
  prettify validate.js
  update <Button/> snapshots
  add pretty-quick and replace prettier:changed with it
  allow passing false to <Card header footer />
  make buttons actually disable when disabled
  extract Button props
  fix too-common [object Object] stuff in validate-data
  fix overzealous catching of errors in validate-data script
  fix accidental duplicate momentjs inclusion
  clean up the flowconfig
  clean up tool code duplication and allow configuring basic tools from schema
  return local copy of help data when offline + no cache, or in dev
  update magical powers of help tool files and write a schema
  allow international phone numbers in _defs#/phone
  ...

# Conflicts:
#	package.json
#	yarn.lock

Author: hawkrives

.circleci/config.yml

@@ -1,61 +1,96 @@
+---
 version: 2
 
 x-config:
-  - &restore-cache-yarn
-      keys:
-        - 'v2-dependencies-{{ checksum "yarn.lock" }}'
-        - 'v2-dependencies-'
-  - &save-cache-yarn
-      paths: [~/.cache/yarn]
-      key: 'v2-dependencies-{{ checksum "yarn.lock" }}'
+  x-caching: # caching instructions
+    - &save-cache-yarn
+      key: 'v3-yarn-dependencies-{{ arch }}-{{ checksum "yarn.lock" }}'
+      paths: [~/.cache/yarn, ~/Library/Caches/Yarn]
+    - &restore-cache-yarn
+      key: 'v3-yarn-dependencies-{{ arch }}-{{ checksum "yarn.lock" }}'
+    - &save-cache-bundler
+      key: 'v2-ruby-dependencies-{{ arch }}-{{ checksum "Gemfile.lock" }}'
+      paths: [./vendor/bundle]
+    - &restore-cache-bundler
+      key: 'v2-ruby-dependencies-{{ arch }}-{{ checksum "Gemfile.lock" }}'
+    - &save-cache-gradle
+      key: 'v1-gradle-dependencies-{{ arch }}-{{ checksum "android/build.gradle" }}-{{ checksum "android/app/build.gradle" }}-{{ checksum "node_modules/react-native/package.json" }}'
+      paths: [~/.gradle]
+    - &restore-cache-gradle
+      key: 'v1-gradle-dependencies-{{ arch }}-{{ checksum "android/build.gradle" }}-{{ checksum "android/app/build.gradle" }}-{{ checksum "node_modules/react-native/package.json" }}'
+  x-commands: # command shorthands
+    - &set-ruby-version
+      name: Set Ruby Version
+      command: echo "ruby-2.4.2" > ~/.ruby-version
+    - &run-danger
+      command: yarn run danger --id $task
+      when: always
 
 workflows:
   version: 2
   analyze:
     jobs:
-      - danger
-      - flow
-      - jest
-      - prettier
-      - eslint
-      - data
+      - cache-yarn-linux
+      - danger: {requires: [cache-yarn-linux]}
+      - flow: {requires: [cache-yarn-linux]}
+      - jest: {requires: [cache-yarn-linux]}
+      - prettier: {requires: [cache-yarn-linux]}
+      - eslint: {requires: [cache-yarn-linux]}
+      - data: {requires: [cache-yarn-linux]}
+      - ios: {requires: [danger, flow, jest, prettier, eslint, data]}
+      - android: {requires: [danger, flow, jest, prettier, eslint, data]}
 
 jobs:
+  cache-yarn-linux:
+    docker: [{image: 'circleci/node:8'}]
+    steps:
+      - checkout
+      - restore_cache: *restore-cache-yarn
+      - run: yarn install --frozen-lockfile
+      - run: yarn --version
+      - save_cache: *save-cache-yarn
+
   danger:
     docker: [{image: 'circleci/node:8'}]
-    environment: {task: JS-general}
+    environment:
+      task: JS-general
     steps:
       - checkout
       - restore_cache: *restore-cache-yarn
-      - run: yarn install
+      - run: yarn install --frozen-lockfile
       - save_cache: *save-cache-yarn
-      - run: yarn run danger --id $task
+      - run: *run-danger
 
   flow:
     docker: [{image: 'circleci/node:8'}]
-    environment: {task: JS-flow}
+    environment:
+      task: JS-flow
     steps:
       - checkout
       - restore_cache: *restore-cache-yarn
-      - run: yarn install
+      - run: yarn install --frozen-lockfile
       - save_cache: *save-cache-yarn
       - run: mkdir -p logs/
       - run: yarn run bundle-data
       - run: yarn run --silent flow check --quiet | tee logs/flow
-      - run: yarn run danger --id $task
+      - run: *run-danger
 
   jest:
     docker: [{image: 'circleci/node:8'}]
-    environment: {task: JS-jest}
+    environment:
+      task: JS-jest
+      JEST_JUNIT_OUTPUT: ./test-results/jest/junit.xml
     steps:
       - checkout
       - restore_cache: *restore-cache-yarn
-      - run: yarn install
+      - run: yarn install --frozen-lockfile
       - save_cache: *save-cache-yarn
-      - run: mkdir -p logs/
+      - run: mkdir -p logs/ test-results/jest/
       - run: yarn run bundle-data
-      - run: yarn run --silent test --coverage 2>&1 | tee logs/jest
-      - run: yarn run danger --id $task
+      - run: yarn run --silent test --coverage --testResultsProcessor="jest-junit" 2>&1 | tee logs/jest
+      - run: *run-danger
+      - store_test_results:
+          path: ./test-results
       - run: yarn global add coveralls
       - run:
           name: coveralls
@@ -67,11 +102,12 @@ jobs:
 
   prettier:
     docker: [{image: 'circleci/node:8'}]
-    environment: {task: JS-prettier}
+    environment:
+      task: JS-prettier
     steps:
       - checkout
       - restore_cache: *restore-cache-yarn
-      - run: yarn install
+      - run: yarn install --frozen-lockfile
       - save_cache: *save-cache-yarn
       - run: mkdir -p logs/
       - run: yarn run prettier
@@ -82,30 +118,89 @@ jobs:
             if ! git diff --quiet *.js source/ scripts/; then
               git diff *.js source/ scripts/ | tee logs/prettier
             fi
-      - run: yarn run danger --id $task
+      - run: *run-danger
 
   eslint:
     docker: [{image: 'circleci/node:8'}]
-    environment: {task: JS-lint}
+    environment:
+      task: JS-lint
     steps:
       - checkout
       - restore_cache: *restore-cache-yarn
-      - run: yarn install
+      - run: yarn install --frozen-lockfile
       - save_cache: *save-cache-yarn
-      - run: mkdir -p logs/
+      - run: mkdir -p logs/ test-results/eslint/
       - run: yarn run bundle-data
       - run: yarn run --silent lint | tee logs/eslint
-      - run: yarn run danger --id $task
+      - run: yarn run --silent lint --format junit > test-results/eslint/junit.xml
+      - run: *run-danger
+      - store_test_results:
+          path: ./test-results
 
   data:
     docker: [{image: 'circleci/node:8'}]
-    environment: {task: JS-data}
+    environment:
+      task: JS-data
     steps:
       - checkout
       - restore_cache: *restore-cache-yarn
-      - run: yarn install
+      - run: yarn install --frozen-lockfile
       - save_cache: *save-cache-yarn
       - run: mkdir -p logs/
       - run: yarn run --silent validate-data --quiet | tee logs/validate-data
       - run: yarn run --silent validate-bus-data | tee logs/validate-bus-data
-      - run: yarn run danger --id $task
+      - run: *run-danger
+
+  android:
+    docker: [{image: 'circleci/android:api-27-node8-alpha'}]
+    environment:
+      task: ANDROID
+      FASTLANE_SKIP_UPDATE_CHECK: '1'
+      FASTLANE_DISABLE_ANIMATION: '1'
+    steps:
+      - checkout
+      - run: yarn --version
+      - run: *set-ruby-version
+      - restore_cache: *restore-cache-yarn
+      - run: yarn install --frozen-lockfile
+      - save_cache: *save-cache-yarn
+      - restore_cache: *restore-cache-bundler
+      - run: bundle check || bundle install --frozen --path ./vendor/bundle
+      - save_cache: *save-cache-bundler
+      - restore_cache: *restore-cache-gradle
+      - run:
+          name: Download Android dependencies
+          command: cd android && ./gradlew androidDependencies
+          environment: {TERM: xterm-256color}
+      - save_cache: *save-cache-gradle
+      - run: mkdir -p logs/
+      - run: touch .env.js
+      - run: bundle exec fastlane android ci-run | tee ./logs/build
+      - run: *run-danger
+
+  ios:
+    macos: {xcode: '9.0'}
+    environment:
+      task: IOS
+      FASTLANE_SKIP_UPDATE_CHECK: '1'
+      FASTLANE_DISABLE_ANIMATION: '1'
+      LC_ALL: en_US.UTF-8
+      LANG: en_US.UTF-8
+    shell: /bin/bash --login -o pipefail
+    steps:
+      - checkout
+      - run: yarn --version
+      - run: *set-ruby-version
+      - restore_cache: *restore-cache-yarn
+      - run: yarn install --frozen-lockfile
+      - save_cache: *save-cache-yarn
+      - restore_cache: *restore-cache-bundler
+      - run: bundle check || bundle install --frozen --path ./vendor/bundle
+      - save_cache: *save-cache-bundler
+      - run: mkdir -p logs/
+      - run: touch .env.js
+      - run: bundle exec fastlane ios ci-run | tee ./logs/build
+      - run:
+          name: Analyze Fastlane Logfile
+          command: python2 ./scripts/analyze-gym.py -s 20 < ./logs/build | tee ./logs/analysis || true
+      - run: *run-danger

.codeclimate.yml

@@ -5,16 +5,9 @@
 ; Ignore "BUCK" generated dirs
 <PROJECT_ROOT>/\.buckd/
 
-; Ignore unexpected extra "@providesModule"
-.*/node_modules/.*/node_modules/fbjs/.*
-
 ; Ignore the vendor/ folder, since CIs appear to stick ruby deps in there
 <PROJECT_ROOT>/vendor/
-
-; Ignore duplicate module providers
-; For RN Apps installed via npm, "Libraries" folder is inside
-; "node_modules/react-native" but in the source repo it is in the root
-.*/Libraries/react-native/React.js
+<PROJECT_ROOT>/.bundle/
 
 ; Ignore polyfills
 .*/Libraries/polyfills/.*

.csslintrc

@@ -0,0 +1,8 @@
+/package.json
+*.md
+*.json
+/flow-typed/
+/node_modules/
+/docs/
+/android/
+/ios/

.flowconfig

@@ -2,18 +2,28 @@ env:
   # To update the secure tokens, run `travis encrypt NAME='VALUE' --add` after
   # installing the travis gem with `gem install travis`.
   global:
-    # `match` keychain info – the values don't matter, they're defined
-    # here so they're consistent throughout
-    - MATCH_KEYCHAIN_NAME=travis-ios-keychain
-    - MATCH_KEYCHAIN_PASSWORD=alpine
-    # dirty hack for https://github.com/travis-ci/travis-ci/issues/5092
-    - PATH=${PATH/\.\/node_modules\/\.bin/}
+    # variables from the web interface:
+    # - BOT_ITC_PASSWORD_FOR_FASTLANE
+    # - BUGSNAG_KEY: api key for Bugsnag connection
+    # - CI_USER_TOKEN: unknown
+    # - DANGER_GITHUB_API_TOKEN: api key to let Danger write comments to github
+    # - FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD: app-specific password for the iTMS Transporter (obselete)
+    # - FASTLANE_PASSWORD: password for apple id used by fastlane
+    # - FASTLANE_SESSION: if fastlane's apple ID has 2fa enabled, this is the 1-month 2fa session cookie
+    # - GCAL_KEY: google calendar API key
+    # - GH_TOKEN: unknown
+    # - GITHUB_PAGES_TOKEN: token to push to gh-pages
+    # - GMAPS_KEY: google maps API key
     # sets our node version in one nice place
     - TRAVIS_NODE_VERSION=8
     # set the ruby version up top
     - TRAVIS_RUBY_VERSION=ruby-2.4.2
-    # GH_TOKEN:
-    # - used by greenkeeper to update package-lock.json
+    # configure fastlane a bit
+    - FASTLANE_SKIP_UPDATE_CHECK=1
+    - FASTLANE_DISABLE_ANIMATION=1
+    # bypass the 2fa auth for fastlane
+    - FASTLANE_PASSWORD="$BOT_ITC_PASSWORD_FOR_FASTLANE"
+    # this is `GH_TOKEN`: used by greenkeeper to update package-lock.json
     - secure: s2HicpDrioxVuS/1KyDMgFkgbM3eVxp1FVF1R922oKeUGhtNFERufXp+nXaG98trqmJhfjfx243i7qP8oEX1DoGtFAHAuILBG0KTXoY1HZG/ZlVpc2pjRQmfCt3tJCs8Trovv2q2yM21JtTKXJ6wZ+XUGK0zqXbd4IH7k30Q649CIZ+l/pcU4cVqoLojekFWMQuW9onPOiTGtBckdPngmJ9GgAGDQesYjZ/p5RTaggCleD4oFmgkUdPZtityr+6TYe6cU9fFIVHyxe5F4JsiXB2aKk0qbX86tXUdlneOTYAw0YsxzVbpjtjVeedG3lm+UDAABznaqyuj4EI2+ERIXEMXtDzG+knQuQIF1P9E5ZWRanuSbfwFRJecPXyw03AtT+lBEHls1klRFep0yYzSKPunuqyeFZG+QFFtiegPnk7C4R2KfJhghB8kr8Ysgwg1YJXP77AaTBET0YsEvhMNNqEGK0LsXhZJUCWUnZfINFwp8ggEB8ZHWqWmTD2SxufqWXCzcMBnNdyuoDAH8//myA/09UcxzRpQwBqy3wH/Nlb47n+RydQxxiSmpTw0xAa5f9/qRjy0DrIT0PowDN1VGLgy6wQIqzAN6Ex4Y7AIyaTZrga7cbpfHE7lKee8XTTfDJnfGywJ1+3CqpZpA1jQhRzeGQbxPfghaOxzI46i4p4=
 
 
@@ -32,7 +42,8 @@ stages:
     if: branch =~ ^greenkeeper\/
   - name: Deploy Data
     if: branch = master AND type != pull_request
-  - name: Build + Deploy App
+  - name: Build + Deploy
+    if: type = cron OR tag IS present
 
 
 #
@@ -42,6 +53,13 @@ stages:
 x-definitions:
   - &base
     before_install:
+      # dirty hack for https://github.com/travis-ci/travis-ci/issues/5092
+      - export PATH="${PATH/\.\/node_modules\/\.bin/}"
+
+      # finish bypassing 2fa auth for fastlane
+      - unset FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD
+      - unset FASTLANE_SESSION
+
       # print some travis debugging info
       - echo "Now testing on $TRAVIS_OS_NAME"
       - echo "Travis branch is $TRAVIS_BRANCH"
@@ -160,6 +178,7 @@ jobs:
       script:
         - bundle exec fastlane ios ci-run | tee ./logs/build
         - python2 ./scripts/analyze-gym.py -s 20 < ./logs/build | tee ./logs/analysis || true
+        - bundle exec fastlane ios refresh_dsyms
 
 cache:
   bundler: true