Skip to content

Commit 07e9f00

Browse files
authored
Merge pull request #1581 from StoDevX/fixup-elapsed-math
Fix elapsed math in delay
2 parents ad34a48 + 10c0f50 commit 07e9f00

File tree

9 files changed

+9
-9
lines changed

9 files changed

+9
-9
lines changed

source/views/calendar/event-detail.android.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export class EventDetail extends React.PureComponent {
128128
this.setState(() => ({message: 'Adding event to calendar…'}))
129129

130130
// wait 0.5 seconds – if we let it go at normal speed, it feels broken.
131-
const elapsed = start - Date.now()
131+
const elapsed = Date.now() - start
132132
if (elapsed < 500) {
133133
await delay(500 - elapsed)
134134
}

source/views/calendar/event-detail.ios.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export class EventDetail extends React.PureComponent {
9696
this.setState(() => ({message: 'Adding event to calendar…'}))
9797

9898
// wait 0.5 seconds – if we let it go at normal speed, it feels broken.
99-
const elapsed = start - Date.now()
99+
const elapsed = Date.now() - start
100100
if (elapsed < 500) {
101101
await delay(500 - elapsed)
102102
}

source/views/news/news-container.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export default class NewsContainer extends React.Component {
7373
await this.fetchData()
7474

7575
// wait 0.5 seconds – if we let it go at normal speed, it feels broken.
76-
let elapsed = start - Date.now()
76+
let elapsed = Date.now() - start
7777
if (elapsed < 500) {
7878
await delay(500 - elapsed)
7979
}

source/views/sis/balances.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class BalancesView extends React.Component {
4747
await this.fetchData()
4848

4949
// wait 0.5 seconds – if we let it go at normal speed, it feels broken.
50-
let elapsed = start - Date.now()
50+
let elapsed = Date.now() - start
5151
await delay(500 - elapsed)
5252

5353
this.setState({loading: false})

source/views/sis/courses.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class CoursesView extends React.PureComponent {
7171
await this.props.updateCourses(true)
7272

7373
// wait 0.5 seconds – if we let it go at normal speed, it feels broken.
74-
let elapsed = start - Date.now()
74+
let elapsed = Date.now() - start
7575
await delay(500 - elapsed)
7676

7777
this.setState({loading: false})

source/views/sis/student-work/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export default class StudentWorkView extends React.PureComponent {
9898
await this.fetchData()
9999

100100
// wait 0.5 seconds – if we let it go at normal speed, it feels broken.
101-
const elapsed = start - Date.now()
101+
const elapsed = Date.now() - start
102102
if (elapsed < 500) {
103103
await delay(500 - elapsed)
104104
}

source/views/student-orgs/list.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ export class StudentOrgsView extends React.Component {
126126
await this.fetchData()
127127

128128
// wait 0.5 seconds – if we let it go at normal speed, it feels broken.
129-
const elapsed = start - Date.now()
129+
const elapsed = Date.now() - start
130130
if (elapsed < 500) {
131131
await delay(500 - elapsed)
132132
}

source/views/transportation/bus/bus-view.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export class BusView extends React.PureComponent {
7474
const start = Date.now()
7575
this.setState(() => ({loading: true}))
7676
this.updateTime()
77-
const elapsed = start - Date.now()
77+
const elapsed = Date.now() - start
7878
if (elapsed < 500) {
7979
await delay(500 - elapsed)
8080
}

source/views/transportation/other-modes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export default class OtherModesView extends React.PureComponent {
8585
}
8686

8787
// wait 0.5 seconds – if we let it go at normal speed, it feels broken.
88-
const elapsed = start - Date.now()
88+
const elapsed = Date.now() - start
8989
if (elapsed < 500) {
9090
await delay(500 - elapsed)
9191
}

0 commit comments

Comments
 (0)