clean up StudentOrgs' "loading" knowledge

hawkrives · hawkrives · commit 0f92b89b6e54 · 2017-09-29T10:04:27.000-05:00
diff --git a/source/views/student-orgs/list.js b/source/views/student-orgs/list.js
@@ -91,7 +91,9 @@ export class StudentOrgsView extends React.Component {
   }
 
   componentWillMount() {
-    this.fetchData()
+    this.fetchData().then(() => {
+      this.setState(() => ({loading: false}))
+    })
   }
 
   fetchData = async () => {
@@ -116,7 +118,7 @@ export class StudentOrgsView extends React.Component {
 
     const sorted = sortBy(withSortableNames, '$sortableName')
     const grouped = groupBy(sorted, '$groupableName')
-    this.setState(() => ({orgs: sorted, results: grouped, loading: false}))
+    this.setState(() => ({orgs: sorted, results: grouped}))
   }
 
   refresh = async () => {

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,9 @@ export class StudentOrgsView extends React.Component {`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`componentWillMount() {`
`94`		`- this.fetchData()`
	`94`	`+ this.fetchData().then(() => {`
	`95`	`+ this.setState(() => ({loading: false}))`
	`96`	`+ })`
`95`	`97`	`}`
`96`	`98`
`97`	`99`	`fetchData = async () => {`
`@@ -116,7 +118,7 @@ export class StudentOrgsView extends React.Component {`
`116`	`118`
`117`	`119`	`const sorted = sortBy(withSortableNames, '$sortableName')`
`118`	`120`	`const grouped = groupBy(sorted, '$groupableName')`
`119`		`- this.setState(() => ({orgs: sorted, results: grouped, loading: false}))`
	`121`	`+ this.setState(() => ({orgs: sorted, results: grouped}))`
`120`	`122`	`}`
`121`	`123`
`122`	`124`	`refresh = async () => {`