Skip to content

Commit 419d379

Browse files
committed
Merge branch 'drew/xcode-15' into drew/react-native-72-4
2 parents 4100cb3 + e70c86e commit 419d379

File tree

4 files changed

+27
-24
lines changed

4 files changed

+27
-24
lines changed

.github/workflows/build-and-deploy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ jobs:
7575

7676
ios:
7777
name: Build for iOS
78-
runs-on: macos-12
78+
runs-on: macos-14
7979
steps:
8080
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
8181
- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3
@@ -86,7 +86,7 @@ jobs:
8686
with:
8787
ruby-version: '3.0'
8888
bundler-cache: true
89-
- run: sudo xcode-select -s /Applications/Xcode_14.2.app
89+
- run: sudo xcode-select -s /Applications/Xcode_15.2.app
9090
- run: git fetch --prune --unshallow
9191
- run: npm ci
9292
env:

.github/workflows/check.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ concurrency:
1111

1212
env:
1313
ruby_version: '3.0'
14-
xcode_version: 'Xcode_14.2'
14+
xcode_version: 'Xcode_15.2'
1515
java_version: '11'
1616
java_distribution: temurin
1717

@@ -50,7 +50,7 @@ jobs:
5050

5151
cache-npm-macos:
5252
name: Cache npm for macOS
53-
runs-on: macos-12
53+
runs-on: macos-14
5454
outputs:
5555
cache-key: ${{ steps.node-cache.outputs.cache-primary-key }}
5656
steps:
@@ -82,7 +82,7 @@ jobs:
8282

8383
cache-bundler-macos:
8484
name: Cache bundler for macOS
85-
runs-on: macos-12
85+
runs-on: macos-14
8686
steps:
8787
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
8888

@@ -94,7 +94,7 @@ jobs:
9494
cache-cocoapods:
9595
name: iOS Cocoapods
9696
needs: [cache-npm-macos, cache-bundler-macos]
97-
runs-on: macos-12
97+
runs-on: macos-14
9898
outputs:
9999
cache-key: ${{ steps.cocoapods-cache.outputs.cache-primary-key }}
100100
steps:
@@ -271,7 +271,7 @@ jobs:
271271
ios-bundle:
272272
name: iOS Bundle
273273
needs: [cache-npm-macos]
274-
runs-on: macos-12
274+
runs-on: macos-14
275275
outputs:
276276
cache-key: ${{ steps.jsbundle-cache.outputs.cache-primary-key }}
277277
steps:
@@ -430,7 +430,7 @@ jobs:
430430
ios-build:
431431
name: Build for iOS
432432
needs: [jest, eslint, cache-cocoapods, cache-npm-macos, cache-bundler-macos]
433-
runs-on: macos-12
433+
runs-on: macos-14
434434
outputs:
435435
cache-key: ${{ steps.app-cache.outputs.cache-primary-key }}
436436
steps:
@@ -493,7 +493,7 @@ jobs:
493493
upload_buildcache_log: 'true'
494494

495495
- name: Build the iOS app
496-
if: steps.app-cache.outputs.cache-hit != 'true'
496+
if: ${{ steps.app-cache.outputs.cache-hit != 'true' && !contains(github.event.pull_request.labels.*.name, 'ci/skip-detox') }}
497497
env:
498498
SKIP_BUNDLING: 'true'
499499
run: npx detox build e2e --configuration ios.sim.release
@@ -512,7 +512,8 @@ jobs:
512512
ios-detox:
513513
name: Detox E2E for iOS
514514
needs: [cache-npm-macos, ios-build, ios-bundle]
515-
runs-on: macos-12
515+
runs-on: macos-14
516+
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci/skip-detox') }}
516517
steps:
517518
- run: sudo xcode-select -s /Applications/${{ env.xcode_version }}.app
518519

.github/workflows/cocoapods.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
ios-podfile-update:
1616
# Adapted from https://gist.github.com/A-Tokyo/0d811e818513fc4d3272335d2847d748
1717
name: iOS Update Cocoapods
18-
runs-on: macos-12
18+
runs-on: macos-14
1919
timeout-minutes: 15
2020
if: github.actor == 'renovate[bot]'
2121
steps:
@@ -33,7 +33,7 @@ jobs:
3333
ruby-version: '3.0'
3434
bundler-cache: true
3535

36-
- run: sudo xcode-select -s /Applications/Xcode_14.2.app
36+
- run: sudo xcode-select -s /Applications/Xcode_15.2.app
3737

3838
- run: npm ci
3939

ios/AllAboutOlaf.xcodeproj/project.pbxproj

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -662,9 +662,7 @@
662662
TestTargetID = 13B07F861A680F5B00A75B9A;
663663
};
664664
13B07F861A680F5B00A75B9A = {
665-
DevelopmentTeam = TMK6S7TPX2;
666665
LastSwiftMigration = 810;
667-
ProvisioningStyle = Manual;
668666
SystemCapabilities = {
669667
com.apple.ApplicationGroups.iOS = {
670668
enabled = 0;
@@ -1311,12 +1309,13 @@
13111309
buildSettings = {
13121310
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
13131311
CLANG_ENABLE_MODULES = YES;
1314-
CODE_SIGN_IDENTITY = "iPhone Developer";
1315-
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Distribution: Hawken Rives (TMK6S7TPX2)";
1312+
CODE_SIGN_IDENTITY = "Apple Development";
1313+
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
13161314
CODE_SIGN_STYLE = Manual;
13171315
DEAD_CODE_STRIPPING = YES;
13181316
DEPLOYMENT_POSTPROCESSING = YES;
1319-
DEVELOPMENT_TEAM = TMK6S7TPX2;
1317+
DEVELOPMENT_TEAM = "";
1318+
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = TMK6S7TPX2;
13201319
ENABLE_TESTABILITY = YES;
13211320
HEADER_SEARCH_PATHS = "$(inherited)";
13221321
INFOPLIST_FILE = AllAboutOlaf/Info.plist;
@@ -1332,7 +1331,8 @@
13321331
PRODUCT_BUNDLE_IDENTIFIER = NFMTHAZVS9.com.drewvolz.stolaf;
13331332
PRODUCT_NAME = AllAboutOlaf;
13341333
PROVISIONING_PROFILE = "1519411d-0c35-4ef5-b2f9-d7524a9f28f3";
1335-
PROVISIONING_PROFILE_SPECIFIER = "match AppStore NFMTHAZVS9.com.drewvolz.stolaf";
1334+
PROVISIONING_PROFILE_SPECIFIER = "";
1335+
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match Development NFMTHAZVS9.com.drewvolz.stolaf";
13361336
STRIPFLAGS = "-rSTx";
13371337
SWIFT_OBJC_BRIDGING_HEADER = "AllAboutOlafUITests/AllAboutOlaf-Bridging-Header.h";
13381338
TARGETED_DEVICE_FAMILY = "1,2";
@@ -1345,11 +1345,12 @@
13451345
buildSettings = {
13461346
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
13471347
CLANG_ENABLE_MODULES = YES;
1348-
CODE_SIGN_IDENTITY = "iPhone Developer";
1349-
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Distribution: Hawken Rives (TMK6S7TPX2)";
1348+
CODE_SIGN_IDENTITY = "Apple Development";
1349+
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
13501350
CODE_SIGN_STYLE = Manual;
13511351
DEPLOYMENT_POSTPROCESSING = YES;
1352-
DEVELOPMENT_TEAM = TMK6S7TPX2;
1352+
DEVELOPMENT_TEAM = "";
1353+
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = TMK6S7TPX2;
13531354
HEADER_SEARCH_PATHS = "$(inherited)";
13541355
INFOPLIST_FILE = AllAboutOlaf/Info.plist;
13551356
LD_RUNPATH_SEARCH_PATHS = (
@@ -1364,7 +1365,8 @@
13641365
PRODUCT_BUNDLE_IDENTIFIER = NFMTHAZVS9.com.drewvolz.stolaf;
13651366
PRODUCT_NAME = AllAboutOlaf;
13661367
PROVISIONING_PROFILE = "3dea0c24-d70a-4b26-b754-f41ac50c2358";
1367-
PROVISIONING_PROFILE_SPECIFIER = "match AppStore NFMTHAZVS9.com.drewvolz.stolaf";
1368+
PROVISIONING_PROFILE_SPECIFIER = "";
1369+
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match AppStore NFMTHAZVS9.com.drewvolz.stolaf";
13681370
STRIPFLAGS = "-rSTx";
13691371
SWIFT_OBJC_BRIDGING_HEADER = "AllAboutOlafUITests/AllAboutOlaf-Bridging-Header.h";
13701372
TARGETED_DEVICE_FAMILY = "1,2";
@@ -1422,7 +1424,7 @@
14221424
GCC_WARN_UNUSED_FUNCTION = YES;
14231425
GCC_WARN_UNUSED_VARIABLE = YES;
14241426
HEADER_SEARCH_PATHS = "$(inherited)";
1425-
IPHONEOS_DEPLOYMENT_TARGET = 16.2;
1427+
IPHONEOS_DEPLOYMENT_TARGET = 17.2;
14261428
MTL_ENABLE_DEBUG_INFO = YES;
14271429
ONLY_ACTIVE_ARCH = YES;
14281430
OTHER_CFLAGS = "$(inherited)";
@@ -1479,7 +1481,7 @@
14791481
GCC_WARN_UNUSED_FUNCTION = YES;
14801482
GCC_WARN_UNUSED_VARIABLE = YES;
14811483
HEADER_SEARCH_PATHS = "$(inherited)";
1482-
IPHONEOS_DEPLOYMENT_TARGET = 16.2;
1484+
IPHONEOS_DEPLOYMENT_TARGET = 17.2;
14831485
MTL_ENABLE_DEBUG_INFO = NO;
14841486
OTHER_CFLAGS = "$(inherited)";
14851487
OTHER_CPLUSPLUSFLAGS = "$(inherited)";

0 commit comments

Comments
 (0)