rename to AppConfigEntry

Author: drewvolz

modules/app-config/__tests__/useCourseSearchRecentsScreen.test.tsx

@@ -4,7 +4,7 @@ import {renderHook, waitFor} from '@testing-library/react-native'
 import {QueryClient, QueryClientProvider} from '@tanstack/react-query'
 
 import {useFeature} from '../index'
-import {AppConfigType} from '../types'
+import {AppConfigEntry} from '../types'
 
 jest.mock('../../../modules/constants', () => ({
 	isDevMode: jest.fn(),
@@ -41,7 +41,7 @@ describe('useCourseSearchRecentsScreen', () => {
 		getFeatureFlagMock.mockReturnValue(true)
 
 		const {result} = renderHook(
-			() => useFeature(AppConfigType.Courses_ShowRecentSearchScreen),
+			() => useFeature(AppConfigEntry.Courses_ShowRecentSearchScreen),
 			{
 				wrapper: queryWrapper,
 			},
@@ -57,7 +57,7 @@ describe('useCourseSearchRecentsScreen', () => {
 		getFeatureFlagMock.mockReturnValue(false)
 
 		const {result} = renderHook(
-			() => useFeature(AppConfigType.Courses_ShowRecentSearchScreen),
+			() => useFeature(AppConfigEntry.Courses_ShowRecentSearchScreen),
 			{
 				wrapper: queryWrapper,
 			},

modules/app-config/index.tsx

@@ -1,12 +1,12 @@
 import {getFeatureFlag} from '../../source/lib/storage'
-import {AppConfigType, FeatureFlagType} from './types'
+import {AppConfigEntry, FeatureFlagType} from './types'
 import {useQuery} from '@tanstack/react-query'
 import {isDevMode} from '@frogpond/constants'
 
-export type {AppConfigType, FeatureFlagType} from './types'
+export type {AppConfigEntry, FeatureFlagType} from './types'
 
 // helper method to query exported __DEV__ feature flags
-export const useFeature = (featureKey: AppConfigType): boolean => {
+export const useFeature = (featureKey: AppConfigEntry): boolean => {
 	let {data: featureValue = false} = useQuery({
 		queryKey: ['app', 'app:feature-flag', featureKey],
 		queryFn: () => getFeatureFlag(featureKey),
@@ -23,14 +23,14 @@ export const AppConfig = async (): Promise<FeatureFlagType[]> => {
 	return [
 		{
 			title: 'Show the course search recents screen',
-			configKey: AppConfigType.Courses_ShowRecentSearchScreen,
+			configKey: AppConfigEntry.Courses_ShowRecentSearchScreen,
 			active: await getFeatureFlag(
-				AppConfigType.Courses_ShowRecentSearchScreen,
+				AppConfigEntry.Courses_ShowRecentSearchScreen,
 			),
 		},
 	]
 }
 
 // exported feature flags
 export const useCourseSearchRecentsScreen = (): boolean =>
-	useFeature(AppConfigType.Courses_ShowRecentSearchScreen)
+	useFeature(AppConfigEntry.Courses_ShowRecentSearchScreen)

modules/app-config/types.ts

@@ -1,5 +1,5 @@
 export interface FeatureFlagType {
-	configKey: AppConfigType
+	configKey: AppConfigEntry
 	title: string
 	active: boolean
 }
@@ -14,6 +14,6 @@ export interface FeatureFlagType {
  * split at render time for our view to group by, but the entirety
  * of the value (section + key) will be stored.
  */
-export enum AppConfigType {
+export enum AppConfigEntry {
 	Courses_ShowRecentSearchScreen = 'Courses_ShowRecentSearchScreen',
 }

source/lib/storage.ts

@@ -6,7 +6,7 @@ import {
 	setItem,
 	setStoragePrefix,
 } from '@frogpond/storage'
-import {AppConfigType} from '@frogpond/app-config'
+import {AppConfigEntry} from '@frogpond/app-config'
 import type {FilterComboType} from '../views/sis/course-search/lib/format-filter-combo'
 import type {CourseType, TermType} from './course-search/types'
 
@@ -18,13 +18,13 @@ setStoragePrefix('aao:')
 
 const featureFlagsKey = 'app:feature-flag'
 export function setFeatureFlag(
-	name: AppConfigType,
+	name: AppConfigEntry,
 	value: boolean,
 ): Promise<void> {
 	const key = `${featureFlagsKey}:${name}`
 	return setItem(key, value)
 }
-export function getFeatureFlag(name: AppConfigType): Promise<boolean> {
+export function getFeatureFlag(name: AppConfigEntry): Promise<boolean> {
 	const key = `${featureFlagsKey}:${name}`
 	return getItemAsBoolean(key)
 }