Skip to content

Commit 51d754f

Browse files
committed
Merge branch 'master' into greenkeeper/danger-3.0.6
2 parents 9f9896b + 737bfdf commit 51d754f

File tree

9 files changed

+59
-43
lines changed

9 files changed

+59
-43
lines changed

.circleci/config.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,10 @@ jobs:
152152
- run: *run-danger
153153

154154
android:
155-
docker: [{image: 'circleci/android:api-27-node8-alpha'}]
155+
# cmd: key is passed to solve a weird issue (see GitHub PR's 2170 and 2173).
156+
# this overrides the thing and forces the container to run /bin/bash as the "command"
157+
# so it doesn't get confused and OOM/exhaust the build resources (don't ask me)
158+
docker: [{image: 'circleci/android:api-27-node8-alpha', cmd: '/bin/bash'}]
156159
environment:
157160
task: ANDROID
158161
FASTLANE_SKIP_UPDATE_CHECK: '1'

android/app/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ android {
111111
}
112112
manifestPlaceholders = [
113113
manifestApplicationId: applicationId,
114-
gmaps_key: System.getenv("GMAPS_KEY") ?: "",
114+
BUGSNAG_KEY: System.getenv("BUGSNAG_KEY") ?: "",
115+
GMAPS_KEY: System.getenv("GMAPS_KEY") ?: "",
115116
]
116117
}
117118
signingConfigs {

android/app/src/main/AndroidManifest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828

2929
<meta-data
3030
android:name="com.bugsnag.android.API_KEY"
31-
android:value="aae3a01c545dfa73bc5f1b2d5d661a3e" />
31+
android:value="${BUGSNAG_KEY}" />
3232
<meta-data
3333
android:name="com.google.android.geo.API_KEY"
34-
android:value="${gmaps_key}" />
34+
android:value="${GMAPS_KEY}" />
3535
</application>
3636

3737
</manifest>

data/building-hours/6-3-storp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ category: Gym
55
schedule:
66
- title: Hours
77
hours:
8-
- {days: [Mo, Th, Fr], from: '4:00pm', to: '6:00pm'}
8+
- {days: [Mo, Fr], from: '4:00pm', to: '6:00pm'}
99

1010
breakSchedule:
1111
fall: []

fastlane/Fastfile

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,39 @@ fastlane_version '2.50.1'
88

99
require 'fileutils'
1010

11-
import 'lib/before_all.rb'
11+
before_all do
12+
case lane_context[:PLATFORM_NAME]
13+
when :ios
14+
setup_circle_ci if circle?
15+
end
16+
17+
# set up global info for `gym`
18+
ENV['GYM_PROJECT'] = './ios/AllAboutOlaf.xcodeproj'
19+
ENV['GYM_SCHEME'] = 'AllAboutOlaf'
20+
ENV['GYM_OUTPUT_DIRECTORY'] = './ios/build'
21+
ENV['GYM_OUTPUT_NAME'] = 'AllAboutOlaf'
22+
23+
# set the testflight itunesconnect provider ID from Appfile
24+
ENV['PILOT_ITC_PROVIDER'] = CredentialsManager::AppfileConfig.try_fetch_value(:team_id)
25+
26+
# set up global info for `gradle`
27+
ENV['FL_GRADLE_PROJECT_DIR'] = './android'
28+
29+
# set up other global shared values
30+
lane_context[:PRETTY_APP_NAME] = 'All About Olaf'
31+
32+
lane_context[:GRADLE_FILE] = "#{ENV['FL_GRADLE_PROJECT_DIR']}/app/build.gradle"
33+
34+
UI.message "GYM_PROJECT is #{ENV['GYM_PROJECT']}"
35+
UI.message "GYM_SCHEME is #{ENV['GYM_SCHEME']}"
36+
UI.message "GYM_OUTPUT_DIRECTORY is #{ENV['GYM_OUTPUT_DIRECTORY']}"
37+
UI.message "GYM_OUTPUT_NAME is #{ENV['GYM_OUTPUT_NAME']}"
38+
UI.message "FL_GRADLE_PROJECT_DIR is #{ENV['FL_GRADLE_PROJECT_DIR']}"
39+
UI.message "PRETTY_APP_NAME is #{lane_context[:PRETTY_APP_NAME]}"
40+
UI.message "GRADLE_FILE is #{lane_context[:GRADLE_FILE]}"
41+
UI.message "PLATFORM_NAME is #{lane_context[:PLATFORM_NAME]}"
42+
end
43+
1244
import 'lib/commands.rb'
1345
import 'lib/git.rb'
1446
import 'lib/sourcemaps.rb'

fastlane/lib/before_all.rb

Lines changed: 0 additions & 33 deletions
This file was deleted.

fastlane/platforms/ios.rb

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,20 @@
6060
lane :build do
6161
match(type: 'appstore', readonly: true)
6262
propagate_version
63-
gym(include_bitcode: true,
64-
include_symbols: true)
63+
64+
# save it to a log file for later use
65+
FileUtils.mkdir_p('../logs')
66+
File.open('../logs/products', 'w') { |file| file.write('[]') }
67+
build_status = 0
68+
begin
69+
gym(include_bitcode: true,
70+
include_symbols: true)
71+
rescue IOError => e
72+
build_status = 1
73+
raise e
74+
ensure
75+
File.open('../logs/build-status', 'w') { |file| file.write(build_status.to_s) }
76+
end
6577
end
6678

6779
desc 'Submit a new Beta Build to Testflight'

ios/AllAboutOlaf.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1771,7 +1771,7 @@
17711771
"$(SRCROOT)/../node_modules/react-native-safari-view",
17721772
"$(SRCROOT)/../node_modules/react-native-custom-tabs/ios/ReactNativeCustomTabs",
17731773
);
1774-
IPHONEOS_DEPLOYMENT_TARGET = 8.3;
1774+
IPHONEOS_DEPLOYMENT_TARGET = 8.2;
17751775
MTL_ENABLE_DEBUG_INFO = YES;
17761776
ONLY_ACTIVE_ARCH = YES;
17771777
SDKROOT = iphoneos;
@@ -1828,7 +1828,7 @@
18281828
"$(SRCROOT)/../node_modules/react-native-safari-view",
18291829
"$(SRCROOT)/../node_modules/react-native-custom-tabs/ios/ReactNativeCustomTabs",
18301830
);
1831-
IPHONEOS_DEPLOYMENT_TARGET = 8.3;
1831+
IPHONEOS_DEPLOYMENT_TARGET = 8.2;
18321832
MTL_ENABLE_DEBUG_INFO = NO;
18331833
SDKROOT = iphoneos;
18341834
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";

source/views/home/edit/row.ios.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@ export class EditHomeRow extends React.Component<Props, State> {
175175
</Text>
176176

177177
<Switch
178+
onTintColor={tint}
178179
onValueChange={this.onToggleSwitch}
179180
value={this.props.isEnabled}
180181
/>

0 commit comments

Comments
 (0)