Merge pull request #1408 from StoDevX/greenkeeper/eslint-plugin-react-7.2.0

Update eslint-plugin-react to the latest version 🚀

Author: hawkrives

.eslintrc.yaml

@@ -43,7 +43,11 @@ rules:
   no-div-regex: error
   no-eq-null: warn
   no-extra-label: error
-  no-implicit-coercion: [error, {boolean: true, number: true, string: true}]
+  no-implicit-coercion:
+    - error
+    - boolean: true
+      number: true
+      string: true
   no-implicit-globals: error
   no-multi-assign: error
   no-new-symbol: error
@@ -53,7 +57,10 @@ rules:
   no-undef-init: off
   no-underscore-dangle: off
   no-unmodified-loop-condition: error
-  no-unused-vars: [warn, {args: 'after-used', argsIgnorePattern: '^_$'}]
+  no-unused-vars:
+    - warn
+    - args: 'after-used'
+      argsIgnorePattern: '^_$'
   no-useless-constructor: error
   no-var: error
   prefer-promise-reject-errors: error
@@ -65,24 +72,35 @@ rules:
   # react rules – https://github.com/yannickcr/eslint-plugin-react
   react/display-name: off
   react/jsx-key: warn
-  react/jsx-no-bind: [warn, {ignoreRefs: true, allowArrowFunctions: true}]
-  react/no-did-mount-set-state: warn
-  react/no-did-update-set-state: warn
+  react/jsx-no-bind:
+    - warn
+    - ignoreRefs: true
+      allowArrowFunctions: true
+  react/jsx-sort-props:
+    - warn
+    - reservedFirst: true
+      ignoreCase: true
+      callbacksLast: true
   react/no-multi-comp: off  # prevent multiple component definition per file
-  react/no-string-refs: error
-  react/no-unescaped-entities: off
-  react/no-unknown-property: warn
+  react/no-redundant-should-component-update: warn
+  react/no-typos: error
   react/prop-types: off
   react/self-closing-comp: warn  # prevent extra closing tags for components without children
-  react/sort-comp: warn
+  react/sort-comp:
+    - warn
+    - order:
+      - static-methods
+      - type-annotations
+      - lifecycle
+      - everything-else
+      - render
   react/sort-prop-types: warn
   react/wrap-multilines: off
+  react/jsx-boolean-value: [error, always]
 
   # flow rules
-  flowtype/define-flow-type: warn
+  flowtype/no-dupe-keys: error
   flowtype/use-flow-type: error
-  flowtype/valid-syntax: error
-  flowtype/no-types-missing-file-annotation: off
 
   # react-native rules
   react-native/no-unused-styles: warn

package-lock.json

@@ -107,7 +107,7 @@
     "eslint-config-prettier": "2.3.0",
     "eslint-plugin-babel": "4.1.2",
     "eslint-plugin-flowtype": "2.35.0",
-    "eslint-plugin-react": "7.1.0",
+    "eslint-plugin-react": "7.2.0",
     "eslint-plugin-react-native": "3.0.1",
     "flow-bin": "0.45.0",
     "jest": "20.0.4",

package.json

@@ -81,12 +81,12 @@ export class SnapshotsView extends React.Component {
     title: 'Snapshot Time',
   }
 
+  _ref: any
+
   state = {
     viewPath: 'streaming.radio',
   }
 
-  _ref: any
-
   views: ViewCollectionType = {
     buildinghours: {
       list: {

source/storybook/index.js

@@ -19,6 +19,10 @@ export class BuildingHoursDetailView extends React.PureComponent {
     }
   }
 
+  props: TopLevelViewPropsType & {
+    navigation: {state: {params: {building: BuildingType}}},
+  }
+
   state: {intervalId: number, now: moment} = {
     intervalId: 0,
     // now: moment.tz('Wed 7:25pm', 'ddd h:mma', null, CENTRAL_TZ),
@@ -35,10 +39,6 @@ export class BuildingHoursDetailView extends React.PureComponent {
     clearTimeout(this.state.intervalId)
   }
 
-  props: TopLevelViewPropsType & {
-    navigation: {state: {params: {building: BuildingType}}},
-  }
-
   updateTime = () => {
     this.setState({now: moment.tz(CENTRAL_TZ)})
   }

source/views/building-hours/detail/index.js

@@ -23,12 +23,6 @@ export class BuildingHoursScheduleEditorView extends React.PureComponent {
     title: 'Edit Schedule',
   }
 
-  state: {
-    set: ?SingleBuildingScheduleType,
-  } = {
-    set: this.props.navigation.state.params.initialSet,
-  }
-
   props: TopLevelViewPropsType & {
     navigation: {
       state: {
@@ -41,6 +35,12 @@ export class BuildingHoursScheduleEditorView extends React.PureComponent {
     },
   }
 
+  state: {
+    set: ?SingleBuildingScheduleType,
+  } = {
+    set: this.props.navigation.state.params.initialSet,
+  }
+
   delete = () => {
     this.props.navigation.state.params.onDeleteSet()
     this.props.navigation.goBack()

source/views/building-hours/report/editor.js

@@ -49,16 +49,16 @@ export class BuildingHoursProblemReportView extends React.PureComponent {
     title: 'Report a Problem',
   }
 
+  props: TopLevelViewPropsType & {
+    navigation: {state: {params: {initialBuilding: BuildingType}}},
+  }
+
   state: {
     building: BuildingType,
   } = {
     building: this.props.navigation.state.params.initialBuilding,
   }
 
-  props: TopLevelViewPropsType & {
-    navigation: {state: {params: {initialBuilding: BuildingType}}},
-  }
-
   openEditor = (
     scheduleIdx: number,
     setIdx: number,

source/views/building-hours/report/overview.js

@@ -32,6 +32,8 @@ export class BuildingHoursView extends React.Component {
     headerBackTitle: 'Hours',
   }
 
+  props: TopLevelViewPropsType
+
   state: {
     error: ?Error,
     loading: boolean,
@@ -59,8 +61,6 @@ export class BuildingHoursView extends React.Component {
     clearTimeout(this.state.intervalId)
   }
 
-  props: TopLevelViewPropsType
-
   updateTime = () => {
     this.setState({now: moment.tz(CENTRAL_TZ)})
   }

source/views/building-hours/stateful-list.js

@@ -18,6 +18,8 @@ import {GOOGLE_CALENDAR_API_KEY} from '../../lib/config'
 const TIMEZONE = 'America/Winnipeg'
 
 export class GoogleCalendarView extends React.Component {
+  props: {calendarId: string} & TopLevelViewPropsType
+
   state: {
     events: EventType[],
     loaded: boolean,
@@ -36,8 +38,6 @@ export class GoogleCalendarView extends React.Component {
     this.refresh()
   }
 
-  props: {calendarId: string} & TopLevelViewPropsType
-
   buildCalendarUrl(calendarId: string) {
     let calendarUrl = `https://www.googleapis.com/calendar/v3/calendars/${calendarId}/events`
     let params = {

source/views/calendar/calendar-google.js

@@ -34,8 +34,8 @@ export class HtmlView extends React.Component {
   render() {
     return (
       <WebView
-        style={this.props.style}
         ref={ref => (this._webview = ref)}
+        style={this.props.style}
         source={{html: this.props.html, baseUrl: this.props.baseUrl}}
         onNavigationStateChange={this.onNavigationStateChange}
       />