rework signingConfig.release to be configured inline

instead of after … some other configuration is completed.

Somehow configuring it here works, while doing the post-configuration version
fails when you actually have a signing file.

And– it fails – by way of saying "project.hasProperty – could not find .hasProperty"

i mean, really, gradle

really

do you gotta do that

Author: hawkrives

android/app/build.gradle

@@ -122,8 +122,32 @@ android {
     }
 
     signingConfigs {
-        // the signingConfig is configured below
-        release
+        String filePath = System.getenv("KEYSTORE_FILE")
+
+        if (filePath == null) {
+            logger.warn "env['KEYSTORE_FILE'] not set"
+            release
+            return
+        } else {
+            logger.warn "env['KEYSTORE_FILE'] = ${filePath}"
+        }
+
+        def propFile = new File(filePath)
+        if (!propFile.canRead()) {
+            logger.warn "${filePath} is not readable"
+            release
+            return
+        }
+
+        def props = new Properties()
+        props.load(new FileInputStream(propFile))
+
+        release {
+            storeFile file(props['STORE_FILE'])
+            storePassword props['STORE_PASSWORD']
+            keyAlias props['KEY_ALIAS']
+            keyPassword props['KEY_PASSWORD']
+        }
     }
 
     splits {
@@ -186,41 +210,6 @@ android {
     }
 }
 
-// borrowed from https://gist.github.com/gabrielemariotti/6856974
-def propFile = new File('android/app/signing.properties')
-if (propFile.canRead()) {
-    Properties props = new Properties()
-    props.load(new FileInputStream(propFile))
-
-    bool hasFile = props != null && props.containsKey('STORE_FILE');
-    bool hasPassword = props != null && props.containsKey('STORE_PASSWORD');
-    bool hasAlias = props != null && props.containsKey('KEY_ALIAS');
-    bool hasKeyPass = props != null && props.containsKey('KEY_PASSWORD');
-
-    if (hasFile && hasPassword && hasAlias && hasKeyPass) {
-        logger.info 'android/app/signing.properties is fully functional.'
-        android.signingConfigs.release.storeFile = file(props['STORE_FILE'])
-        android.signingConfigs.release.storePassword = props['STORE_PASSWORD']
-        android.signingConfigs.release.keyAlias = props['KEY_ALIAS']
-        android.signingConfigs.release.keyPassword = props['KEY_PASSWORD']
-    } else {
-        println 'android/app/signing.properties found, but some entries are missing.'
-        if (props == null) {
-            logger.warn '`props` was null'
-        } else {
-            logger.warn "has STORE_FILE [y/n]: ${props.containsKey('STORE_FILE')}"
-            logger.warn "has STORE_PASSWORD [y/n]: ${props.containsKey('STORE_PASSWORD')}"
-            logger.warn "has KEY_ALIAS [y/n]: ${props.containsKey('KEY_ALIAS')}"
-            logger.warn "has KEY_PASSWORD [y/n]: ${props.containsKey('KEY_PASSWORD')}"
-        }
-        android.buildTypes.release.signingConfig = null
-    }
-} else {
-    logger.warn 'android/app/signing.properties not found.'
-    logger.warn "cwd: ${new File(".").absolutePath}"
-    android.buildTypes.release.signingConfig = null
-}
-
 dependencies {
     // please keep this list sorted
     implementation project(':bugsnag-react-native')