Skip to content

Commit 5c565fb

Browse files
committed
Merge master into pause-is-closed
2 parents 62b152a + 18bdf1e commit 5c565fb

File tree

8 files changed

+49
-59
lines changed

8 files changed

+49
-59
lines changed

fastlane/Appfile

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
# The bundle identifier of your app
2-
app_identifier 'com.volz.drew.aao.rogue'
2+
app_identifier 'NFMTHAZVS9.com.drewvolz.stolaf'
33

44
# Your Apple email address
5-
6-
7-
# Developer Portal Team ID
8-
team_id 'NFMTHAZVS9'
5+
96

107
# you can even provide different app identifiers, Apple IDs and team names per lane:
118
# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

fastlane/Matchfile

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
git_url 'https://github.com/hawkrives/aao-keys'
22

33
# Your Apple Developer Portal username
4-
5-
6-
# The app identifiers to get profiles for
7-
app_identifier ['com.volz.drew.aao.rogue']
4+

fastlane/README.md

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -97,31 +97,16 @@ Runs all the tests
9797
fastlane ios screenshot
9898
```
9999
Take screenshots
100-
### ios go-rogue
101-
```
102-
fastlane ios go-rogue
103-
```
104-
Go rogue
105100
### ios build
106101
```
107102
fastlane ios build
108103
```
109104
Provisions the profiles; bumps the build number; builds the app
110-
### ios rogue-build
111-
```
112-
fastlane ios rogue-build
113-
```
114-
Build, but for the rogue devs
115-
### ios rogue-beta
116-
```
117-
fastlane ios rogue-beta
118-
```
119-
Make a beta, but for the rogue devs
120105
### ios beta
121106
```
122107
fastlane ios beta
123108
```
124-
Submit a new Beta Build to HockeyApp
109+
Submit a new Beta Build to Testflight
125110
### ios ci-run
126111
```
127112
fastlane ios ci-run

fastlane/lib/util.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@ def hockeyapp_version_commit
1616

1717
# Gets the version, either from Travis or from Hockey
1818
def current_build_number
19-
ENV['TRAVIS_BUILD_NUMBER'] if ENV.key?('TRAVIS_BUILD_NUMBER')
19+
if ENV.key?('TRAVIS_BUILD_NUMBER')
20+
return ENV['TRAVIS_BUILD_NUMBER']
21+
end
2022

2123
begin
22-
(latest_hockeyapp_version_number + 1).to_s
24+
(latest_testflight_build_number + 1).to_s
2325
rescue
2426
'1'
2527
end

fastlane/platforms/ios.rb

Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -13,55 +13,34 @@
1313
project: ENV['GYM_PROJECT'])
1414
end
1515

16-
desc 'Go rogue'
17-
lane :'go-rogue' do
18-
activate_rogue_team
19-
end
20-
2116
desc 'Provisions the profiles; bumps the build number; builds the app'
2217
lane :build do
23-
# make sure we have a copy of the data files
24-
bundle_data
25-
2618
sh('security find-identity -v -p codesigning')
2719

2820
# Build the app
2921
gym(export_method: 'ad-hoc')
3022
end
3123

32-
desc 'Build, but for the rogue devs'
33-
lane :'rogue-build' do
34-
activate_rogue_team
35-
match(type: 'adhoc', readonly: true)
36-
build
37-
end
38-
39-
desc 'Make a beta, but for the rogue devs'
40-
lane :'rogue-beta' do
41-
activate_rogue_team
42-
match(type: 'adhoc', readonly: true)
43-
set_version
44-
beta
45-
end
46-
47-
desc 'Submit a new Beta Build to HockeyApp'
24+
desc 'Submit a new Beta Build to Testflight'
4825
lane :beta do
49-
badge
26+
match(type: 'appstore', readonly: true)
27+
increment_build_number(build_number: latest_testflight_build_number + 1,
28+
xcodeproj: ENV['GYM_PROJECT'])
5029

51-
build
30+
gym(export_method: 'app-store')
5231

53-
hockey(notes: release_notes)
32+
testflight
5433
end
5534

5635
desc 'Run iOS builds or tests, as appropriate'
5736
lane :'ci-run' do
5837
# set up things so they can run
5938
authorize_ci_for_keys
6039
ci_keychains
61-
activate_rogue_team
6240

6341
# Set up code signing correctly
6442
# (more information: https://codesigning.guide)
43+
match(type: 'appstore', readonly: true)
6544
match(type: 'adhoc', readonly: true)
6645

6746
# set the app version

ios/AllAboutOlaf.xcodeproj/project.pbxproj

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -813,6 +813,7 @@
813813
13B07F871A680F5B00A75B9A /* Sources */,
814814
13B07F8C1A680F5B00A75B9A /* Frameworks */,
815815
13B07F8E1A680F5B00A75B9A /* Resources */,
816+
6776346D1ECC93FA00C6F018 /* Bundle Data Files */,
816817
00DD1BFF1BD5951E006B06BC /* Bundle React Native code and images */,
817818
);
818819
buildRules = (
@@ -1309,6 +1310,20 @@
13091310
shellPath = /bin/sh;
13101311
shellScript = "export NODE_BINARY=node\n../node_modules/react-native/packager/react-native-xcode.sh";
13111312
};
1313+
6776346D1ECC93FA00C6F018 /* Bundle Data Files */ = {
1314+
isa = PBXShellScriptBuildPhase;
1315+
buildActionMask = 2147483647;
1316+
files = (
1317+
);
1318+
inputPaths = (
1319+
);
1320+
name = "Bundle Data Files";
1321+
outputPaths = (
1322+
);
1323+
runOnlyForDeploymentPostprocessing = 0;
1324+
shellPath = /bin/sh;
1325+
shellScript = "npm run bundle-data";
1326+
};
13121327
/* End PBXShellScriptBuildPhase section */
13131328

13141329
/* Begin PBXSourcesBuildPhase section */
@@ -1392,7 +1407,10 @@
13921407
buildSettings = {
13931408
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
13941409
CLANG_ENABLE_MODULES = YES;
1410+
CODE_SIGN_ENTITLEMENTS = "AllAboutOlaf/All About Olaf.entitlements";
1411+
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
13951412
DEAD_CODE_STRIPPING = NO;
1413+
DEVELOPMENT_TEAM = 363G7T9TGX;
13961414
ENABLE_TESTABILITY = YES;
13971415
HEADER_SEARCH_PATHS = (
13981416
"$(inherited)",
@@ -1422,8 +1440,10 @@
14221440
"-ObjC",
14231441
"-lc++",
14241442
);
1425-
PRODUCT_BUNDLE_IDENTIFIER = "NFMTHAZVS9.com.drewvolz.stolaf-";
1443+
PRODUCT_BUNDLE_IDENTIFIER = NFMTHAZVS9.com.drewvolz.stolaf;
14261444
PRODUCT_NAME = "All About Olaf";
1445+
PROVISIONING_PROFILE = "328dc8bb-bb74-41f9-826a-ef2abd098c6a";
1446+
PROVISIONING_PROFILE_SPECIFIER = "match AppStore NFMTHAZVS9.com.drewvolz.stolaf";
14271447
SWIFT_OBJC_BRIDGING_HEADER = "AllAboutOlafUITests/AllAboutOlaf-Bridging-Header.h";
14281448
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
14291449
SWIFT_VERSION = 3.0;
@@ -1435,6 +1455,9 @@
14351455
buildSettings = {
14361456
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
14371457
CLANG_ENABLE_MODULES = YES;
1458+
CODE_SIGN_ENTITLEMENTS = "AllAboutOlaf/All About Olaf.entitlements";
1459+
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
1460+
DEVELOPMENT_TEAM = 363G7T9TGX;
14381461
HEADER_SEARCH_PATHS = (
14391462
"$(inherited)",
14401463
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include,
@@ -1463,8 +1486,10 @@
14631486
"-ObjC",
14641487
"-lc++",
14651488
);
1466-
PRODUCT_BUNDLE_IDENTIFIER = "NFMTHAZVS9.com.drewvolz.stolaf-";
1489+
PRODUCT_BUNDLE_IDENTIFIER = NFMTHAZVS9.com.drewvolz.stolaf;
14671490
PRODUCT_NAME = "All About Olaf";
1491+
PROVISIONING_PROFILE = "328dc8bb-bb74-41f9-826a-ef2abd098c6a";
1492+
PROVISIONING_PROFILE_SPECIFIER = "match AppStore NFMTHAZVS9.com.drewvolz.stolaf";
14681493
SWIFT_OBJC_BRIDGING_HEADER = "AllAboutOlafUITests/AllAboutOlaf-Bridging-Header.h";
14691494
SWIFT_VERSION = 3.0;
14701495
};
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
33
<plist version="1.0">
4-
<dict/>
4+
<dict>
5+
<key>aps-environment</key>
6+
<string>development</string>
7+
</dict>
58
</plist>

ios/AllAboutOlaf/Info.plist

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
<string>1</string>
3838
<key>CodePushDeploymentKey</key>
3939
<string>oSozdf5RtDr2j8T7PFz-oWgNmoBIEJN_nzUOz</string>
40+
<key>ITSAppUsesNonExemptEncryption</key>
41+
<false/>
4042
<key>LSApplicationQueriesSchemes</key>
4143
<array>
4244
<string>KSTORadio</string>
@@ -82,7 +84,7 @@
8284
</dict>
8385
</dict>
8486
<key>NSLocationWhenInUseUsageDescription</key>
85-
<string>We only use your location when you would expect us to, and never when you aren't using the app.</string>
87+
<string>We only use your location when you would expect us to, and never when you aren&apos;t using the app.</string>
8688
<key>UIAppFonts</key>
8789
<array>
8890
<string>Entypo.ttf</string>

0 commit comments

Comments
 (0)