Skip to content

Commit 6f9ab33

Browse files
committed
apply padding to ScrollView instead of the first item in the view
1 parent e8b1d44 commit 6f9ab33

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

source/views/components/filter/filter-toolbar.js

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,36 +41,33 @@ export function FilterToolbar({filters, onPopoverDismiss}: Props) {
4141
onPopoverDismiss(newFilter)
4242
}
4343

44-
const filterToggles = filters.map((filter, index) => (
44+
const filterToggles = filters.map(filter => (
4545
<FilterToolbarButton
4646
key={filter.spec.title}
4747
filter={filter}
4848
isActive={filter.enabled}
4949
onPopoverDismiss={onPopoverDismiss}
50-
style={index === 0 ? styles.first : null}
5150
title={filter.spec.title}
5251
/>
5352
))
5453

55-
const allButtons = filters.filter(f => f.enabled).map((filter, i) => {
54+
const allButtons = filters.filter(f => f.enabled).map(filter => {
5655
if (filter.type === 'toggle') {
5756
return (
5857
<ActiveFilterButton
5958
key={filter.spec.title}
6059
filter={filter}
6160
label={filter.spec.label}
6261
onRemove={filter => updateFilter(filter)}
63-
style={i === 0 ? styles.first : null}
6462
/>
6563
)
6664
} else if (filter.type === 'list') {
67-
return filter.spec.selected.map((selected, j) => (
65+
return filter.spec.selected.map(selected => (
6866
<ActiveFilterButton
6967
key={selected.title}
7068
filter={filter}
7169
label={selected.label || selected.title.toString()}
7270
onRemove={filter => updateFilter(filter, selected)}
73-
style={i === 0 && j === 0 ? styles.first : null}
7471
/>
7572
))
7673
}
@@ -81,11 +78,19 @@ export function FilterToolbar({filters, onPopoverDismiss}: Props) {
8178

8279
return (
8380
<React.Fragment>
84-
<ScrollView horizontal={true} showsHorizontalScrollIndicator={false}>
81+
<ScrollView
82+
contentContainerStyle={styles.scroller}
83+
horizontal={true}
84+
showsHorizontalScrollIndicator={false}
85+
>
8586
<Toolbar>{filterToggles}</Toolbar>
8687
</ScrollView>
8788
{anyFiltersEnabled && (
88-
<ScrollView horizontal={true} showsHorizontalScrollIndicator={false}>
89+
<ScrollView
90+
contentContainerStyle={styles.scroller}
91+
horizontal={true}
92+
showsHorizontalScrollIndicator={false}
93+
>
8994
{activeFilterButtons}
9095
</ScrollView>
9196
)}
@@ -94,7 +99,7 @@ export function FilterToolbar({filters, onPopoverDismiss}: Props) {
9499
}
95100

96101
const styles = StyleSheet.create({
97-
first: {
98-
marginLeft: 10,
102+
scroller: {
103+
paddingLeft: 10,
99104
},
100105
})

0 commit comments

Comments
 (0)